You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/07 08:35:38 UTC

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4389: Fixed vm-templates not being removed from primary storage with storag…

sureshanaparti commented on a change in pull request #4389:
URL: https://github.com/apache/cloudstack/pull/4389#discussion_r500834894



##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -6785,6 +6785,7 @@ public Answer execute(DestroyCommand cmd) {
                 if (s_logger.isInfoEnabled()) {
                     s_logger.info("Destroy template volume " + vol.getPath());
                 }
+                vmMo.markAsVirtualMachine(hyperHost.getHyperHostOwnerResourcePool(), hyperHost.getMor());

Review comment:
       @Spaceman1984 why to mark as VirtualMachine before destroying it ? will the destroy operation fail without it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org