You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "Pochatkin (via GitHub)" <gi...@apache.org> on 2023/04/18 16:52:19 UTC
[GitHub] [ignite-3] Pochatkin opened a new pull request, #1954: IGNITE-19048: Extract Subscribers and Accumulators to core module
Pochatkin opened a new pull request, #1954:
URL: https://github.com/apache/ignite-3/pull/1954
https://issues.apache.org/jira/browse/IGNITE-19048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] PakhomovAlexander commented on a diff in pull request #1954: IGNITE-19048: Extract Subscribers and Accumulators to core module
Posted by "PakhomovAlexander (via GitHub)" <gi...@apache.org>.
PakhomovAlexander commented on code in PR #1954:
URL: https://github.com/apache/ignite-3/pull/1954#discussion_r1176761582
##########
modules/core/src/main/java/org/apache/ignite/internal/util/subscription/ListAccumulator.java:
##########
@@ -15,44 +15,41 @@
* limitations under the License.
*/
-package org.apache.ignite.internal.deployunit.metastore;
+package org.apache.ignite.internal.util.subscription;
import java.util.ArrayList;
-import java.util.Collections;
import java.util.List;
import java.util.function.Function;
-import org.apache.ignite.internal.metastorage.Entry;
/**
* Plain list accumulator.
*
- * @param <T> Result value type.
+ * @param <R> Result value type.
Review Comment:
could you add javadoc for `R` type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] PakhomovAlexander merged pull request #1954: IGNITE-19048: Extract Subscribers and Accumulators to core module
Posted by "PakhomovAlexander (via GitHub)" <gi...@apache.org>.
PakhomovAlexander merged PR #1954:
URL: https://github.com/apache/ignite-3/pull/1954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org