[GitHub] [druid] maytasm commented on pull request #9773: Bad plan for table-lookup-lookup join with filter on first lookup and outer limit

[GitBox <gi...@apache.org>]

maytasm commented on pull request #9773:
URL: https://github.com/apache/druid/pull/9773#issuecomment-622590345


   > > A problem with this solution is that it does not guarantee to push the filter to the topmost DruidJoinQueryRel. This problem is showed in CalciteQueryTest#testInnerJoinTableLookupLookupWithFilterWithoutLimitWithAllColumns where the filter is on the inner DruidJoinQueryRel instead of the other DruidJoinQueryRel.
   > 
   > The plan in your current patch (cafca03) looks OK to me. It's exactly what we want. Do you have a different case that illustrates the issue you're talking about?
   
   In the patch (cafca03) I put an `@Ignore` because it does not generate the good plan that you see in the patch. It was generating the bad plan (same as the bad plan in this PR description). But now with the latest patch (7911b20) that test and other new added tests should all be good now (hence removed the `@Ignore`).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org