You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@ambari.apache.org by GitBox <gi...@apache.org> on 2018/11/20 15:01:18 UTC

[GitHub] tobias-istvan opened a new pull request #32: [AMBARI-24882] [Log Search UI] Change sticky filter panel solution from JS to clean css.

tobias-istvan opened a new pull request #32: [AMBARI-24882] [Log Search UI] Change sticky filter panel solution from JS to clean css.
URL: https://github.com/apache/ambari-logsearch/pull/32
 
 
   # What changes were proposed in this pull request?
   
   I removed the JavaScript scroll listener and changed to the `position: sticky` solution since the only browser which does not support is IE11 but even there the functionality won't break at all.
   
   ## How was this patch tested?
   
   It was tested manually, and by running unit tests:
   ```
   PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 292 of 292 SUCCESS (15.13 secs / 14.97 secs)
   ✨  Done in 45.62s.
   ```
   
   Please review [Ambari Contributing Guide](https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute) before opening a pull request.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services