[GitHub] [pinot] deemoliu commented on a diff in pull request #10915: [Upsert TTL] Add Watermark for each partitions for Primary key cleanup

["deemoliu (via GitHub)" <gi...@apache.org>]

deemoliu commented on code in PR #10915:
URL: https://github.com/apache/pinot/pull/10915#discussion_r1258696168


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java:
##########
@@ -84,6 +95,13 @@ protected void addOrReplaceSegment(ImmutableSegmentImpl segment, ThreadSafeMutab
       _primaryKeyToRecordLocationMap.compute(HashUtils.hashPrimaryKey(recordInfo.getPrimaryKey(), _hashFunction),
           (primaryKey, currentRecordLocation) -> {
             if (currentRecordLocation != null) {
+              // Skip the records that has comparisonValue timestamp earlier than (largestSeenTimestamp - TTL).

Review Comment:
   @Jackie-Jiang I think this is optional. Do you suggest me to remove it?
   
   For segments out of retention, we can skip them based on segmentMetadata.
   For segments within retention, some records has comparison column value out of retention, this logic will skip these records.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org