You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/12/09 04:51:56 UTC
[GitHub] [james-project] chibenwa commented on a change in pull request #782: JAMES-3680 SMTP/LMTP authentication configuration reworked
chibenwa commented on a change in pull request #782:
URL: https://github.com/apache/james-project/pull/782#discussion_r765431302
##########
File path: server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/netty/SMTPServer.java
##########
@@ -53,26 +54,41 @@
public class SMTPServer extends AbstractProtocolAsyncServer implements SMTPServerMBean {
private static final Logger LOGGER = LoggerFactory.getLogger(AbstractProtocolAsyncServer.class);
- public enum AuthenticationRequired {
- DISABLED,
- REQUIRED,
- ANNOUNCE;
-
- public static AuthenticationRequired parse(String authRequiredString) {
- if (authRequiredString.equals("true")) {
- return REQUIRED;
- } else if (authRequiredString.equals("announce")) {
- return ANNOUNCE;
+ public enum AuthenticationAnnounceMode {
+ NEVER,
+ FOR_UNAUTHORIZED_ADDRESSES,
+ ALWAYS;
+
+ public static AuthenticationAnnounceMode parseFallback(String authRequiredString) {
Review comment:
IMO no as we do not plan to remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org