You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/05/24 22:26:14 UTC

[GitHub] [commons-lang] garydgregory commented on a change in pull request #529: [LANG-1545] CharSequenceUtils.regionMatches is wrong dealing with Georgian.

garydgregory commented on a change in pull request #529:
URL: https://github.com/apache/commons-lang/pull/529#discussion_r429681039



##########
File path: src/test/java/org/apache/commons/lang3/StringUtilsTest.java
##########
@@ -3301,4 +3301,22 @@ public void testToRootUpperCase() {
             Locale.setDefault(defaultLocales);
         }
     }
+
+    @Test
+    public void testGeorgianSample() {
+        char[] arrayI = new char[]{(char) 305, (char) 1012};

Review comment:
       Please use hexadecimal for the values with a comment that shows the Unicode name for each character. Otherwise, there is not way to tell what this is doing without knowing the Unicode values from memory.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org