You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/08 19:52:42 UTC
[GitHub] [airflow] mik-laj commented on a change in pull request #11359: Strict type check for Microsoft
mik-laj commented on a change in pull request #11359:
URL: https://github.com/apache/airflow/pull/11359#discussion_r501974718
##########
File path: airflow/providers/microsoft/azure/log/wasb_task_handler.py
##########
@@ -17,11 +17,13 @@
# under the License.
import os
import shutil
+from typing import Optional, Tuple, Dict
from azure.common import AzureHttpError
from cached_property import cached_property
from airflow.configuration import conf
+from airflow.models import TaskInstance
Review comment:
I am afraid that this will not create cyclical imports. We've had a issue with this module before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org