You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Suman Karumuri <ma...@apache.org> on 2014/05/06 02:26:22 UTC

Review Request 21093: Showing status message in Job UI

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21093/
-----------------------------------------------------------

Review request for Aurora, David McLaughlin and Mark Chu-Carroll.


Bugs: AURORA-374
    https://issues.apache.org/jira/browse/AURORA-374


Repository: aurora


Description
-------

Bug fix.


Diffs
-----

  src/main/resources/org/apache/aurora/scheduler/http/ui/taskStatus.html 2cab2362aebce8015239051a2901de16b4a82ec5 

Diff: https://reviews.apache.org/r/21093/diff/


Testing
-------

Tested on local laptop. Attached screenshot.


Thanks,

Suman Karumuri


Re: Review Request 21093: Showing status message in Job UI

Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21093/#review42232
-----------------------------------------------------------

Ship it!


Ship It!

- David McLaughlin


On May 6, 2014, 12:43 a.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21093/
> -----------------------------------------------------------
> 
> (Updated May 6, 2014, 12:43 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-339 and AURORA-374
>     https://issues.apache.org/jira/browse/AURORA-339
>     https://issues.apache.org/jira/browse/AURORA-374
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Bug fix.
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/taskStatus.html 2cab2362aebce8015239051a2901de16b4a82ec5 
> 
> Diff: https://reviews.apache.org/r/21093/diff/
> 
> 
> Testing
> -------
> 
> Tested on local laptop. Attached screenshot.
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2014-05-05 at 5.41.10 PM.png
>   https://reviews.apache.org/media/uploaded/files/2014/05/06/2e4cbd97-44d6-4b40-9dfc-5f6acdc3922a__Screen_Shot_2014-05-05_at_5.41.10_PM.png
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>


Re: Review Request 21093: Showing status message in Job UI

Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21093/#review42230
-----------------------------------------------------------

Ship it!


Ship It!

- Mark Chu-Carroll


On May 5, 2014, 8:43 p.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21093/
> -----------------------------------------------------------
> 
> (Updated May 5, 2014, 8:43 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-339 and AURORA-374
>     https://issues.apache.org/jira/browse/AURORA-339
>     https://issues.apache.org/jira/browse/AURORA-374
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Bug fix.
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/taskStatus.html 2cab2362aebce8015239051a2901de16b4a82ec5 
> 
> Diff: https://reviews.apache.org/r/21093/diff/
> 
> 
> Testing
> -------
> 
> Tested on local laptop. Attached screenshot.
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2014-05-05 at 5.41.10 PM.png
>   https://reviews.apache.org/media/uploaded/files/2014/05/06/2e4cbd97-44d6-4b40-9dfc-5f6acdc3922a__Screen_Shot_2014-05-05_at_5.41.10_PM.png
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>


Re: Review Request 21093: Showing status message in Job UI

Posted by David Robinson <dr...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21093/#review42231
-----------------------------------------------------------

Ship it!


Ship It!

- David Robinson


On May 6, 2014, 12:43 a.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21093/
> -----------------------------------------------------------
> 
> (Updated May 6, 2014, 12:43 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-339 and AURORA-374
>     https://issues.apache.org/jira/browse/AURORA-339
>     https://issues.apache.org/jira/browse/AURORA-374
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Bug fix.
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/taskStatus.html 2cab2362aebce8015239051a2901de16b4a82ec5 
> 
> Diff: https://reviews.apache.org/r/21093/diff/
> 
> 
> Testing
> -------
> 
> Tested on local laptop. Attached screenshot.
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2014-05-05 at 5.41.10 PM.png
>   https://reviews.apache.org/media/uploaded/files/2014/05/06/2e4cbd97-44d6-4b40-9dfc-5f6acdc3922a__Screen_Shot_2014-05-05_at_5.41.10_PM.png
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>


Re: Review Request 21093: Showing status message in Job UI

Posted by Suman Karumuri <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21093/
-----------------------------------------------------------

(Updated May 6, 2014, 12:43 a.m.)


Review request for Aurora, David McLaughlin and Mark Chu-Carroll.


Bugs: AURORA-339 and AURORA-374
    https://issues.apache.org/jira/browse/AURORA-339
    https://issues.apache.org/jira/browse/AURORA-374


Repository: aurora


Description
-------

Bug fix.


Diffs
-----

  src/main/resources/org/apache/aurora/scheduler/http/ui/taskStatus.html 2cab2362aebce8015239051a2901de16b4a82ec5 

Diff: https://reviews.apache.org/r/21093/diff/


Testing
-------

Tested on local laptop. Attached screenshot.


File Attachments
----------------

Screen Shot 2014-05-05 at 5.41.10 PM.png
  https://reviews.apache.org/media/uploaded/files/2014/05/06/2e4cbd97-44d6-4b40-9dfc-5f6acdc3922a__Screen_Shot_2014-05-05_at_5.41.10_PM.png


Thanks,

Suman Karumuri


Re: Review Request 21093: Showing status message in Job UI

Posted by Suman Karumuri <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21093/
-----------------------------------------------------------

(Updated May 6, 2014, 12:42 a.m.)


Review request for Aurora, David McLaughlin and Mark Chu-Carroll.


Changes
-------

Fixed the status layout issue while at it. Updated screenshot.


Bugs: AURORA-374
    https://issues.apache.org/jira/browse/AURORA-374


Repository: aurora


Description
-------

Bug fix.


Diffs (updated)
-----

  src/main/resources/org/apache/aurora/scheduler/http/ui/taskStatus.html 2cab2362aebce8015239051a2901de16b4a82ec5 

Diff: https://reviews.apache.org/r/21093/diff/


Testing
-------

Tested on local laptop. Attached screenshot.


File Attachments (updated)
----------------

Screen Shot 2014-05-05 at 5.41.10 PM.png
  https://reviews.apache.org/media/uploaded/files/2014/05/06/2e4cbd97-44d6-4b40-9dfc-5f6acdc3922a__Screen_Shot_2014-05-05_at_5.41.10_PM.png


Thanks,

Suman Karumuri


Re: Review Request 21093: Showing status message in Job UI

Posted by Suman Karumuri <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21093/
-----------------------------------------------------------

(Updated May 6, 2014, 12:28 a.m.)


Review request for Aurora, David McLaughlin and Mark Chu-Carroll.


Bugs: AURORA-374
    https://issues.apache.org/jira/browse/AURORA-374


Repository: aurora


Description
-------

Bug fix.


Diffs
-----

  src/main/resources/org/apache/aurora/scheduler/http/ui/taskStatus.html 2cab2362aebce8015239051a2901de16b4a82ec5 

Diff: https://reviews.apache.org/r/21093/diff/


Testing
-------

Tested on local laptop. Attached screenshot.


File Attachments (updated)
----------------

Now showing task status
  https://reviews.apache.org/media/uploaded/files/2014/05/06/9822ee9c-c1fd-4798-88ec-9fe6b289e5a6__Screen_Shot_2014-05-05_at_5.23.34_PM.png


Thanks,

Suman Karumuri