[GitHub] [sling-org-apache-sling-scripting-sightly-testing] enapps-enorman commented on a change in pull request #6: SLING-10684 add integration tests to verify

[GitBox <gi...@apache.org>]

enapps-enorman commented on a change in pull request #6:
URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing/pull/6#discussion_r679434629



##########
File path: pom.xml
##########
@@ -336,13 +336,13 @@ Require-Capability: osgi.extender;filter:="(&(osgi.extender=sling.scripting)(ver
         <dependency>
             <groupId>org.apache.sling</groupId>
             <artifactId>org.apache.sling.scripting.sightly.runtime</artifactId>
-            <version>1.2.4-1.4.0</version>
+            <version>1.2.5-1.4.0-SNAPSHOT</version>
             <scope>provided</scope>
         </dependency>
         <dependency>
             <groupId>org.apache.sling</groupId>
             <artifactId>org.apache.sling.scripting.sightly.compiler</artifactId>
-            <version>1.2.12-1.4.0</version>
+            <version>1.2.13-1.4.0-SNAPSHOT</version>

Review comment:
       > I don't think you need to bump the compiler.
   
   You are probably right.  None of the tests here are directly impacted by https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/8 
   
   The testing for SLING-10682 was done with local unit tests.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org