[GitHub] [doris] zhengshiJ commented on a diff in pull request #17661: [fix](Nereids) type coercion for subquery

["zhengshiJ (via GitHub)" <gi...@apache.org>]

zhengshiJ commented on code in PR #17661:
URL: https://github.com/apache/doris/pull/17661#discussion_r1133378928


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/FunctionBinder.java:
##########
@@ -212,4 +215,17 @@ public Expression visitBetween(Between between, CascadesContext context) {
         Between newBetween = between.withChildren(rewrittenChildren);
         return TypeCoercionUtils.processBetween(newBetween);
     }
+
+    @Override
+    public Expression visitInSubquery(InSubquery inSubquery, CascadesContext context) {
+        Expression newCompareExpr = inSubquery.getCompareExpr().accept(this, context);
+        Expression newListQuery = inSubquery.getListQuery().accept(this, context);
+        ComparisonPredicate newCpAfterUnNestingSubquery =
+                new EqualTo(newCompareExpr, ((ListQuery) newListQuery).getQueryPlan().getOutput().get(0));

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org