Re: [PR] [FLINK-30081][runtime] Reset unused options like jvm-overhead.min/max for local executor [flink]

["liuml07 (via GitHub)" <gi...@apache.org>]

liuml07 commented on code in PR #22547:
URL: https://github.com/apache/flink/pull/22547#discussion_r1564418871


##########
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutorResourceUtils.java:
##########
@@ -285,4 +286,15 @@ private static <T> void setConfigOptionToDefaultIfNotSet(
             config.set(option, defaultValue);
         }
     }
+
+    private static <T> void resetConfigOption(
+            Configuration config, ConfigOption<T> option, T value) {
+        if (config.contains(option)) {
+            LOG.info(
+                    "The configuration option {} has no effect for local execution, resetting to {}",
+                    option.key(),
+                    value);
+        }
+        config.set(option, value);
+    }

Review Comment:
   @xintongsong how do I trigger a Jenkins build? I tested manually and the code snippet in the JIRA passes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org