You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/06 08:52:02 UTC

[GitHub] [incubator-nuttx-apps] anchao commented on a diff in pull request #1307: netutils/dhcpc:Make DHCP xid random

anchao commented on code in PR #1307:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1307#discussion_r963438859


##########
netutils/dhcpc/dhcpc.c:
##########
@@ -145,7 +147,7 @@ struct dhcpc_state_s
  * Private Data
  ****************************************************************************/
 
-static const uint8_t xid[4] =

Review Comment:
   how about move the global array to corresponding function to save the rodata?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org