You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by jwagenleitner <gi...@git.apache.org> on 2015/11/09 23:58:46 UTC

[GitHub] incubator-groovy pull request: GROOVY-6922 - JsonSlurper loses tra...

GitHub user jwagenleitner opened a pull request:

    https://github.com/apache/incubator-groovy/pull/184

    GROOVY-6922 - JsonSlurper loses trailing 0's in numbers

    This change is dependent on the change made in commit 84467fddc64744cc05d2b91b8704c753a9fb3d04 in master to the [CharScanner#parseBigDecimal(char[],int,int)] (https://github.com/apache/incubator-groovy/commit/84467fddc64744cc05d2b91b8704c753a9fb3d04#diff-d0df59d6b1bac924a44389e6b41aac99R687) method.
    
    The code being replaced looked like it was code left over from when the method returned a double for decimal values.  This change uses the [BigDecimal(char[],int,int)] (http://docs.oracle.com/javase/7/docs/api/java/math/BigDecimal.html#BigDecimal(char[],%20int,%20int)) constructor (available since 1.5) for parsing of the decimal string and also eliminates the new String object allocations.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jwagenleitner/incubator-groovy GROOVY-6922

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-groovy/pull/184.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #184
    
----
commit 75a037c9ff26265790599bfd1d010ad75c6d5b70
Author: John Wagenleitner <jo...@gmail.com>
Date:   2015-11-07T20:50:14Z

    GROOVY-6922 - JsonSlurper loses trailing 0's in numbers

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-groovy pull request: GROOVY-6922 - JsonSlurper loses tra...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-groovy/pull/184


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---