You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrew Cornwall (JIRA)" <ji...@apache.org> on 2008/03/05 18:13:41 UTC
[jira] Created: (HARMONY-5575) [classlib][pack200]
[classlib][pack200]
-------------------
Key: HARMONY-5575
URL: https://issues.apache.org/jira/browse/HARMONY-5575
Project: Harmony
Issue Type: Improvement
Components: Classlib
Environment: All pack200
Reporter: Andrew Cornwall
There are performance issues with Pack200. The real problem is probably the fact that I'm creating lots of garbage in the comparators, but some of that can be alleviated by deferring the sort until after all the ClassFileEntries are known.
This patch defers the sort. It reduces the runtime of the JUnit tests from 12.812 seconds to 7.359 seconds, which is not insignificant.
(Unfortunately, this patch also appears to have changed existing tabs to spaces, so it's larger than it should be.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-5575) [classlib][pack200] Pack200 is slow
adding to classpool
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sian January reassigned HARMONY-5575:
-------------------------------------
Assignee: Sian January
> [classlib][pack200] Pack200 is slow adding to classpool
> -------------------------------------------------------
>
> Key: HARMONY-5575
> URL: https://issues.apache.org/jira/browse/HARMONY-5575
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: All pack200
> Reporter: Andrew Cornwall
> Assignee: Sian January
> Attachments: main.patch
>
>
> There are performance issues with Pack200. The real problem is probably the fact that I'm creating lots of garbage in the comparators, but some of that can be alleviated by deferring the sort until after all the ClassFileEntries are known.
> This patch defers the sort. It reduces the runtime of the JUnit tests from 12.812 seconds to 7.359 seconds, which is not insignificant.
> (Unfortunately, this patch also appears to have changed existing tabs to spaces, so it's larger than it should be.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-5575) [classlib][pack200] Pack200 is slow
adding to classpool
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sian January resolved HARMONY-5575.
-----------------------------------
Resolution: Fixed
Fix Version/s: 5.0M6
Patch applied at r634333. Please check that this fully resolves your issue.
> [classlib][pack200] Pack200 is slow adding to classpool
> -------------------------------------------------------
>
> Key: HARMONY-5575
> URL: https://issues.apache.org/jira/browse/HARMONY-5575
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: All pack200
> Reporter: Andrew Cornwall
> Assignee: Sian January
> Fix For: 5.0M6
>
> Attachments: main.patch
>
>
> There are performance issues with Pack200. The real problem is probably the fact that I'm creating lots of garbage in the comparators, but some of that can be alleviated by deferring the sort until after all the ClassFileEntries are known.
> This patch defers the sort. It reduces the runtime of the JUnit tests from 12.812 seconds to 7.359 seconds, which is not insignificant.
> (Unfortunately, this patch also appears to have changed existing tabs to spaces, so it's larger than it should be.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-5575) [classlib][pack200] Pack200 is slow
adding to classpool
Posted by "Andrew Cornwall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Cornwall closed HARMONY-5575.
------------------------------------
Patch applied as expected. Thanks!
> [classlib][pack200] Pack200 is slow adding to classpool
> -------------------------------------------------------
>
> Key: HARMONY-5575
> URL: https://issues.apache.org/jira/browse/HARMONY-5575
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: All pack200
> Reporter: Andrew Cornwall
> Assignee: Sian January
> Fix For: 5.0M6
>
> Attachments: main.patch
>
>
> There are performance issues with Pack200. The real problem is probably the fact that I'm creating lots of garbage in the comparators, but some of that can be alleviated by deferring the sort until after all the ClassFileEntries are known.
> This patch defers the sort. It reduces the runtime of the JUnit tests from 12.812 seconds to 7.359 seconds, which is not insignificant.
> (Unfortunately, this patch also appears to have changed existing tabs to spaces, so it's larger than it should be.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5575) [classlib][pack200] Pack200 is slow
adding to classpool
Posted by "Andrew Cornwall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Cornwall updated HARMONY-5575:
-------------------------------------
Summary: [classlib][pack200] Pack200 is slow adding to classpool (was: [classlib][pack200])
> [classlib][pack200] Pack200 is slow adding to classpool
> -------------------------------------------------------
>
> Key: HARMONY-5575
> URL: https://issues.apache.org/jira/browse/HARMONY-5575
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: All pack200
> Reporter: Andrew Cornwall
> Attachments: main.patch
>
>
> There are performance issues with Pack200. The real problem is probably the fact that I'm creating lots of garbage in the comparators, but some of that can be alleviated by deferring the sort until after all the ClassFileEntries are known.
> This patch defers the sort. It reduces the runtime of the JUnit tests from 12.812 seconds to 7.359 seconds, which is not insignificant.
> (Unfortunately, this patch also appears to have changed existing tabs to spaces, so it's larger than it should be.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5575) [classlib][pack200]
Posted by "Andrew Cornwall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Cornwall updated HARMONY-5575:
-------------------------------------
Attachment: main.patch
main.patch contains the code to implement this change.
> [classlib][pack200]
> -------------------
>
> Key: HARMONY-5575
> URL: https://issues.apache.org/jira/browse/HARMONY-5575
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: All pack200
> Reporter: Andrew Cornwall
> Attachments: main.patch
>
>
> There are performance issues with Pack200. The real problem is probably the fact that I'm creating lots of garbage in the comparators, but some of that can be alleviated by deferring the sort until after all the ClassFileEntries are known.
> This patch defers the sort. It reduces the runtime of the JUnit tests from 12.812 seconds to 7.359 seconds, which is not insignificant.
> (Unfortunately, this patch also appears to have changed existing tabs to spaces, so it's larger than it should be.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.