You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by suresh sadhu <ma...@gmail.com> on 2013/10/18 12:56:28 UTC
Review Request 14738: Testscript for DeployVM User data enhancement
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14738/
-----------------------------------------------------------
Review request for cloudstack, SrikanteswaraRao Talluri and Prasanna Santhanam.
Bugs: cloudstack-2272
https://issues.apache.org/jira/browse/cloudstack-2272
Repository: cloudstack-git
Description
-------
This script validates VM-deployment with user-data of size more than 2048(which includes deployment as well as validation part after applying the user-data)
Diffs
-----
test/integration/component/test_deploy_vm_userdata_reg.py PRE-CREATION
Diff: https://reviews.apache.org/r/14738/diff/
Testing
-------
yes
Thanks,
suresh sadhu
Re: Review Request 14738: Testscript for DeployVM User data enhancement
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14738/#review27237
-----------------------------------------------------------
test/integration/component/test_deploy_vm_userdata_reg.py
<https://reviews.apache.org/r/14738/#comment53054>
This test is not cleaning up the resources it has created.
- SrikanteswaraRao Talluri
On Oct. 18, 2013, 10:56 a.m., suresh sadhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14738/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2013, 10:56 a.m.)
>
>
> Review request for cloudstack, SrikanteswaraRao Talluri and Prasanna Santhanam.
>
>
> Bugs: cloudstack-2272
> https://issues.apache.org/jira/browse/cloudstack-2272
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This script validates VM-deployment with user-data of size more than 2048(which includes deployment as well as validation part after applying the user-data)
>
>
>
>
> Diffs
> -----
>
> test/integration/component/test_deploy_vm_userdata_reg.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14738/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> suresh sadhu
>
>
Re: Review Request 14738: Testscript for DeployVM User data enhancement
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14738/#review27236
-----------------------------------------------------------
test/integration/component/test_deploy_vm_userdata_reg.py
<https://reviews.apache.org/r/14738/#comment53046>
remove this
test/integration/component/test_deploy_vm_userdata_reg.py
<https://reviews.apache.org/r/14738/#comment53047>
remove this,you are not using this anywhere.
test/integration/component/test_deploy_vm_userdata_reg.py
<https://reviews.apache.org/r/14738/#comment53048>
unnecessary line
test/integration/component/test_deploy_vm_userdata_reg.py
<https://reviews.apache.org/r/14738/#comment53049>
remove this line
test/integration/component/test_deploy_vm_userdata_reg.py
<https://reviews.apache.org/r/14738/#comment53050>
Is 'test' tag required?
test/integration/component/test_deploy_vm_userdata_reg.py
<https://reviews.apache.org/r/14738/#comment53051>
remove print statement , use self.debug instead
test/integration/component/test_deploy_vm_userdata_reg.py
<https://reviews.apache.org/r/14738/#comment53053>
fix the indentation
test/integration/component/test_deploy_vm_userdata_reg.py
<https://reviews.apache.org/r/14738/#comment53052>
remove this line
- SrikanteswaraRao Talluri
On Oct. 18, 2013, 10:56 a.m., suresh sadhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14738/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2013, 10:56 a.m.)
>
>
> Review request for cloudstack, SrikanteswaraRao Talluri and Prasanna Santhanam.
>
>
> Bugs: cloudstack-2272
> https://issues.apache.org/jira/browse/cloudstack-2272
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This script validates VM-deployment with user-data of size more than 2048(which includes deployment as well as validation part after applying the user-data)
>
>
>
>
> Diffs
> -----
>
> test/integration/component/test_deploy_vm_userdata_reg.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14738/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> suresh sadhu
>
>
Re: Review Request 14738: Testscript for DeployVM User data enhancement
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14738/#review28097
-----------------------------------------------------------
Ship it!
Ship It!
- SrikanteswaraRao Talluri
On Oct. 31, 2013, 1:11 a.m., suresh sadhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14738/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2013, 1:11 a.m.)
>
>
> Review request for cloudstack, sailaja mada, sanjeev n, Sowmya Krishnan, and SrikanteswaraRao Talluri.
>
>
> Bugs: cloudstack-2272
> https://issues.apache.org/jira/browse/cloudstack-2272
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This script validates VM-deployment with user-data of size more than 2048(which includes deployment as well as validation part after applying the user-data)
>
>
>
>
> Diffs
> -----
>
> test/integration/component/test_deploy_vm_userdata_reg.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14738/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> suresh sadhu
>
>
Re: Review Request 14738: Testscript for DeployVM User data enhancement
Posted by sanjeev n <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14738/#review28087
-----------------------------------------------------------
Ship it!
Looks good to me.
- sanjeev n
On Oct. 31, 2013, 1:11 a.m., suresh sadhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14738/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2013, 1:11 a.m.)
>
>
> Review request for cloudstack, sailaja mada, sanjeev n, Sowmya Krishnan, and SrikanteswaraRao Talluri.
>
>
> Bugs: cloudstack-2272
> https://issues.apache.org/jira/browse/cloudstack-2272
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This script validates VM-deployment with user-data of size more than 2048(which includes deployment as well as validation part after applying the user-data)
>
>
>
>
> Diffs
> -----
>
> test/integration/component/test_deploy_vm_userdata_reg.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14738/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> suresh sadhu
>
>
Re: Review Request 14738: Testscript for DeployVM User data enhancement
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14738/
-----------------------------------------------------------
(Updated Oct. 31, 2013, 1:11 a.m.)
Review request for cloudstack, sailaja mada, sanjeev n, Sowmya Krishnan, and SrikanteswaraRao Talluri.
Changes
-------
need help with reviews! :)
Bugs: cloudstack-2272
https://issues.apache.org/jira/browse/cloudstack-2272
Repository: cloudstack-git
Description
-------
This script validates VM-deployment with user-data of size more than 2048(which includes deployment as well as validation part after applying the user-data)
Diffs
-----
test/integration/component/test_deploy_vm_userdata_reg.py PRE-CREATION
Diff: https://reviews.apache.org/r/14738/diff/
Testing
-------
yes
Thanks,
suresh sadhu
Re: Review Request 14738: Testscript for DeployVM User data enhancement
Posted by suresh sadhu <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14738/
-----------------------------------------------------------
(Updated Oct. 23, 2013, 10:57 a.m.)
Review request for cloudstack, SrikanteswaraRao Talluri and Prasanna Santhanam.
Changes
-------
addressed all the review comments
Bugs: cloudstack-2272
https://issues.apache.org/jira/browse/cloudstack-2272
Repository: cloudstack-git
Description
-------
This script validates VM-deployment with user-data of size more than 2048(which includes deployment as well as validation part after applying the user-data)
Diffs (updated)
-----
test/integration/component/test_deploy_vm_userdata_reg.py PRE-CREATION
Diff: https://reviews.apache.org/r/14738/diff/
Testing
-------
yes
Thanks,
suresh sadhu