[I] Share accounts can be created and edited but never opened — there is no detail view and no lifecycle actions [fineract-backoffice-ui]

["Aman-Mittal (via GitHub)" <gi...@apache.org>]

Aman-Mittal opened a new issue, #265:
URL: https://github.com/apache/fineract-backoffice-ui/issues/265

   ## Summary
   
   Share accounts are the only account type in the app with no way to open one. You can list them and you can create and edit them, and that is the end of it.
   
   `src/app/features/products/products.routes.ts` has:
   
   ```
   shares            -> share-accounts-list
   shares/create     -> share-account-form
   shares/edit/:id   -> share-account-form
   ```
   
   There is no `shares/view/:id`, and `src/app/features/products/shares/` contains no view component. Every other account type has one:
   
   | Account type | List | Create/edit | Detail view | Lifecycle actions |
   |---|---|---|---|---|
   | Loan | yes | yes | yes | yes |
   | Savings | yes | yes | yes | approve, activate, reject, withdraw, close, block/unblock, apply annual fees, calculate interest |
   | Fixed deposit | yes | yes | yes | via the shared account action form |
   | Recurring deposit | yes | yes | yes | via the shared account action form |
   | **Share** | yes | yes | **no** | **no** |
   
   The shared `account-action-form.component.ts` covers `loan`, `savings`, `fixed` and `recurring`. Shares are not one of its account types, so there is no path to any share command either.
   
   ## What the platform offers that is unreachable today
   
   `GET /accounts/share/{id}` returns the account with its purchased-share rows, charges, dividends and summary. `POST /accounts/share/{id}?command=` accepts `approve`, `reject`, `undoapproval`, `activate`, `applyadditionalshares`, `approveadditionalshares`, `rejectadditionalshares` and `redeemshares`. None of it is reachable from the UI.
   
   ## Proposed scope
   
   A `shares/view/:id` screen following the shape the group detail view settled on in #253, so the two read the same way:
   
   - header with account number, product, client and a status badge
   - an actions menu gated on the current status and on permission
   - tabs: **Overview** (summary, share counts, unit price, dividends), **Transactions** (purchased/redeemed rows), **Charges**, **Dividends**
   - lifecycle commands: approve, reject, undo approval, activate
   - share commands: apply additional shares, approve/reject additional shares, redeem shares
   - a link into the account from the list, which today has no way in
   
   New components go through the adapter boundary (ADR-0003) — `I18N`, `OVERLAY` via `NotificationService`/`DialogService`, `STORAGE`, `DOWNLOAD` — and state is held in signals rather than plain fields.
   
   ## Testing
   
   - unit specs for the view and each dialog
   - a mocked e2e spec asserting the requests the screen sends, including the command bodies
   - a real-backend e2e spec driving the whole thing through the UI, with no API seeding: create the share product, create the account, approve, activate, apply additional shares, redeem
   
   ## Business Value
   
   Share accounts are how a member holds equity in the institution — in a cooperative or a member-owned bank that is the member's stake, and issuing, approving and redeeming shares is core registry work rather than a side feature. Today an officer can open an account and then has no way to look at it: not the balance of shares held, not the purchase history, not the dividends posted. Approving a share application, or redeeming a member's shares when they leave, cannot be done here at all.
   
   That is not merely a missing screen; it means share administration has to happen somewhere else entirely, and the two records drift. Finishing this makes the app the single place the registry is maintained, and it is the last account type standing between the app and complete account coverage.
   
   ## Notes
   
   The list screen already exists and is not being replaced — it only needs a link into the new view.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Share accounts can be created and edited but never opened — there is no detail view and no lifecycle actions [fineract-backoffice-ui]

["Aman-Mittal (via GitHub)" <gi...@apache.org>]

Aman-Mittal closed issue #265: Share accounts can be created and edited but never opened — there is no detail view and no lifecycle actions
URL: https://github.com/apache/fineract-backoffice-ui/issues/265


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org