You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Paddy0523 (via GitHub)" <gi...@apache.org> on 2023/08/31 05:52:39 UTC
[GitHub] [iceberg] Paddy0523 opened a new issue, #8440: Logic about Hive version checking in MetastoreLock
Paddy0523 opened a new issue, #8440:
URL: https://github.com/apache/iceberg/issues/8440
### Query engine
Flink1.16
### Question
Why the findLock method check that HIVE_VERSION is higher than HIVE2
<img width="1140" alt="image" src="https://github.com/apache/iceberg/assets/46181516/31344b39-d37d-46b1-acae-d631e0213141">
but ensure that HIVE_VERSION is less than HIVE2 before calling findLock
<img width="1109" alt="image" src="https://github.com/apache/iceberg/assets/46181516/299a6be4-d961-441d-89ff-c6e7bb5bb6db">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pvary commented on issue #8440: Logic about Hive version checking in MetastoreLock
Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary commented on issue #8440:
URL: https://github.com/apache/iceberg/issues/8440#issuecomment-1713201574
@Paddy0523: Ohh, I get it...
Thanks for catching this.
Could you please create a test which fails in `TestHiveCommitLocks`, and fix this?
Thanks,
Peter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Logic about Hive version checking in MetastoreLock [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #8440:
URL: https://github.com/apache/iceberg/issues/8440#issuecomment-2351849925
This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Paddy0523 commented on issue #8440: Logic about Hive version checking in MetastoreLock
Posted by "Paddy0523 (via GitHub)" <gi...@apache.org>.
Paddy0523 commented on issue #8440:
URL: https://github.com/apache/iceberg/issues/8440#issuecomment-1706024304

Does the if statement need to be replaced with the following code
`if(HiveVersion.min(HiveVersion.HIVE2))
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pvary commented on issue #8440: Logic about Hive version checking in MetastoreLock
Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary commented on issue #8440:
URL: https://github.com/apache/iceberg/issues/8440#issuecomment-1702783772
The `createLock` rethrows the exception we originally got if we can not use `findLock` to look for the lock. If we can use `findLock`, then we try to recover.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Paddy0523 commented on issue #8440: Logic about Hive version checking in MetastoreLock
Posted by "Paddy0523 (via GitHub)" <gi...@apache.org>.
Paddy0523 commented on issue #8440:
URL: https://github.com/apache/iceberg/issues/8440#issuecomment-1706021285
> The `createLock` rethrows the exception we originally got if we can not use `findLock` to look for the lock. If we can use `findLock`, then we try to recover.
In the current logic, if an error occurs while obtaining the lock and HiveVersion is lower than Hive2, the findLock method is called and a new error is thrown in this code.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Paddy0523 commented on issue #8440: Logic about Hive version checking in MetastoreLock
Posted by "Paddy0523 (via GitHub)" <gi...@apache.org>.
Paddy0523 commented on issue #8440:
URL: https://github.com/apache/iceberg/issues/8440#issuecomment-1713208994
> @Paddy0523: Ohh, I get it... Thanks for catching this. Could you please create a test which fails in `TestHiveCommitLocks`, and fix this?
>
> Thanks, Peter
I'm happy to do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org