You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@celeborn.apache.org by "afterincomparableyum (via GitHub)" <gi...@apache.org> on 2026/02/01 05:28:25 UTC

Re: [PR] [CELEBORN-2221][CIP-14] Support writing with compression in C++ client [celeborn]

afterincomparableyum commented on code in PR #3575:
URL: https://github.com/apache/celeborn/pull/3575#discussion_r2750570268


##########
cpp/celeborn/client/ShuffleClient.h:
##########
@@ -249,6 +250,8 @@ class ShuffleClientImpl
   static constexpr size_t kBatchHeaderSize = 4 * 4;
 
   const std::string appUniqueId_;
+  const bool shuffleCompressionEnabled_;
+  std::unique_ptr<compress::Compressor> compressor_;

Review Comment:
   I've applied the suggestion recommended here @SteNicholas 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org