You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2016/11/30 00:15:05 UTC
[kudu-CR] [c++ client] propagate timestamp for write operations
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5269
Change subject: [c++ client] propagate timestamp for write operations
......................................................................
[c++ client] propagate timestamp for write operations
Updated the Kudu C++ client library to propagate timestamp for write
operations. This is a fix for
KUDU-1770 C++ client does not propate timestamp for write operations
This patch also enables the integration test which was failing prior
to this fix: ConsistencyITest.TestTimestampPropagationForWriteOps
Change-Id: I17feb6b2dacd0ba7c8b57464f1a50de99de2f772
---
M src/kudu/client/batcher.cc
1 file changed, 10 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/5269/1
--
To view, visit http://gerrit.cloudera.org:8080/5269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I17feb6b2dacd0ba7c8b57464f1a50de99de2f772
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] KUDU-1770 [c++ client] propagate timestamp for write operations
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello David Ribeiro Alves, Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5269
to look at the new patch set (#6).
Change subject: KUDU-1770 [c++ client] propagate timestamp for write operations
......................................................................
KUDU-1770 [c++ client] propagate timestamp for write operations
Updated the Kudu C++ client library to propagate timestamp for write
operations.
This is a fix for
KUDU-1770 C++ client: propagate timestamp for write operations
This patch also enables the integration test which was failing prior
to this fix: ConsistencyITest.TestTimestampPropagationForWriteOps
Change-Id: I17feb6b2dacd0ba7c8b57464f1a50de99de2f772
---
M src/kudu/client/batcher.cc
M src/kudu/integration-tests/consistency-itest.cc
2 files changed, 11 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/5269/6
--
To view, visit http://gerrit.cloudera.org:8080/5269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I17feb6b2dacd0ba7c8b57464f1a50de99de2f772
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] KUDU-1770 [c++ client] propagate timestamp for write operations
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1770 [c++ client] propagate timestamp for write operations
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5269/2//COMMIT_MSG
Commit Message:
Line 12: KUDU-1770 C++ client does not propate timestamp for write operations
> It would be better to prefix the first line of the commit message with "KUD
Done
--
To view, visit http://gerrit.cloudera.org:8080/5269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I17feb6b2dacd0ba7c8b57464f1a50de99de2f772
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [c++ client] propagate timestamp for write operations
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: [c++ client] propagate timestamp for write operations
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I17feb6b2dacd0ba7c8b57464f1a50de99de2f772
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-1770 [c++ client] propagate timestamp for write operations
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: KUDU-1770 [c++ client] propagate timestamp for write operations
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I17feb6b2dacd0ba7c8b57464f1a50de99de2f772
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-1770 [c++ client] propagate timestamp for write operations
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello David Ribeiro Alves, Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5269
to look at the new patch set (#4).
Change subject: KUDU-1770 [c++ client] propagate timestamp for write operations
......................................................................
KUDU-1770 [c++ client] propagate timestamp for write operations
Updated the Kudu C++ client library to propagate timestamp for write
operations.
This is a fix for
KUDU-1770 C++ client: propagate timestamp for write operations
This patch also enables the integration test which was failing prior
to this fix: ConsistencyITest.TestTimestampPropagationForWriteOps
Change-Id: I17feb6b2dacd0ba7c8b57464f1a50de99de2f772
---
M src/kudu/client/batcher.cc
M src/kudu/integration-tests/consistency-itest.cc
2 files changed, 14 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/5269/4
--
To view, visit http://gerrit.cloudera.org:8080/5269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I17feb6b2dacd0ba7c8b57464f1a50de99de2f772
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [c++ client] propagate timestamp for write operations
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: [c++ client] propagate timestamp for write operations
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I17feb6b2dacd0ba7c8b57464f1a50de99de2f772
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-1770 [c++ client] propagate timestamp for write operations
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello David Ribeiro Alves, Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5269
to look at the new patch set (#3).
Change subject: KUDU-1770 [c++ client] propagate timestamp for write operations
......................................................................
KUDU-1770 [c++ client] propagate timestamp for write operations
Updated the Kudu C++ client library to propagate timestamp for write
operations. This is a fix for
KUDU-1770 C++ client does not propate timestamp for write operations
This patch also enables the integration test which was failing prior
to this fix: ConsistencyITest.TestTimestampPropagationForWriteOps
Change-Id: I17feb6b2dacd0ba7c8b57464f1a50de99de2f772
---
M src/kudu/client/batcher.cc
M src/kudu/integration-tests/consistency-itest.cc
2 files changed, 11 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/5269/3
--
To view, visit http://gerrit.cloudera.org:8080/5269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I17feb6b2dacd0ba7c8b57464f1a50de99de2f772
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] KUDU-1770 [c++ client] propagate timestamp for write operations
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged.
Change subject: KUDU-1770 [c++ client] propagate timestamp for write operations
......................................................................
KUDU-1770 [c++ client] propagate timestamp for write operations
Updated the Kudu C++ client library to propagate timestamp for write
operations.
This is a fix for
KUDU-1770 C++ client: propagate timestamp for write operations
This patch also enables the integration test which was failing prior
to this fix: ConsistencyITest.TestTimestampPropagationForWriteOps
Change-Id: I17feb6b2dacd0ba7c8b57464f1a50de99de2f772
Reviewed-on: http://gerrit.cloudera.org:8080/5269
Reviewed-by: David Ribeiro Alves <dr...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/client/batcher.cc
M src/kudu/integration-tests/consistency-itest.cc
2 files changed, 11 insertions(+), 4 deletions(-)
Approvals:
David Ribeiro Alves: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I17feb6b2dacd0ba7c8b57464f1a50de99de2f772
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] KUDU-1770 [c++ client] propagate timestamp for write operations
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: KUDU-1770 [c++ client] propagate timestamp for write operations
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I17feb6b2dacd0ba7c8b57464f1a50de99de2f772
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [c++ client] propagate timestamp for write operations
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#2).
Change subject: [c++ client] propagate timestamp for write operations
......................................................................
[c++ client] propagate timestamp for write operations
Updated the Kudu C++ client library to propagate timestamp for write
operations. This is a fix for
KUDU-1770 C++ client does not propate timestamp for write operations
This patch also enables the integration test which was failing prior
to this fix: ConsistencyITest.TestTimestampPropagationForWriteOps
Change-Id: I17feb6b2dacd0ba7c8b57464f1a50de99de2f772
---
M src/kudu/client/batcher.cc
M src/kudu/integration-tests/consistency-itest.cc
2 files changed, 11 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/5269/2
--
To view, visit http://gerrit.cloudera.org:8080/5269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I17feb6b2dacd0ba7c8b57464f1a50de99de2f772
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [c++ client] propagate timestamp for write operations
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: [c++ client] propagate timestamp for write operations
......................................................................
Patch Set 2:
(1 comment)
Overall looks good
http://gerrit.cloudera.org:8080/#/c/5269/2//COMMIT_MSG
Commit Message:
Line 12: KUDU-1770 C++ client does not propate timestamp for write operations
It would be better to prefix the first line of the commit message with "KUDU-1770. " for consistency and readability when running "git log --oneline"
--
To view, visit http://gerrit.cloudera.org:8080/5269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I17feb6b2dacd0ba7c8b57464f1a50de99de2f772
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes