You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/04/13 22:12:35 UTC

[GitHub] [logging-log4cxx] rm5248 commented on pull request #62: GZCompressAction: leave file uncompressed if fork of gzip fails

rm5248 commented on pull request #62:
URL: https://github.com/apache/logging-log4cxx/pull/62#issuecomment-819086870


   If we do this for the `GZCompressAction`, a similar thing should also happen for the `ZipCompressAction`.
   
   @ams-tschoening Any thoughts as to the change?  On one hand, I feel as though if there's an error, throwing an exception is good because it would hopefully be fail-fast at that point(if fork fails, what else can you do?).  On the other hand, unexpected behavior in the logging framework(for example, by throwing an exception) is probably bad as well, since if the logging fails what can you do to debug?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org