You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by va...@apache.org on 2025/07/08 03:16:26 UTC

(superset) 01/01: chore: Improve performance to load chart's save modal

This is an automated email from the ASF dual-hosted git repository.

vavila pushed a commit to branch chore/use-select-columns-on-savemodal
in repository https://gitbox.apache.org/repos/asf/superset.git

commit be680baebc55de11f10ba51e79940f3f4f0f866f
Author: Vitor Avila <vi...@preset.io>
AuthorDate: Tue Jul 8 00:15:45 2025 -0300

    chore: Improve performance to load chart's save modal
---
 superset-frontend/src/explore/actions/saveModalActions.test.ts | 2 +-
 superset-frontend/src/explore/actions/saveModalActions.ts      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/superset-frontend/src/explore/actions/saveModalActions.test.ts b/superset-frontend/src/explore/actions/saveModalActions.test.ts
index b1adb19107..b7081d3486 100644
--- a/superset-frontend/src/explore/actions/saveModalActions.test.ts
+++ b/superset-frontend/src/explore/actions/saveModalActions.test.ts
@@ -420,7 +420,7 @@ const getDashboardSlicesReturnValue = [21, 22, 23];
  * Tests getSliceDashboards action
  */
 
-const getSliceDashboardsEndpoint = `glob:*/api/v1/chart/${sliceId}?q=(columns:!(dashboards.id))`;
+const getSliceDashboardsEndpoint = `glob:*/api/v1/chart/${sliceId}?q=(select_columns:!(dashboards.id))`;
 test('getSliceDashboards with slice handles success', async () => {
   fetchMock.reset();
   fetchMock.get(getSliceDashboardsEndpoint, dashboardSlicesResponsePayload);
diff --git a/superset-frontend/src/explore/actions/saveModalActions.ts b/superset-frontend/src/explore/actions/saveModalActions.ts
index 967c10cf7c..2647f1b847 100644
--- a/superset-frontend/src/explore/actions/saveModalActions.ts
+++ b/superset-frontend/src/explore/actions/saveModalActions.ts
@@ -312,7 +312,7 @@ export const getSliceDashboards =
     try {
       const response = await SupersetClient.get({
         endpoint: `/api/v1/chart/${slice.slice_id}?q=${rison.encode({
-          columns: ['dashboards.id'],
+          select_columns: ['dashboards.id'],
         })}`,
       });