You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/12/02 17:37:29 UTC
[kudu-CR](branch-1.13.x) [test] Use /tmp for mini-chronyd sockets
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16809
Change subject: [test] Use /tmp for mini-chronyd sockets
......................................................................
[test] Use /tmp for mini-chronyd sockets
To ensure the path is less than 100 bytes this patch uses /tmp instead
of the test directory for chronyd sockets.
Change-Id: I567ff640fca5c56fef3f4400216fc8b23532713e
---
M src/kudu/clock/test/mini_chronyd.cc
1 file changed, 3 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/16809/1
--
To view, visit http://gerrit.cloudera.org:8080/16809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.13.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I567ff640fca5c56fef3f4400216fc8b23532713e
Gerrit-Change-Number: 16809
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR](branch-1.13.x) [test] Use /tmp for mini-chronyd sockets
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16809 )
Change subject: [test] Use /tmp for mini-chronyd sockets
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.13.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I567ff640fca5c56fef3f4400216fc8b23532713e
Gerrit-Change-Number: 16809
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Dec 2020 19:57:10 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.13.x) [test] Use /tmp for mini-chronyd sockets
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16809 )
Change subject: [test] Use /tmp for mini-chronyd sockets
......................................................................
[test] Use /tmp for mini-chronyd sockets
To ensure the path is less than 100 bytes this patch uses /tmp instead
of the test directory for chronyd sockets.
Change-Id: I567ff640fca5c56fef3f4400216fc8b23532713e
Reviewed-on: http://gerrit.cloudera.org:8080/16809
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/clock/test/mini_chronyd.cc
1 file changed, 3 insertions(+), 4 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Andrew Wong: Verified
--
To view, visit http://gerrit.cloudera.org:8080/16809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.13.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I567ff640fca5c56fef3f4400216fc8b23532713e
Gerrit-Change-Number: 16809
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.13.x) [test] Use /tmp for mini-chronyd sockets
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16809 )
Change subject: [test] Use /tmp for mini-chronyd sockets
......................................................................
Patch Set 2:
Rebased on the other build-related patches
--
To view, visit http://gerrit.cloudera.org:8080/16809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.13.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I567ff640fca5c56fef3f4400216fc8b23532713e
Gerrit-Change-Number: 16809
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Dec 2020 19:41:19 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.13.x) [test] Use /tmp for mini-chronyd sockets
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has removed a vote on this change.
Change subject: [test] Use /tmp for mini-chronyd sockets
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/16809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.13.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I567ff640fca5c56fef3f4400216fc8b23532713e
Gerrit-Change-Number: 16809
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.13.x) [test] Use /tmp for mini-chronyd sockets
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16809 )
Change subject: [test] Use /tmp for mini-chronyd sockets
......................................................................
Patch Set 2: Verified+1
Test failure seems unrelated.
--
To view, visit http://gerrit.cloudera.org:8080/16809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.13.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I567ff640fca5c56fef3f4400216fc8b23532713e
Gerrit-Change-Number: 16809
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Dec 2020 20:25:47 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.13.x) [test] Use /tmp for mini-chronyd sockets
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16809 )
Change subject: [test] Use /tmp for mini-chronyd sockets
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.13.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I567ff640fca5c56fef3f4400216fc8b23532713e
Gerrit-Change-Number: 16809
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Dec 2020 18:18:56 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.13.x) [test] Use /tmp for mini-chronyd sockets
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16809 )
Change subject: [test] Use /tmp for mini-chronyd sockets
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.13.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I567ff640fca5c56fef3f4400216fc8b23532713e
Gerrit-Change-Number: 16809
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Dec 2020 18:39:50 +0000
Gerrit-HasComments: No