[GitHub] storm pull request: [STORM-826] Update KafkaBolt to use the new ka...

[abhishekagarwal87 <gi...@git.apache.org>]

Github user abhishekagarwal87 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/572#discussion_r45591441
  
    --- Diff: external/storm-kafka/src/jvm/storm/kafka/bolt/KafkaBolt.java ---
    @@ -102,12 +114,40 @@ public void execute(Tuple input) {
                 key = mapper.getKeyFromTuple(input);
                 message = mapper.getMessageFromTuple(input);
                 topic = topicSelector.getTopic(input);
    -            if(topic != null ) {
    -                producer.send(new KeyedMessage<K, V>(topic, key, message));
    +            if (topic != null ) {
    +                Callback callback = null;
    +
    +                if (!fireAndForget && async) {
    +                    callback = new Callback() {
    +                        @Override
    +                        public void onCompletion(RecordMetadata ignored, Exception e) {
    +                            synchronized (collector) {
    +                                if (e != null) {
    +                                    collector.reportError(e);
    +                                    collector.fail(input);
    +                                } else {
    +                                    collector.ack(input);
    +                                }
    +                            }
    +                        }
    +                    };
    +                }
    +                Future<RecordMetadata> result = producer.send(new ProducerRecord<K, V>(topic, key, message), callback);
    +                if (!async) {
    +                    try {
    +                        result.get();
    +                        collector.ack(input);
    --- End diff --
    
    does this call take place in the same executor thread? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---