[GitHub] [kafka] showuon commented on a change in pull request #11794: MINOR: Add links to connector configs in TOC

[GitBox <gi...@apache.org>]

showuon commented on a change in pull request #11794:
URL: https://github.com/apache/kafka/pull/11794#discussion_r810744353



##########
File path: docs/toc.html
##########
@@ -45,6 +45,10 @@
                 <li><a href="#producerconfigs">3.3 Producer Configs</a>
                 <li><a href="#consumerconfigs">3.4 Consumer Configs</a>
                 <li><a href="#connectconfigs">3.5 Kafka Connect Configs</a>
+                    <ul>
+                        <li><a href="#sourceconnectconfigs">Source Connector Configs</a>
+                        <li><a href="#sinkconnectconfigs">Sink Connector Configs</a>
+                    </ul>

Review comment:
       It's good to have these 2 sub categories in TOC. But usually with this TOC, we will think there are only 2 categories under `3.5 Kafka Connect Configs`. However, there is another sub-category `Kafka Connect Configs` there. Do you think we can make the TOC as below:
   - 3.5 Kafka Connect Configs
      - Kafka Connect Configs
      - Source Connector Configs
      - Sink Connector Configs
   
   And maybe change `3.5.1` and `3.5.2` in front of `Source Connector Configs` and `Sink Connector Configs`. WDYT?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org