You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Brandon Li (JIRA)" <ji...@apache.org> on 2012/10/31 22:43:11 UTC

[jira] [Created] (HADOOP-9000) remove Trash.makeTrashRelativePath in branch-1-win

Brandon Li created HADOOP-9000:
----------------------------------

             Summary: remove Trash.makeTrashRelativePath in branch-1-win
                 Key: HADOOP-9000
                 URL: https://issues.apache.org/jira/browse/HADOOP-9000
             Project: Hadoop Common
          Issue Type: Improvement
          Components: trash
    Affects Versions: 1-win
            Reporter: Brandon Li
            Assignee: Brandon Li
            Priority: Minor


This method does nothing except calling Path.mergePaths(). If the method is used to show the purpose of the operation, comment can do as well since it's used only in a couple places.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (HADOOP-9000) remove Trash.makeTrashRelativePath in branch-1-win

Posted by "Brandon Li (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-9000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brandon Li resolved HADOOP-9000.
--------------------------------

    Resolution: Won't Fix
    
> remove Trash.makeTrashRelativePath in branch-1-win
> --------------------------------------------------
>
>                 Key: HADOOP-9000
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9000
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: trash
>    Affects Versions: 1-win
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Minor
>         Attachments: HADOOP-9000.branch-1-win.patch
>
>
> This method does nothing except calling Path.mergePaths(). If the method is used to show the purpose of the operation, comment can do as well since it's used only in a couple places.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-9000) remove Trash.makeTrashRelativePath in branch-1-win

Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-9000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488360#comment-13488360 ] 

Suresh Srinivas commented on HADOOP-9000:
-----------------------------------------

Nice jira number :-)

I am not sure if this change adds much value in the way of cleanup.
                
> remove Trash.makeTrashRelativePath in branch-1-win
> --------------------------------------------------
>
>                 Key: HADOOP-9000
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9000
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: trash
>    Affects Versions: 1-win
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Minor
>         Attachments: HADOOP-9000.branch-1-win.patch
>
>
> This method does nothing except calling Path.mergePaths(). If the method is used to show the purpose of the operation, comment can do as well since it's used only in a couple places.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-9000) remove Trash.makeTrashRelativePath in branch-1-win

Posted by "Brandon Li (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-9000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brandon Li updated HADOOP-9000:
-------------------------------

    Attachment: HADOOP-9000.branch-1-win.patch
    
> remove Trash.makeTrashRelativePath in branch-1-win
> --------------------------------------------------
>
>                 Key: HADOOP-9000
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9000
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: trash
>    Affects Versions: 1-win
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Minor
>         Attachments: HADOOP-9000.branch-1-win.patch
>
>
> This method does nothing except calling Path.mergePaths(). If the method is used to show the purpose of the operation, comment can do as well since it's used only in a couple places.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira