[GitHub] [spark] HeartSaVioR commented on a change in pull request #24186: [SPARK-27254][SS] Cleanup complete but invalid output files in ManifestFileCommitProtocol if job is aborted

[GitBox <gi...@apache.org>]

HeartSaVioR commented on a change in pull request #24186: [SPARK-27254][SS] Cleanup complete but invalid output files in ManifestFileCommitProtocol if job is aborted
URL: https://github.com/apache/spark/pull/24186#discussion_r268901251
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/ManifestFileCommitProtocol.scala
 ##########
 @@ -63,14 +65,32 @@ class ManifestFileCommitProtocol(jobId: String, path: String)
 
     if (fileLog.add(batchId, fileStatuses)) {
 
 Review comment:
   Nice finding! I naively think it as atomic one - write or fail, but it does more things other than just write.
   We can wrap with try-catch and check whether fileLog contains these files, but given this is not a normal case and not removing files don't hurt much (either we don't guarantee), so we can clean the list and call this line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org