You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/12/01 06:14:12 UTC
[GitHub] [incubator-nuttx] LingaoM opened a new pull request #4925: tools: Add size report script
LingaoM opened a new pull request #4925:
URL: https://github.com/apache/incubator-nuttx/pull/4925
Add a resource statistics script, which can be used to
analyze the resource occupation of ELF files, including
BSS, data, ROM, etc.
Signed-off-by: Lingao Meng <me...@xiaomi.com>
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] LingaoM commented on pull request #4925: tools: Add size report script
Posted by GitBox <gi...@apache.org>.
LingaoM commented on pull request #4925:
URL: https://github.com/apache/incubator-nuttx/pull/4925#issuecomment-984203377
> For consistency with other shell script files, the name should probably be changed to size_report.sh
`.sh` mean bash script not for python.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on pull request #4925: tools: Add size report script
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #4925:
URL: https://github.com/apache/incubator-nuttx/pull/4925#issuecomment-983667403
For consistency with other shell script files, the name should probably be changed to size_report.sh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #4925: tools: Add size report script
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #4925:
URL: https://github.com/apache/incubator-nuttx/pull/4925#issuecomment-983560508
It should be nice to save the result of this script at some place to compare size increases in the firmware
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] LingaoM commented on pull request #4925: tools: Add size report script
Posted by GitBox <gi...@apache.org>.
LingaoM commented on pull request #4925:
URL: https://github.com/apache/incubator-nuttx/pull/4925#issuecomment-985165108
> @LingaoM I think you forgot to adapt the names fro Zephyr/zephyr to NuttX/nuttx. Since you are adapting this script to work on NuttX I think it makes sense to change the variables names as well, even if it make things a little more hard later to keep in sync with the original script.
Thanks for reminding, really need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #4925: tools: Add size report script
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #4925:
URL: https://github.com/apache/incubator-nuttx/pull/4925#issuecomment-984895904
@LingaoM I think you forgot to adapt the names fro Zephyr/zephyr to NuttX/nuttx. Since you are adapting this script to work on NuttX I think it makes sense to change the variables names as well, even if it make things a little more hard later to keep in sync with the original script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] hartmannathan commented on pull request #4925: tools: Add size report script
Posted by GitBox <gi...@apache.org>.
hartmannathan commented on pull request #4925:
URL: https://github.com/apache/incubator-nuttx/pull/4925#issuecomment-985618572
So I guess it didn't end up getting renamed to size_report.py. Might be something to consider for a future PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton edited a comment on pull request #4925: tools: Add size report script
Posted by GitBox <gi...@apache.org>.
btashton edited a comment on pull request #4925:
URL: https://github.com/apache/incubator-nuttx/pull/4925#issuecomment-984204845
> > It should be nice to save the result of this script at some place to compare size increases in the firmware
>
> In fact, I usually use` python3 size_report ... > ram_report.log`
If you run this and add a that file to the manifest it will be picked up and added to the generated artifacts for the build in CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on pull request #4925: tools: Add size report script
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #4925:
URL: https://github.com/apache/incubator-nuttx/pull/4925#issuecomment-984208922
> > For consistency with other shell script files, the name should probably be changed to size_report.sh
>
> `.sh` mean bash script not for python.
Oops.. right. Other python scripts end with .py. So same comment, but using the .py extension.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #4925: tools: Add size report script
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #4925:
URL: https://github.com/apache/incubator-nuttx/pull/4925#discussion_r760205542
##########
File path: tools/size_report
##########
@@ -0,0 +1,803 @@
+#!/usr/bin/env python3
+#
+# Copyright (c) 2016, 2020 Intel Corporation
+#
Review comment:
I don't think that we can accept this file into the repository with the Intel copyright. If so, it will need to be declared as a third party file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4925: tools: Add size report script
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #4925:
URL: https://github.com/apache/incubator-nuttx/pull/4925#discussion_r760835697
##########
File path: tools/size_report
##########
@@ -0,0 +1,803 @@
+#!/usr/bin/env python3
+#
+# Copyright (c) 2016, 2020 Intel Corporation
+#
Review comment:
We already have declare Intel copyright in LICENSE file, so it's just simple to list this new script there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] LingaoM commented on pull request #4925: tools: Add size report script
Posted by GitBox <gi...@apache.org>.
LingaoM commented on pull request #4925:
URL: https://github.com/apache/incubator-nuttx/pull/4925#issuecomment-984202973
> It should be nice to save the result of this script at some place to compare size increases in the firmware
In fact, I usually use` python3 size_report ... > ram_report.log`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4925: tools: Add size report script
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #4925:
URL: https://github.com/apache/incubator-nuttx/pull/4925
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #4925: tools: Add size report script
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #4925:
URL: https://github.com/apache/incubator-nuttx/pull/4925#issuecomment-984204845
> > It should be nice to save the result of this script at some place to compare size increases in the firmware
>
> In fact, I usually use` python3 size_report ... > ram_report.log`
If you run this and add a that file to the manifest it will be picked up and added to the generated artifacts for the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] LingaoM commented on pull request #4925: tools: Add size report script
Posted by GitBox <gi...@apache.org>.
LingaoM commented on pull request #4925:
URL: https://github.com/apache/incubator-nuttx/pull/4925#issuecomment-984216673
> > > For consistency with other shell script files, the name should probably be changed to size_report.sh
> >
> >
> > `.sh` mean bash script not for python.
>
> Oops.. right. Other python scripts end with .py. So same comment, but using the .py extension.
Actually, I just want to be consistent with the original(https://github.com/zephyrproject-rtos/zephyr/blob/main/scripts/footprint/size_report), or do we need to rename it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4925: tools: Add size report script
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4925:
URL: https://github.com/apache/incubator-nuttx/pull/4925#issuecomment-985981736
Here is the https://github.com/apache/incubator-nuttx/pull/4936.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org