You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/12/06 19:21:05 UTC

[GitHub] anirudhacharya commented on a change in pull request #13083: [MXNET-345] Hardmax operator

anirudhacharya commented on a change in pull request #13083: [MXNET-345] Hardmax operator
URL: https://github.com/apache/incubator-mxnet/pull/13083#discussion_r239580532
 
 

 ##########
 File path: tests/python/unittest/test_ndarray.py
 ##########
 @@ -1548,6 +1548,15 @@ def test_ndarray_is_nan():
     np.testing.assert_equal(output.asnumpy(), expected_output.astype(int))
     # astype since numpy functions default return type is boolean array instead of int
 
+@with_seed()
+def test_ndarray_hardmax():
+    data = mxnet.test_utils.rand_ndarray([2,3,4],'default')
 
 Review comment:
   can you get a random shape using these util functions - https://github.com/apache/incubator-mxnet/blob/master/python/mxnet/test_utils.py#L402

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services