You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by so...@apache.org on 2017/11/24 09:50:54 UTC

[1/5] wicket git commit: Revert "INFRA-15525 Wicket examples do not update when there is a new Docker image"

Repository: wicket
Updated Branches:
  refs/heads/WICKET-6497-unify-js 0f767eb5e -> ba74ad849


Revert "INFRA-15525 Wicket examples do not update when there is a new Docker image"

This reverts commit d3da4e14518cced036611e880b64fc15b95d1501.


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/5757290a
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/5757290a
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/5757290a

Branch: refs/heads/WICKET-6497-unify-js
Commit: 5757290ad4ba2afddddf33a419513c41c64a1efd
Parents: d3da4e1
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Thu Nov 23 09:38:09 2017 +0200
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Thu Nov 23 09:38:09 2017 +0200

----------------------------------------------------------------------
 wicket-examples/pom.xml | 23 ++---------------------
 1 file changed, 2 insertions(+), 21 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/5757290a/wicket-examples/pom.xml
----------------------------------------------------------------------
diff --git a/wicket-examples/pom.xml b/wicket-examples/pom.xml
index 7b3cf7e..25328bd 100644
--- a/wicket-examples/pom.xml
+++ b/wicket-examples/pom.xml
@@ -293,25 +293,6 @@
 				<finalName>${warName}</finalName>
 				<plugins>
 					<plugin>
-						<groupId>org.codehaus.mojo</groupId>
-						<artifactId>buildnumber-maven-plugin</artifactId>
-						<version>1.4</version>
-						<configuration>
-							<format>{0,date,yyyyMMddHHmmss}</format>
-							<items>
-								<item>timestamp</item>
-							</items>
-						</configuration>
-						<executions>
-							<execution>
-								<phase>validate</phase>
-								<goals>
-									<goal>create</goal>
-								</goals>
-							</execution>
-						</executions>
-					</plugin>
-					<plugin>
 						<groupId>org.apache.maven.plugins</groupId>
 						<artifactId>maven-war-plugin</artifactId>
 						<configuration>
@@ -330,8 +311,8 @@
 						<artifactId>dockerfile-maven-plugin</artifactId>
 						<version>${dockerfile-maven-plugin.version}</version>
 						<configuration>
-							<repository>apache-docker-wicket-docker.bintray.io/wicket-examples-8</repository>
-							<tag>${buildNumber}</tag>
+							<repository>apache-docker-wicket-docker.bintray.io/wicket-examples</repository>
+							<tag>LATEST-8</tag>
 						</configuration>
 						<executions>
 							<execution>


[3/5] wicket git commit: WICKET-6148 Remove AjaxEventBehavior#onCheckEvent() before Wicket 8.0.0

Posted by so...@apache.org.
WICKET-6148 Remove AjaxEventBehavior#onCheckEvent() before Wicket 8.0.0


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/1b366f0c
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/1b366f0c
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/1b366f0c

Branch: refs/heads/WICKET-6497-unify-js
Commit: 1b366f0c7f205971a5d83c6cc853af0efdfac5df
Parents: 9937049
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Fri Nov 24 09:48:31 2017 +0200
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Fri Nov 24 09:48:31 2017 +0200

----------------------------------------------------------------------
 .../apache/wicket/ajax/AjaxEventBehavior.java   | 24 --------------------
 .../wicket/markup/head/OnEventHeaderItem.java   | 10 --------
 .../wicket/util/tester/WicketTesterHelper.java  | 10 --------
 3 files changed, 44 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/1b366f0c/wicket-core/src/main/java/org/apache/wicket/ajax/AjaxEventBehavior.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/ajax/AjaxEventBehavior.java b/wicket-core/src/main/java/org/apache/wicket/ajax/AjaxEventBehavior.java
index a244a3a..23d8a4b 100644
--- a/wicket-core/src/main/java/org/apache/wicket/ajax/AjaxEventBehavior.java
+++ b/wicket-core/src/main/java/org/apache/wicket/ajax/AjaxEventBehavior.java
@@ -18,7 +18,6 @@ package org.apache.wicket.ajax;
 
 import java.util.ArrayList;
 import java.util.List;
-import java.util.Locale;
 
 import org.apache.wicket.Component;
 import org.apache.wicket.ajax.attributes.AjaxRequestAttributes;
@@ -77,8 +76,6 @@ public abstract class AjaxEventBehavior extends AbstractDefaultAjaxBehavior
 	{
 		Args.notEmpty(event, "event");
 
-		onCheckEvent(event);
-
 		this.event = event;
 	}
 
@@ -106,27 +103,6 @@ public abstract class AjaxEventBehavior extends AbstractDefaultAjaxBehavior
 	}
 
 	/**
-	 * 
-	 * @param event
-	 *      the event this behavior will be attached to
-	 * @deprecated Wicket 8 Remove this method for Wicket 8.0.0
-	 */
-	@Deprecated
-	protected void onCheckEvent(final String event)
-	{
-		if (event.startsWith("on"))
-		{
-			String shortName = event.substring(2);
-			throw new IllegalArgumentException(
-					String.format("Since version 6.0.0 Wicket uses JavaScript event registration so there is no need of the leading " +
-									"'on' in the event name '%s'. Please use just '%s'. Wicket 8.x won't manipulate the provided event " +
-									"names so the leading 'on' may break your application."
-							, event, shortName.toLowerCase(Locale.ENGLISH)));
-		}
-
-	}
-
-	/**
 	 * @return event
 	 *      the event this behavior is attached to
 	 */

http://git-wip-us.apache.org/repos/asf/wicket/blob/1b366f0c/wicket-core/src/main/java/org/apache/wicket/markup/head/OnEventHeaderItem.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/markup/head/OnEventHeaderItem.java b/wicket-core/src/main/java/org/apache/wicket/markup/head/OnEventHeaderItem.java
index b69e7a4..62f3667 100644
--- a/wicket-core/src/main/java/org/apache/wicket/markup/head/OnEventHeaderItem.java
+++ b/wicket-core/src/main/java/org/apache/wicket/markup/head/OnEventHeaderItem.java
@@ -83,17 +83,7 @@ public class OnEventHeaderItem extends HeaderItem
 
 		Args.notEmpty(event, "event");
 		event = event.toLowerCase(Locale.ENGLISH);
-		if (event.startsWith("on"))
-		{
-			String shortName = event.substring(2);
-			throw new IllegalArgumentException(
-					String.format("Since version 6.0.0 Wicket uses JavaScript event registration so there is no need of the leading " +
-									"'on' in the event name '%s'. Please use just '%s'. Wicket 8.x won't manipulate the provided event " +
-									"names so the leading 'on' may break your application."
-							, event, shortName));
-		}
 		this.event = event;
-
 		this.javaScript = javaScript;
 	}
 

http://git-wip-us.apache.org/repos/asf/wicket/blob/1b366f0c/wicket-core/src/main/java/org/apache/wicket/util/tester/WicketTesterHelper.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/util/tester/WicketTesterHelper.java b/wicket-core/src/main/java/org/apache/wicket/util/tester/WicketTesterHelper.java
index c9590e3..27e66e4 100644
--- a/wicket-core/src/main/java/org/apache/wicket/util/tester/WicketTesterHelper.java
+++ b/wicket-core/src/main/java/org/apache/wicket/util/tester/WicketTesterHelper.java
@@ -206,16 +206,6 @@ public class WicketTesterHelper
 		String[] eventNames = Strings.split(event, ' ');
 		for (String eventName : eventNames)
 		{
-			if (eventName.startsWith("on"))
-			{
-				String shortName = event.substring(2);
-				throw new IllegalArgumentException(
-						String.format("Since version 6.0.0 Wicket uses JavaScript event registration so there is no need of the leading " +
-										"'on' in the event name '%s'. Please use just '%s'. Wicket 8.x won't manipulate the provided event " +
-										"names so the leading 'on' may break your application."
-								, event, shortName));
-			}
-
 			for (Behavior behavior : component.getBehaviors())
 			{
 				if (behavior instanceof AjaxEventBehavior)


[5/5] wicket git commit: Merge remote-tracking branch 'origin/master' into WICKET-6497-unify-js

Posted by so...@apache.org.
Merge remote-tracking branch 'origin/master' into WICKET-6497-unify-js


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/ba74ad84
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/ba74ad84
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/ba74ad84

Branch: refs/heads/WICKET-6497-unify-js
Commit: ba74ad84911b3a6af65bd8169b9bcd9b757ba6e3
Parents: 0f767eb 0769a60
Author: Maxim Solodovnik <so...@gmail.com>
Authored: Fri Nov 24 16:50:36 2017 +0700
Committer: Maxim Solodovnik <so...@gmail.com>
Committed: Fri Nov 24 16:50:36 2017 +0700

----------------------------------------------------------------------
 .../apache/wicket/ajax/AjaxEventBehavior.java   | 24 --------------------
 .../wicket/markup/head/OnEventHeaderItem.java   | 10 --------
 .../wicket/util/tester/WicketTesterHelper.java  | 10 --------
 wicket-examples/pom.xml                         | 23 ++-----------------
 .../proxy/objenesis/ObjenesisProxyFactory.java  |  1 -
 wicket-user-guide/src/main/asciidoc/single.adoc |  2 +-
 6 files changed, 3 insertions(+), 67 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/ba74ad84/wicket-core/src/main/java/org/apache/wicket/markup/head/OnEventHeaderItem.java
----------------------------------------------------------------------


[2/5] wicket git commit: Revert "Fixed link to examples site"

Posted by so...@apache.org.
Revert "Fixed link to examples site"

This reverts commit b230793bab0cc53f8c128fe7551e3b1a36e27fbf.

The new Docker image now uses ROOT.war


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/99370491
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/99370491
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/99370491

Branch: refs/heads/WICKET-6497-unify-js
Commit: 9937049136d3b1726e1e6d0f53ea7973d6bb2c74
Parents: 5757290
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Thu Nov 23 12:06:00 2017 +0200
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Thu Nov 23 12:06:00 2017 +0200

----------------------------------------------------------------------
 wicket-user-guide/src/main/asciidoc/single.adoc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/99370491/wicket-user-guide/src/main/asciidoc/single.adoc
----------------------------------------------------------------------
diff --git a/wicket-user-guide/src/main/asciidoc/single.adoc b/wicket-user-guide/src/main/asciidoc/single.adoc
index f989ff4..4fc1464 100644
--- a/wicket-user-guide/src/main/asciidoc/single.adoc
+++ b/wicket-user-guide/src/main/asciidoc/single.adoc
@@ -7,7 +7,7 @@ The Apache Software Foundation
 :sectnums:
 
 //custom variables used inside the guide
-:wicket_examples_url: http://examples8x.wicket.apache.org/wicket-examples
+:wicket_examples_url: http://examples8x.wicket.apache.org
 :wicket_tutorial_examples_url: https://wicket-guide.herokuapp.com/
 
 == Introduction


[4/5] wicket git commit: Fix class object memory leak by enabing cache.

Posted by so...@apache.org.
Fix class object memory leak by enabing cache.


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/0769a600
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/0769a600
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/0769a600

Branch: refs/heads/WICKET-6497-unify-js
Commit: 0769a6002a1f45a6eaba3a8429f21c11185f9366
Parents: 1b366f0
Author: Jared Renzullo <jr...@chewy.com>
Authored: Wed Nov 1 16:18:30 2017 -0400
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Fri Nov 24 09:52:59 2017 +0200

----------------------------------------------------------------------
 .../org/apache/wicket/proxy/objenesis/ObjenesisProxyFactory.java    | 1 -
 1 file changed, 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/0769a600/wicket-ioc/src/main/java/org/apache/wicket/proxy/objenesis/ObjenesisProxyFactory.java
----------------------------------------------------------------------
diff --git a/wicket-ioc/src/main/java/org/apache/wicket/proxy/objenesis/ObjenesisProxyFactory.java b/wicket-ioc/src/main/java/org/apache/wicket/proxy/objenesis/ObjenesisProxyFactory.java
index 686acac..041faaf 100644
--- a/wicket-ioc/src/main/java/org/apache/wicket/proxy/objenesis/ObjenesisProxyFactory.java
+++ b/wicket-ioc/src/main/java/org/apache/wicket/proxy/objenesis/ObjenesisProxyFactory.java
@@ -39,7 +39,6 @@ public class ObjenesisProxyFactory
 		e.setSuperclass(type);
 		e.setCallbackType(handler.getClass());
 		e.setNamingPolicy(namingPolicy);
-		e.setUseCache(false);
 
 		Class<?> proxyClass = e.createClass();
 		Enhancer.registerCallbacks(proxyClass, new Callback[]{handler});