You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/07/23 21:11:11 UTC

[GitHub] [nifi] turcsanyip commented on a change in pull request #4422: NIFI-6332 - Add Cache Control property to PutS3Object processor

turcsanyip commented on a change in pull request #4422:
URL: https://github.com/apache/nifi/pull/4422#discussion_r459726996



##########
File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java
##########
@@ -152,6 +153,14 @@
         .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
         .build();
 
+    public static final PropertyDescriptor CACHE_CONTROL = new PropertyDescriptor.Builder()
+            .name("Cache Control")
+            .displayName("Cache Control")
+            .description("Sets the Cache-Control HTTP header. Multiple directives are comma-separated.")

Review comment:
       Could you please add a similar explanation as in case of Content Type:
   "Sets the Cache-Control HTTP header _indicating the caching directives of the associated object_." (or similar)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org