You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/19 06:14:10 UTC
[GitHub] [airflow] mik-laj opened a new pull request #17076: Revert "Prevent running `airflow db init\upgrade` migrations and setup in parallel. (#16311)
mik-laj opened a new pull request #17076:
URL: https://github.com/apache/airflow/pull/17076
Close: https://github.com/apache/airflow/issues/17072
Since #16311 was merged, the MSSQL check has been pretty consistenyl failing, which makes many contributions difficult. Until we find a better solution, I propose to revert this change.
This reverts commit fbfb08a15bf7b2e8e11cc51567b1fb0d2492c2fa.
CC: @anitakar @uranusjr
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17076: Revert "Prevent running `airflow db init\upgrade` migrations and setup in parallel. (#16311)"
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17076:
URL: https://github.com/apache/airflow/pull/17076#issuecomment-882435906
Yep. We can close that one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17076: Revert "Prevent running `airflow db init\upgrade` migrations and setup in parallel. (#16311)"
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17076:
URL: https://github.com/apache/airflow/pull/17076#issuecomment-882435906
Yep. We can close that one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #17076: Revert "Prevent running `airflow db init\upgrade` migrations and setup in parallel. (#16311)"
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #17076:
URL: https://github.com/apache/airflow/pull/17076#issuecomment-882407971
I don't have much time to deal with it. @anitakar @uranusjr @potiuk Can you help with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17076: Revert "Prevent running `airflow db init\upgrade` migrations and setup in parallel. (#16311)"
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17076:
URL: https://github.com/apache/airflow/pull/17076#issuecomment-882343298
> Would it be possible to only revert the MSSQL part? The Postgres and MySQL locking mechanism looks good to me, but I don’t know about MSSQL (and it is what’s causing the problem). We don’t support locking on all databases anyway (e.g. the locking manager is no-op on SQLite for obvious reasons), so we don’t really need to implement this for all databases at one shot.
>
> But if the partial-reverting is not easy to do, I think reverting all of this is still better than the current `main` state, so I’m approving this.
Should be easy to revert only mysql and I agree it would be much better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #17076: Revert "Prevent running `airflow db init\upgrade` migrations and setup in parallel. (#16311)"
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #17076:
URL: https://github.com/apache/airflow/pull/17076#issuecomment-882407971
I don't have much time to deal with it. @anitakar @uranusjr @potiuk Can you help with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #17076: Revert "Prevent running `airflow db init\upgrade` migrations and setup in parallel. (#16311)"
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #17076:
URL: https://github.com/apache/airflow/pull/17076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #17076: Revert "Prevent running `airflow db init\upgrade` migrations and setup in parallel. (#16311)"
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #17076:
URL: https://github.com/apache/airflow/pull/17076#issuecomment-882434387
I think #17078 supercedes this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17076: Revert "Prevent running `airflow db init\upgrade` migrations and setup in parallel. (#16311)"
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17076:
URL: https://github.com/apache/airflow/pull/17076#issuecomment-882329362
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #17076: Revert "Prevent running `airflow db init\upgrade` migrations and setup in parallel. (#16311)"
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #17076:
URL: https://github.com/apache/airflow/pull/17076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #17076: Revert "Prevent running `airflow db init\upgrade` migrations and setup in parallel. (#16311)"
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #17076:
URL: https://github.com/apache/airflow/pull/17076#issuecomment-882434387
I think #17078 supercedes this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org