You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/22 06:22:27 UTC

[GitHub] [dubbo] EarthChen opened a new pull request #8871: [3.0-Triple] Add handler for reset frame

EarthChen opened a new pull request #8871:
URL: https://github.com/apache/dubbo/pull/8871


   ## What is the purpose of the change
   
   - add client and server reset frame handler
   
   ## Brief changelog
   
   
   ## Verifying this change
   
   
   <!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
   
   ## Checklist
   - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
   - [ ] Each commit in the pull request should have a meaningful subject line and body.
   - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
   - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
   - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
   - [ ] GitHub Actions works fine on your own branch.
   - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8871: [3.0-Triple] Add handler for reset frame

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #8871:
URL: https://github.com/apache/dubbo/pull/8871#issuecomment-924659070


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8871](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fb96c0d) into [3.0](https://codecov.io/gh/apache/dubbo/commit/d3f7ab400f7b248ac6ac9a16ce75b02e0463d280?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d3f7ab4) will **decrease** coverage by `0.05%`.
   > The diff coverage is `24.67%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8871/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8871      +/-   ##
   ============================================
   - Coverage     63.77%   63.72%   -0.06%     
   + Complexity      315      314       -1     
   ============================================
     Files          1169     1171       +2     
     Lines         49216    49386     +170     
     Branches       7361     7378      +17     
   ============================================
   + Hits          31389    31472      +83     
   - Misses        14406    14486      +80     
   - Partials       3421     3428       +7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../java/org/apache/dubbo/rpc/ExecutableListener.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9FeGVjdXRhYmxlTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `63.29% <0.00%> (-1.65%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/TransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `35.55% <0.00%> (-5.48%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `25.00% <0.00%> (-4.63%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `45.94% <ø> (ø)` | |
   | [.../java/org/apache/dubbo/rpc/CancellableContext.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9DYW5jZWxsYWJsZUNvbnRleHQuamF2YQ==) | `4.65% <4.65%> (ø)` | |
   | [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.40% <14.28%> (-4.13%)` | :arrow_down: |
   | [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `44.17% <20.00%> (-1.94%)` | :arrow_down: |
   | [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `50.46% <27.27%> (-3.62%)` | :arrow_down: |
   | ... and [55 more](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d3f7ab4...fb96c0d](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8871: [3.0-Triple] Add handler for reset frame

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #8871:
URL: https://github.com/apache/dubbo/pull/8871#issuecomment-924659070


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8871](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2394174) into [3.0](https://codecov.io/gh/apache/dubbo/commit/0643a7ce7e8af1e469ff76a0d5624a28c5a17da4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0643a7c) will **decrease** coverage by `0.27%`.
   > The diff coverage is `22.86%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8871/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8871      +/-   ##
   ============================================
   - Coverage     63.42%   63.14%   -0.28%     
   + Complexity      315      312       -3     
   ============================================
     Files          1180     1181       +1     
     Lines         50031    50175     +144     
     Branches       7494     7507      +13     
   ============================================
   - Hits          31730    31685      -45     
   - Misses        14836    15010     +174     
   - Partials       3465     3480      +15     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../java/org/apache/dubbo/rpc/ExecutableListener.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9FeGVjdXRhYmxlTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...src/main/java/org/apache/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNDb250ZXh0LmphdmE=) | `33.11% <ø> (ø)` | |
   | [...n/java/org/apache/dubbo/rpc/RpcServiceContext.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNTZXJ2aWNlQ29udGV4dC5qYXZh) | `50.53% <0.00%> (-14.10%)` | :arrow_down: |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `63.29% <0.00%> (-1.65%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/TransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `35.55% <0.00%> (-5.48%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `25.00% <0.00%> (-4.63%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `45.94% <ø> (ø)` | |
   | [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.40% <14.28%> (-4.13%)` | :arrow_down: |
   | [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `44.17% <20.00%> (-1.94%)` | :arrow_down: |
   | ... and [27 more](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0643a7c...2394174](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8871: [3.0-Triple] Add handler for reset frame

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #8871:
URL: https://github.com/apache/dubbo/pull/8871#issuecomment-924659070


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8871](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (097a8bd) into [3.0](https://codecov.io/gh/apache/dubbo/commit/0643a7ce7e8af1e469ff76a0d5624a28c5a17da4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0643a7c) will **decrease** coverage by `0.22%`.
   > The diff coverage is `35.68%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8871/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8871      +/-   ##
   ============================================
   - Coverage     63.42%   63.20%   -0.23%     
   + Complexity      315      313       -2     
   ============================================
     Files          1180     1182       +2     
     Lines         50031    50223     +192     
     Branches       7494     7513      +19     
   ============================================
   + Hits          31730    31741      +11     
   - Misses        14836    15003     +167     
   - Partials       3465     3479      +14     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/dubbo/rpc/RpcServiceContext.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNTZXJ2aWNlQ29udGV4dC5qYXZh) | `64.62% <ø> (ø)` | |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `63.29% <0.00%> (-1.65%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `48.14% <0.00%> (ø)` | |
   | [...ache/dubbo/rpc/protocol/tri/TransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `35.55% <0.00%> (-5.48%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `25.00% <0.00%> (-4.63%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `45.94% <ø> (ø)` | |
   | [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.98% <15.00%> (-3.55%)` | :arrow_down: |
   | [...java/org/apache/dubbo/rpc/CancellationContext.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9DYW5jZWxsYXRpb25Db250ZXh0LmphdmE=) | `30.43% <30.43%> (ø)` | |
   | [.../java/org/apache/dubbo/rpc/ExecutableListener.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9FeGVjdXRhYmxlTGlzdGVuZXIuamF2YQ==) | `33.33% <33.33%> (ø)` | |
   | ... and [44 more](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0643a7c...097a8bd](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8871: [3.0-Triple] Add handler for reset frame

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #8871:
URL: https://github.com/apache/dubbo/pull/8871#issuecomment-924659070


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8871](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (097a8bd) into [3.0](https://codecov.io/gh/apache/dubbo/commit/0643a7ce7e8af1e469ff76a0d5624a28c5a17da4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0643a7c) will **decrease** coverage by `0.29%`.
   > The diff coverage is `35.68%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8871/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8871      +/-   ##
   ============================================
   - Coverage     63.42%   63.12%   -0.30%     
   + Complexity      315      311       -4     
   ============================================
     Files          1180     1182       +2     
     Lines         50031    50223     +192     
     Branches       7494     7491       -3     
   ============================================
   - Hits          31730    31702      -28     
   - Misses        14836    15036     +200     
   - Partials       3465     3485      +20     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/dubbo/rpc/RpcServiceContext.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNTZXJ2aWNlQ29udGV4dC5qYXZh) | `64.62% <ø> (ø)` | |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `63.29% <0.00%> (-1.65%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `48.14% <0.00%> (ø)` | |
   | [...ache/dubbo/rpc/protocol/tri/TransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `35.55% <0.00%> (-5.48%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `25.00% <0.00%> (-4.63%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `45.94% <ø> (ø)` | |
   | [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.98% <15.00%> (-3.55%)` | :arrow_down: |
   | [...java/org/apache/dubbo/rpc/CancellationContext.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9DYW5jZWxsYXRpb25Db250ZXh0LmphdmE=) | `30.43% <30.43%> (ø)` | |
   | [.../java/org/apache/dubbo/rpc/ExecutableListener.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9FeGVjdXRhYmxlTGlzdGVuZXIuamF2YQ==) | `33.33% <33.33%> (ø)` | |
   | ... and [58 more](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0643a7c...097a8bd](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8871: [3.0-Triple] Add handler for reset frame

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #8871:
URL: https://github.com/apache/dubbo/pull/8871#issuecomment-924659070


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8871](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e697683) into [3.0](https://codecov.io/gh/apache/dubbo/commit/0643a7ce7e8af1e469ff76a0d5624a28c5a17da4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0643a7c) will **decrease** coverage by `0.14%`.
   > The diff coverage is `34.89%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8871/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8871      +/-   ##
   ============================================
   - Coverage     63.42%   63.27%   -0.15%     
   + Complexity      315      312       -3     
   ============================================
     Files          1180     1182       +2     
     Lines         50031    50217     +186     
     Branches       7494     7511      +17     
   ============================================
   + Hits          31730    31776      +46     
   - Misses        14836    14967     +131     
   - Partials       3465     3474       +9     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/dubbo/rpc/RpcServiceContext.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNTZXJ2aWNlQ29udGV4dC5qYXZh) | `64.62% <ø> (ø)` | |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `63.29% <0.00%> (-1.65%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `48.14% <0.00%> (ø)` | |
   | [...ache/dubbo/rpc/protocol/tri/TransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `35.55% <0.00%> (-5.48%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `25.00% <0.00%> (-4.63%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `45.94% <ø> (ø)` | |
   | [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.98% <15.00%> (-3.55%)` | :arrow_down: |
   | [...java/org/apache/dubbo/rpc/CancellationContext.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9DYW5jZWxsYXRpb25Db250ZXh0LmphdmE=) | `25.00% <25.00%> (ø)` | |
   | [.../java/org/apache/dubbo/rpc/ExecutableListener.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9FeGVjdXRhYmxlTGlzdGVuZXIuamF2YQ==) | `33.33% <33.33%> (ø)` | |
   | ... and [38 more](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0643a7c...e697683](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8871: [3.0-Triple] Add handler for reset frame

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #8871:
URL: https://github.com/apache/dubbo/pull/8871#issuecomment-924659070


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8871](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (097a8bd) into [3.0](https://codecov.io/gh/apache/dubbo/commit/0643a7ce7e8af1e469ff76a0d5624a28c5a17da4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0643a7c) will **decrease** coverage by `0.11%`.
   > The diff coverage is `35.68%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8871/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8871      +/-   ##
   ============================================
   - Coverage     63.42%   63.30%   -0.12%     
   + Complexity      315      313       -2     
   ============================================
     Files          1180     1182       +2     
     Lines         50031    50223     +192     
     Branches       7494     7513      +19     
   ============================================
   + Hits          31730    31793      +63     
   - Misses        14836    14955     +119     
   - Partials       3465     3475      +10     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/dubbo/rpc/RpcServiceContext.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNTZXJ2aWNlQ29udGV4dC5qYXZh) | `64.62% <ø> (ø)` | |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `63.29% <0.00%> (-1.65%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `48.14% <0.00%> (ø)` | |
   | [...ache/dubbo/rpc/protocol/tri/TransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `35.55% <0.00%> (-5.48%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `25.00% <0.00%> (-4.63%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `45.94% <ø> (ø)` | |
   | [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.98% <15.00%> (-3.55%)` | :arrow_down: |
   | [...java/org/apache/dubbo/rpc/CancellationContext.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9DYW5jZWxsYXRpb25Db250ZXh0LmphdmE=) | `30.43% <30.43%> (ø)` | |
   | [.../java/org/apache/dubbo/rpc/ExecutableListener.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9FeGVjdXRhYmxlTGlzdGVuZXIuamF2YQ==) | `33.33% <33.33%> (ø)` | |
   | ... and [33 more](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0643a7c...097a8bd](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter commented on pull request #8871: [3.0-Triple] Add handler for reset frame

Posted by GitBox <gi...@apache.org>.

codecov-commenter commented on pull request #8871:
URL: https://github.com/apache/dubbo/pull/8871#issuecomment-924659070


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8871](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fb96c0d) into [3.0](https://codecov.io/gh/apache/dubbo/commit/d3f7ab400f7b248ac6ac9a16ce75b02e0463d280?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d3f7ab4) will **decrease** coverage by `0.24%`.
   > The diff coverage is `24.67%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8871/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8871      +/-   ##
   ============================================
   - Coverage     63.77%   63.52%   -0.25%     
   + Complexity      315      313       -2     
   ============================================
     Files          1169     1171       +2     
     Lines         49216    49350     +134     
     Branches       7361     7351      -10     
   ============================================
   - Hits          31389    31352      -37     
   - Misses        14406    14559     +153     
   - Partials       3421     3439      +18     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../java/org/apache/dubbo/rpc/ExecutableListener.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9FeGVjdXRhYmxlTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `63.29% <0.00%> (-1.65%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/TransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `35.55% <0.00%> (-5.48%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `25.00% <0.00%> (-4.63%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `45.94% <ø> (ø)` | |
   | [.../java/org/apache/dubbo/rpc/CancellableContext.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9DYW5jZWxsYWJsZUNvbnRleHQuamF2YQ==) | `4.65% <4.65%> (ø)` | |
   | [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.40% <14.28%> (-4.13%)` | :arrow_down: |
   | [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `44.17% <20.00%> (-1.94%)` | :arrow_down: |
   | [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `50.46% <27.27%> (-3.62%)` | :arrow_down: |
   | ... and [90 more](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d3f7ab4...fb96c0d](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8871: [3.0-Triple] Add handler for reset frame

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #8871:
URL: https://github.com/apache/dubbo/pull/8871#issuecomment-924659070


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8871](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e697683) into [3.0](https://codecov.io/gh/apache/dubbo/commit/0643a7ce7e8af1e469ff76a0d5624a28c5a17da4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0643a7c) will **decrease** coverage by `0.27%`.
   > The diff coverage is `34.89%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8871/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8871      +/-   ##
   ============================================
   - Coverage     63.42%   63.14%   -0.28%     
   + Complexity      315      312       -3     
   ============================================
     Files          1180     1182       +2     
     Lines         50031    50217     +186     
     Branches       7494     7511      +17     
   ============================================
   - Hits          31730    31712      -18     
   - Misses        14836    15028     +192     
   - Partials       3465     3477      +12     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/dubbo/rpc/RpcServiceContext.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNTZXJ2aWNlQ29udGV4dC5qYXZh) | `64.62% <ø> (ø)` | |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `63.29% <0.00%> (-1.65%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `48.14% <0.00%> (ø)` | |
   | [...ache/dubbo/rpc/protocol/tri/TransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `35.55% <0.00%> (-5.48%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `25.00% <0.00%> (-4.63%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `45.94% <ø> (ø)` | |
   | [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.98% <15.00%> (-3.55%)` | :arrow_down: |
   | [...java/org/apache/dubbo/rpc/CancellationContext.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9DYW5jZWxsYXRpb25Db250ZXh0LmphdmE=) | `25.00% <25.00%> (ø)` | |
   | [.../java/org/apache/dubbo/rpc/ExecutableListener.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9FeGVjdXRhYmxlTGlzdGVuZXIuamF2YQ==) | `33.33% <33.33%> (ø)` | |
   | ... and [51 more](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0643a7c...e697683](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8871: [3.0-Triple] Add handler for reset frame

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #8871:
URL: https://github.com/apache/dubbo/pull/8871#issuecomment-924659070


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8871](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e697683) into [3.0](https://codecov.io/gh/apache/dubbo/commit/0643a7ce7e8af1e469ff76a0d5624a28c5a17da4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0643a7c) will **decrease** coverage by `0.29%`.
   > The diff coverage is `34.89%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8871/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8871      +/-   ##
   ============================================
   - Coverage     63.42%   63.12%   -0.30%     
   + Complexity      315      312       -3     
   ============================================
     Files          1180     1182       +2     
     Lines         50031    50181     +150     
     Branches       7494     7484      -10     
   ============================================
   - Hits          31730    31677      -53     
   - Misses        14836    15021     +185     
   - Partials       3465     3483      +18     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/dubbo/rpc/RpcServiceContext.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNTZXJ2aWNlQ29udGV4dC5qYXZh) | `64.62% <ø> (ø)` | |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `63.29% <0.00%> (-1.65%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `48.14% <0.00%> (ø)` | |
   | [...ache/dubbo/rpc/protocol/tri/TransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `35.55% <0.00%> (-5.48%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `25.00% <0.00%> (-4.63%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `45.94% <ø> (ø)` | |
   | [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.98% <15.00%> (-3.55%)` | :arrow_down: |
   | [...java/org/apache/dubbo/rpc/CancellationContext.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9DYW5jZWxsYXRpb25Db250ZXh0LmphdmE=) | `25.00% <25.00%> (ø)` | |
   | [.../java/org/apache/dubbo/rpc/ExecutableListener.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9FeGVjdXRhYmxlTGlzdGVuZXIuamF2YQ==) | `33.33% <33.33%> (ø)` | |
   | ... and [73 more](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0643a7c...e697683](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] guohao merged pull request #8871: [3.0-Triple] Add handler for reset frame

Posted by GitBox <gi...@apache.org>.

guohao merged pull request #8871:
URL: https://github.com/apache/dubbo/pull/8871


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8871: [3.0-Triple] Add handler for reset frame

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #8871:
URL: https://github.com/apache/dubbo/pull/8871#issuecomment-924659070


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8871](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e697683) into [3.0](https://codecov.io/gh/apache/dubbo/commit/0643a7ce7e8af1e469ff76a0d5624a28c5a17da4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0643a7c) will **decrease** coverage by `0.17%`.
   > The diff coverage is `34.89%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8871/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8871      +/-   ##
   ============================================
   - Coverage     63.42%   63.24%   -0.18%     
   + Complexity      315      312       -3     
   ============================================
     Files          1180     1182       +2     
     Lines         50031    50217     +186     
     Branches       7494     7511      +17     
   ============================================
   + Hits          31730    31760      +30     
   - Misses        14836    14981     +145     
   - Partials       3465     3476      +11     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/dubbo/rpc/RpcServiceContext.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNTZXJ2aWNlQ29udGV4dC5qYXZh) | `64.62% <ø> (ø)` | |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `63.29% <0.00%> (-1.65%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `48.14% <0.00%> (ø)` | |
   | [...ache/dubbo/rpc/protocol/tri/TransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `35.55% <0.00%> (-5.48%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `25.00% <0.00%> (-4.63%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `45.94% <ø> (ø)` | |
   | [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.98% <15.00%> (-3.55%)` | :arrow_down: |
   | [...java/org/apache/dubbo/rpc/CancellationContext.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9DYW5jZWxsYXRpb25Db250ZXh0LmphdmE=) | `25.00% <25.00%> (ø)` | |
   | [.../java/org/apache/dubbo/rpc/ExecutableListener.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9FeGVjdXRhYmxlTGlzdGVuZXIuamF2YQ==) | `33.33% <33.33%> (ø)` | |
   | ... and [38 more](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0643a7c...e697683](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8871: [3.0-Triple] Add handler for reset frame

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #8871:
URL: https://github.com/apache/dubbo/pull/8871#issuecomment-924659070


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8871](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (424b84a) into [3.0](https://codecov.io/gh/apache/dubbo/commit/0643a7ce7e8af1e469ff76a0d5624a28c5a17da4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0643a7c) will **decrease** coverage by `0.10%`.
   > The diff coverage is `36.44%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8871/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8871      +/-   ##
   ============================================
   - Coverage     63.42%   63.31%   -0.11%     
     Complexity      315      315              
   ============================================
     Files          1180     1182       +2     
     Lines         50031    50207     +176     
     Branches       7494     7511      +17     
   ============================================
   + Hits          31730    31791      +61     
   - Misses        14836    14948     +112     
   - Partials       3465     3468       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/dubbo/rpc/RpcServiceContext.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNTZXJ2aWNlQ29udGV4dC5qYXZh) | `64.62% <ø> (ø)` | |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `63.29% <0.00%> (-1.65%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `48.14% <0.00%> (ø)` | |
   | [...ache/dubbo/rpc/protocol/tri/TransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `35.55% <0.00%> (-5.48%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `29.62% <0.00%> (ø)` | |
   | [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `45.94% <ø> (ø)` | |
   | [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.98% <15.00%> (-3.55%)` | :arrow_down: |
   | [...java/org/apache/dubbo/rpc/CancellationContext.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9DYW5jZWxsYXRpb25Db250ZXh0LmphdmE=) | `25.00% <25.00%> (ø)` | |
   | [.../java/org/apache/dubbo/rpc/ExecutableListener.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9FeGVjdXRhYmxlTGlzdGVuZXIuamF2YQ==) | `33.33% <33.33%> (ø)` | |
   | ... and [35 more](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0643a7c...424b84a](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8871: [3.0-Triple] Add handler for reset frame

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #8871:
URL: https://github.com/apache/dubbo/pull/8871#issuecomment-924659070


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8871](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (424b84a) into [3.0](https://codecov.io/gh/apache/dubbo/commit/0643a7ce7e8af1e469ff76a0d5624a28c5a17da4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0643a7c) will **decrease** coverage by `0.07%`.
   > The diff coverage is `36.44%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8871/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8871      +/-   ##
   ============================================
   - Coverage     63.42%   63.34%   -0.08%     
     Complexity      315      315              
   ============================================
     Files          1180     1182       +2     
     Lines         50031    50207     +176     
     Branches       7494     7511      +17     
   ============================================
   + Hits          31730    31805      +75     
   - Misses        14836    14937     +101     
     Partials       3465     3465              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/dubbo/rpc/RpcServiceContext.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNTZXJ2aWNlQ29udGV4dC5qYXZh) | `64.62% <ø> (ø)` | |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `63.29% <0.00%> (-1.65%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `48.14% <0.00%> (ø)` | |
   | [...ache/dubbo/rpc/protocol/tri/TransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `35.55% <0.00%> (-5.48%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `29.62% <0.00%> (ø)` | |
   | [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `45.94% <ø> (ø)` | |
   | [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.98% <15.00%> (-3.55%)` | :arrow_down: |
   | [...java/org/apache/dubbo/rpc/CancellationContext.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9DYW5jZWxsYXRpb25Db250ZXh0LmphdmE=) | `25.00% <25.00%> (ø)` | |
   | [.../java/org/apache/dubbo/rpc/ExecutableListener.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9FeGVjdXRhYmxlTGlzdGVuZXIuamF2YQ==) | `33.33% <33.33%> (ø)` | |
   | ... and [31 more](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0643a7c...424b84a](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] EarthChen commented on a change in pull request #8871: [3.0-Triple] Add handler for reset frame

Posted by GitBox <gi...@apache.org>.

EarthChen commented on a change in pull request #8871:
URL: https://github.com/apache/dubbo/pull/8871#discussion_r716156412



##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/ServerTransportObserver.java
##########
@@ -48,19 +59,38 @@ public void onMetadata(Metadata metadata, boolean endStream) {
             headers.set(TripleHeaderEnum.CONTENT_TYPE_KEY.getHeader(), TripleConstant.CONTENT_PROTO);
         }
         ctx.writeAndFlush(new DefaultHttp2HeadersFrame(headers, endStream))
-            .addListener(future -> {
-                if (!future.isSuccess()) {
-                    promise.tryFailure(future.cause());
-                }
-            });
+                .addListener(future -> {

Review comment:
       This PR has an explanation.
   https://github.com/apache/dubbo/pull/8922




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] guohao commented on a change in pull request #8871: [3.0-Triple] Add handler for reset frame

Posted by GitBox <gi...@apache.org>.

guohao commented on a change in pull request #8871:
URL: https://github.com/apache/dubbo/pull/8871#discussion_r716153024



##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/ServerTransportObserver.java
##########
@@ -48,19 +59,38 @@ public void onMetadata(Metadata metadata, boolean endStream) {
             headers.set(TripleHeaderEnum.CONTENT_TYPE_KEY.getHeader(), TripleConstant.CONTENT_PROTO);
         }
         ctx.writeAndFlush(new DefaultHttp2HeadersFrame(headers, endStream))
-            .addListener(future -> {
-                if (!future.isSuccess()) {
-                    promise.tryFailure(future.cause());
-                }
-            });
+                .addListener(future -> {

Review comment:
       why discard `promise` here ?

##########
File path: dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/CancellationContext.java
##########
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.rpc;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.Executor;
+
+public class CancellationContext implements Closeable {
+
+    private ArrayList<ExecutableListener> listeners;
+    private Throwable cancellationCause;
+    private boolean cancelled;
+
+    public void addListener(
+            final CancellationListener cancellationListener, final Executor executor) {
+        addListener(cancellationListener, executor, null);
+    }
+
+    public void addListener(
+            final CancellationListener cancellationListener) {
+        addListener(cancellationListener, Runnable::run, null);
+    }
+
+    public void addListener(
+            final CancellationListener cancellationListener,
+            final RpcServiceContext context) {
+        addListener(cancellationListener, Runnable::run, context);
+    }
+
+    public void addListener(
+            final CancellationListener cancellationListener,
+            final Executor executor,
+            final RpcServiceContext context) {
+        addListenerInternal(new ExecutableListener(executor, cancellationListener, context));
+    }
+
+    public void addListenerInternal(ExecutableListener executableListener) {
+        synchronized (this) {
+            if (isCancelled()) {
+                executableListener.deliver();
+            } else {
+                if (listeners == null) {
+                    listeners = new ArrayList<>();
+                }
+                listeners.add(executableListener);
+            }
+        }
+    }
+
+    public boolean cancel(Throwable cause) {
+        boolean triggeredCancel = false;
+        synchronized (this) {
+            if (!cancelled) {
+                cancelled = true;
+                this.cancellationCause = cause;
+                triggeredCancel = true;
+            }
+        }
+        if (triggeredCancel) {
+            notifyAndClearListeners();
+        }
+        return triggeredCancel;
+    }
+
+    private void notifyAndClearListeners() {
+        ArrayList<ExecutableListener> tmpListeners;
+        synchronized (this) {
+            if (listeners == null) {
+                return;
+            }
+            tmpListeners = listeners;

Review comment:
       This reference may cause `ConcurrentModification`

##########
File path: dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/CancellationContext.java
##########
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.rpc;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.Executor;
+
+public class CancellationContext implements Closeable {
+
+    private ArrayList<ExecutableListener> listeners;
+    private Throwable cancellationCause;
+    private boolean cancelled;
+
+    public void addListener(
+            final CancellationListener cancellationListener, final Executor executor) {
+        addListener(cancellationListener, executor, null);
+    }
+
+    public void addListener(
+            final CancellationListener cancellationListener) {
+        addListener(cancellationListener, Runnable::run, null);
+    }
+
+    public void addListener(
+            final CancellationListener cancellationListener,
+            final RpcServiceContext context) {
+        addListener(cancellationListener, Runnable::run, context);
+    }
+
+    public void addListener(
+            final CancellationListener cancellationListener,
+            final Executor executor,
+            final RpcServiceContext context) {
+        addListenerInternal(new ExecutableListener(executor, cancellationListener, context));
+    }
+
+    public void addListenerInternal(ExecutableListener executableListener) {
+        synchronized (this) {
+            if (isCancelled()) {
+                executableListener.deliver();
+            } else {
+                if (listeners == null) {
+                    listeners = new ArrayList<>();
+                }
+                listeners.add(executableListener);
+            }
+        }
+    }
+
+    public boolean cancel(Throwable cause) {
+        boolean triggeredCancel = false;
+        synchronized (this) {
+            if (!cancelled) {
+                cancelled = true;
+                this.cancellationCause = cause;
+                triggeredCancel = true;
+            }
+        }
+        if (triggeredCancel) {
+            notifyAndClearListeners();
+        }
+        return triggeredCancel;
+    }
+
+    private void notifyAndClearListeners() {
+        ArrayList<ExecutableListener> tmpListeners;
+        synchronized (this) {
+            if (listeners == null) {
+                return;
+            }
+            tmpListeners = listeners;
+            listeners = null;
+        }
+        for (ExecutableListener tmpListener : tmpListeners) {
+            tmpListener.deliver();
+        }
+    }
+
+    public boolean isCancelled() {

Review comment:
       ```suggestion
       public synchronized boolean isCancelled() {
          return cancelled;
       }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8871: [3.0-Triple] Add handler for reset frame

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #8871:
URL: https://github.com/apache/dubbo/pull/8871#issuecomment-924659070


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8871](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (097a8bd) into [3.0](https://codecov.io/gh/apache/dubbo/commit/0643a7ce7e8af1e469ff76a0d5624a28c5a17da4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0643a7c) will **decrease** coverage by `0.08%`.
   > The diff coverage is `35.68%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8871/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8871      +/-   ##
   ============================================
   - Coverage     63.42%   63.33%   -0.09%     
     Complexity      315      315              
   ============================================
     Files          1180     1182       +2     
     Lines         50031    50223     +192     
     Branches       7494     7513      +19     
   ============================================
   + Hits          31730    31810      +80     
   - Misses        14836    14942     +106     
   - Partials       3465     3471       +6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/dubbo/rpc/RpcServiceContext.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNTZXJ2aWNlQ29udGV4dC5qYXZh) | `64.62% <ø> (ø)` | |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `63.29% <0.00%> (-1.65%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `48.14% <0.00%> (ø)` | |
   | [...ache/dubbo/rpc/protocol/tri/TransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `35.55% <0.00%> (-5.48%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `25.00% <0.00%> (-4.63%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `45.94% <ø> (ø)` | |
   | [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.98% <15.00%> (-3.55%)` | :arrow_down: |
   | [...java/org/apache/dubbo/rpc/CancellationContext.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9DYW5jZWxsYXRpb25Db250ZXh0LmphdmE=) | `30.43% <30.43%> (ø)` | |
   | [.../java/org/apache/dubbo/rpc/ExecutableListener.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9FeGVjdXRhYmxlTGlzdGVuZXIuamF2YQ==) | `33.33% <33.33%> (ø)` | |
   | ... and [30 more](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0643a7c...097a8bd](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] guohao commented on pull request #8871: [3.0-Triple] Add handler for reset frame

Posted by GitBox <gi...@apache.org>.

guohao commented on pull request #8871:
URL: https://github.com/apache/dubbo/pull/8871#issuecomment-926425613


   Move CancelContext into ServiceContext will be better?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8871: [3.0-Triple] Add handler for reset frame

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #8871:
URL: https://github.com/apache/dubbo/pull/8871#issuecomment-924659070


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8871](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (424b84a) into [3.0](https://codecov.io/gh/apache/dubbo/commit/0643a7ce7e8af1e469ff76a0d5624a28c5a17da4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0643a7c) will **decrease** coverage by `0.22%`.
   > The diff coverage is `36.44%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8871/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8871      +/-   ##
   ============================================
   - Coverage     63.42%   63.19%   -0.23%     
   + Complexity      315      314       -1     
   ============================================
     Files          1180     1182       +2     
     Lines         50031    50171     +140     
     Branches       7494     7484      -10     
   ============================================
   - Hits          31730    31705      -25     
   - Misses        14836    14987     +151     
   - Partials       3465     3479      +14     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/dubbo/rpc/RpcServiceContext.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNTZXJ2aWNlQ29udGV4dC5qYXZh) | `64.62% <ø> (ø)` | |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `63.29% <0.00%> (-1.65%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `48.14% <0.00%> (ø)` | |
   | [...ache/dubbo/rpc/protocol/tri/TransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `35.55% <0.00%> (-5.48%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `29.62% <0.00%> (ø)` | |
   | [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `45.94% <ø> (ø)` | |
   | [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.98% <15.00%> (-3.55%)` | :arrow_down: |
   | [...java/org/apache/dubbo/rpc/CancellationContext.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9DYW5jZWxsYXRpb25Db250ZXh0LmphdmE=) | `25.00% <25.00%> (ø)` | |
   | [.../java/org/apache/dubbo/rpc/ExecutableListener.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9FeGVjdXRhYmxlTGlzdGVuZXIuamF2YQ==) | `33.33% <33.33%> (ø)` | |
   | ... and [67 more](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0643a7c...424b84a](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] EarthChen commented on pull request #8871: [3.0-Triple] Add handler for reset frame

Posted by GitBox <gi...@apache.org>.

EarthChen commented on pull request #8871:
URL: https://github.com/apache/dubbo/pull/8871#issuecomment-926440621


   > Move CancelContext into ServiceContext will be better?
   
   done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] EarthChen commented on a change in pull request #8871: [3.0-Triple] Add handler for reset frame

Posted by GitBox <gi...@apache.org>.

EarthChen commented on a change in pull request #8871:
URL: https://github.com/apache/dubbo/pull/8871#discussion_r716156552



##########
File path: dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/CancellationContext.java
##########
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.rpc;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.Executor;
+
+public class CancellationContext implements Closeable {
+
+    private ArrayList<ExecutableListener> listeners;
+    private Throwable cancellationCause;
+    private boolean cancelled;
+
+    public void addListener(
+            final CancellationListener cancellationListener, final Executor executor) {
+        addListener(cancellationListener, executor, null);
+    }
+
+    public void addListener(
+            final CancellationListener cancellationListener) {
+        addListener(cancellationListener, Runnable::run, null);
+    }
+
+    public void addListener(
+            final CancellationListener cancellationListener,
+            final RpcServiceContext context) {
+        addListener(cancellationListener, Runnable::run, context);
+    }
+
+    public void addListener(
+            final CancellationListener cancellationListener,
+            final Executor executor,
+            final RpcServiceContext context) {
+        addListenerInternal(new ExecutableListener(executor, cancellationListener, context));
+    }
+
+    public void addListenerInternal(ExecutableListener executableListener) {
+        synchronized (this) {
+            if (isCancelled()) {
+                executableListener.deliver();
+            } else {
+                if (listeners == null) {
+                    listeners = new ArrayList<>();
+                }
+                listeners.add(executableListener);
+            }
+        }
+    }
+
+    public boolean cancel(Throwable cause) {
+        boolean triggeredCancel = false;
+        synchronized (this) {
+            if (!cancelled) {
+                cancelled = true;
+                this.cancellationCause = cause;
+                triggeredCancel = true;
+            }
+        }
+        if (triggeredCancel) {
+            notifyAndClearListeners();
+        }
+        return triggeredCancel;
+    }
+
+    private void notifyAndClearListeners() {
+        ArrayList<ExecutableListener> tmpListeners;
+        synchronized (this) {
+            if (listeners == null) {
+                return;
+            }
+            tmpListeners = listeners;

Review comment:
       It's not going to produce




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8871: [3.0-Triple] Add handler for reset frame

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #8871:
URL: https://github.com/apache/dubbo/pull/8871#issuecomment-924659070


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8871](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (424b84a) into [3.0](https://codecov.io/gh/apache/dubbo/commit/0643a7ce7e8af1e469ff76a0d5624a28c5a17da4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0643a7c) will **decrease** coverage by `0.18%`.
   > The diff coverage is `36.44%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8871/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8871      +/-   ##
   ============================================
   - Coverage     63.42%   63.23%   -0.19%     
     Complexity      315      315              
   ============================================
     Files          1180     1182       +2     
     Lines         50031    50207     +176     
     Branches       7494     7511      +17     
   ============================================
   + Hits          31730    31749      +19     
   - Misses        14836    14985     +149     
   - Partials       3465     3473       +8     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/dubbo/rpc/RpcServiceContext.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNTZXJ2aWNlQ29udGV4dC5qYXZh) | `64.62% <ø> (ø)` | |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `63.29% <0.00%> (-1.65%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `48.14% <0.00%> (ø)` | |
   | [...ache/dubbo/rpc/protocol/tri/TransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `35.55% <0.00%> (-5.48%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `29.62% <0.00%> (ø)` | |
   | [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `45.94% <ø> (ø)` | |
   | [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.98% <15.00%> (-3.55%)` | :arrow_down: |
   | [...java/org/apache/dubbo/rpc/CancellationContext.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9DYW5jZWxsYXRpb25Db250ZXh0LmphdmE=) | `25.00% <25.00%> (ø)` | |
   | [.../java/org/apache/dubbo/rpc/ExecutableListener.java](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9FeGVjdXRhYmxlTGlzdGVuZXIuamF2YQ==) | `33.33% <33.33%> (ø)` | |
   | ... and [45 more](https://codecov.io/gh/apache/dubbo/pull/8871/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0643a7c...424b84a](https://codecov.io/gh/apache/dubbo/pull/8871?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org