You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shindig.apache.org by ch...@apache.org on 2010/05/19 19:52:01 UTC

svn commit: r946308 - in /shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache: LruCacheProvider.java ehcache/EhCacheCacheProvider.java

Author: chirag
Date: Wed May 19 17:52:00 2010
New Revision: 946308

URL: http://svn.apache.org/viewvc?rev=946308&view=rev
Log:
Wrap log.fine calls with isLoggable

Modified:
    shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/LruCacheProvider.java
    shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProvider.java

Modified: shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/LruCacheProvider.java
URL: http://svn.apache.org/viewvc/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/LruCacheProvider.java?rev=946308&r1=946307&r2=946308&view=diff
==============================================================================
--- shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/LruCacheProvider.java (original)
+++ shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/LruCacheProvider.java Wed May 19 17:52:00 2010
@@ -27,6 +27,7 @@ import com.google.inject.name.Named;
 import com.google.inject.name.Names;
 
 import java.util.Map;
+import java.util.logging.Level;
 import java.util.logging.Logger;
 
 /**
@@ -84,12 +85,16 @@ public class LruCacheProvider implements
   public <K, V> Cache<K, V> createCache(String name) {
     int capacity = getCapacity(name);
     if (name == null) {
-      LOG.fine("Creating anonymous cache");
+      if (LOG.isLoggable(Level.FINE)) {
+        LOG.fine("Creating anonymous cache");
+      }
       return new LruCache<K, V>(capacity);
     } else {
       Cache<K, V> cache = (Cache<K, V>) caches.get(name);
       if (cache == null) {
-        LOG.fine("Creating cache named " + name);
+        if (LOG.isLoggable(Level.FINE)) {
+          LOG.fine("Creating cache named " + name);
+        }
         cache = new LruCache<K, V>(capacity);
         caches.put(name, cache);
       }

Modified: shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProvider.java
URL: http://svn.apache.org/viewvc/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProvider.java?rev=946308&r1=946307&r2=946308&view=diff
==============================================================================
--- shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProvider.java (original)
+++ shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProvider.java Wed May 19 17:52:00 2010
@@ -35,6 +35,7 @@ import java.io.IOException;
 import java.io.InputStream;
 import java.lang.management.ManagementFactory;
 import java.util.Map;
+import java.util.logging.Level;
 import java.util.logging.Logger;
 
 public class EhCacheCacheProvider implements CacheProvider {
@@ -97,12 +98,16 @@ public class EhCacheCacheProvider implem
   @SuppressWarnings("unchecked")
   public <K, V> Cache<K, V> createCache(String name) {
     if (name == null) {
-      LOG.fine("Creating anonymous cache");
+      if (LOG.isLoggable(Level.FINE)) {
+        LOG.fine("Creating anonymous cache");
+      }
       return new EhConfiguredCache<K, V>(name, cacheManager);
     } else {
       Cache<K, V> cache = (Cache<K, V>) caches.get(name);
       if (cache == null) {
-        LOG.fine("Creating cache named " + name);
+        if (LOG.isLoggable(Level.FINE)) {
+          LOG.fine("Creating cache named " + name);
+        }
         cache = new EhConfiguredCache<K, V>(name, cacheManager);
         caches.put(name, cache);
       }