You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by Dawid Wysakowicz <dw...@apache.org> on 2025/03/10 15:50:18 UTC
Re: [VOTE] FLIP-507: Add Model DDL methods in TABLE API
+1 (binding)
Best,
Dawid
On Wed, 19 Feb 2025 at 18:37, Hao Li <hl...@confluent.io.invalid> wrote:
> +1 (non-binding)
>
> Thanks Yash,
> Hao
>
> On Tue, Feb 18, 2025 at 10:46 AM Yash Anand <ya...@confluent.io.invalid>
> wrote:
>
> > Hi Everyone,
> >
> > I'd like to start a vote on FLIP-507: Add Model DDL methods in TABLE API
> > [1] which has been discussed in this thread [2].
> >
> > The vote will be open for at least 72 hours unless there is an objection
> or
> > not enough votes.
> >
> > [1]
> >
> >
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-507%3A+Add+Model+DDL+methods+in+TABLE+API
> > [2] https://lists.apache.org/thread/w9dt6y1w0yns5j3g4685tstjdg5flvy9
> >
>
Re: [VOTE] FLIP-507: Add Model DDL methods in TABLE API
Posted by Yash Anand <ya...@confluent.io.INVALID>.
Hi everyone,
Thank you all for your votes. I am now closing the vote and will announce
the results in a separate email.
Thanks,
Yash Anand
On Wed, Mar 19, 2025 at 11:31 AM Yash Anand <ya...@confluent.io> wrote:
> Thanks all.
> We have reached 3 binding votes. Sorry for the last minute changes to the
> FLIP. If there are no objections, I will close the vote by tomorrow.
>
> Thanks,
> Yash Anand
>
> On Wed, Mar 19, 2025 at 10:55 AM Timo Walther <tw...@apache.org> wrote:
>
>> +1 (binding)
>>
>> Thank you for the update Yash. The FLIP is in a good shape now.
>>
>> Regards,
>> Timo
>>
>> On 17.03.25 17:50, Yash Anand wrote:
>> > Hi Timo,
>> >
>> > Thank you for your feedback. I have updated the FLIP to address your
>> > questions and concerns. Please let me know if you have any other
>> feedback.
>> >
>> > Thanks,
>> > Yash Anand
>> >
>> > On Tue, Mar 11, 2025 at 5:55 AM Timo Walther <tw...@apache.org>
>> wrote:
>> >
>> >> Hi Yash,
>> >>
>> >> thanks for updating the FLIP.
>> >>
>> >> Here is more feedback from my side:
>> >>
>> >> Add `option(ConfigOption<T> configOption, T value)` similar to
>> >> `TableDescriptor`.
>> >>
>> >> Use `comment()` instead of `setComment` to be in sync with
>> >> `TableDescriptor`.
>> >>
>> >> In `TableDescriptor`, the schema is not part of the `newBuilder` but
>> >> offered as optional method `schema()`, this allows for omitting the
>> >> schema and automatically derive it from the input. Do we want to offer
>> >> the same functionality? We might want to offer a CREATE MODEL AS syntax
>> >> in Table API?
>> >>
>> >> In `TableDescriptor.forConnector()` we make the connector option
>> >> mandatory, is there no similar mandatory option for models?
>> >>
>> >> Similar to Leonard, I will not directly -1 to cancel existing voting
>> >> process, but I hope to continue voting after the addressed above. For
>> >> the next time please make sure that the DISCUSS thread has settled
>> >> before voting.
>> >>
>> >> Thanks,
>> >> Timo
>> >>
>> >>
>> >> On 11.03.25 09:25, Leonard Xu wrote:
>> >>> Thanks @Anand for the quick response and update, the updated FLIP
>> looks
>> >> clear enough to me.
>> >>>
>> >>> +1(binding)
>> >>>
>> >>> Best,
>> >>> Leonard
>> >>>
>> >>>
>> >>>> 2025年3月11日 12:46，Yash Anand <ya...@confluent.io.INVALID> 写道：
>> >>>>
>> >>>> Hi Leonard,
>> >>>>
>> >>>> Thank you for your input. I will update the FLIP accordingly to make
>> it
>> >>>> more clear and standardized enough.
>> >>>>
>> >>>> Thanks,
>> >>>> Yash Anand
>> >>>>
>> >>>>
>> >>>>
>> >>>> On Mon, Mar 10, 2025 at 11:08 PM Leonard Xu <xb...@gmail.com>
>> wrote:
>> >>>>
>> >>>>> Sorry for jumping the thread late, but I think current status of
>> this
>> >> FLIP
>> >>>>> is not ready, at least for me
>> >>>>>
>> >>>>> (1) Could you finish your proposed API according Flink API bylaws?
>> For
>> >>>>> example the code piece should be:
>> >>>>> Builder<SELF> {
>> >>>>> SELF option(String key, String value
>> >>>>> SELF setComment(@Nullable String comment);
>> >>>>> =>
>> >>>>> /** Builder for {@link ModelDescriptor}. **/
>> >>>>> @PublicEvolving
>> >>>>> Builder<SELF> {
>> >>>>> /** Defines the option of {@link ModelDescriptor}. **/
>> >>>>> SELF option(String key, String value);
>> >>>>> /** Defines the comment of {@link ModelDescriptor}. **/
>> >>>>> SELF setComment(@Nullable String comment);
>> >>>>> (2) TableEnvironment is a public API, so any changes (such as adding
>> >>>>> public methods in this case) must be clearly documented. You may
>> refer
>> >> to
>> >>>>> [1] as an example. In the [Public Interfaces] section of this FLIP,
>> >> only
>> >>>>> TableEnvironment is listed. However, the subsequent [Proposed
>> Changes]
>> >>>>> section appears to conflate TableEnvironment with ModelDescriptor.
>> >>>>> Clarifications are needed:
>> >>>>> Which package should ModelDescriptor belong to?
>> >>>>> Is ModelDescriptor intended to be an inner class of
>> TableEnvironment?
>> >>>>>
>> >>>>> At last, this is a useful FLIP and I generally agree with the
>> >> motivation
>> >>>>> and design, but it is not clear and standardized enough.
>> >>>>> I will not directly -1 to cancel existing voting process, but I
>> hope to
>> >>>>> continue voting after the addressed above(1)(2) comments. WDYT?
>> >>>>>
>> >>>>> Best,
>> >>>>> Leonard
>> >>>>> [1]
>> >>>>>
>> >>
>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=334760466
>> >>>>>
>> >>>>>
>> >>>>>
>> >>>>>
>> >>>>>> 2025年3月11日 01:19，Yash Anand <ya...@confluent.io.INVALID> 写道：
>> >>>>>>
>> >>>>>> Hi Timo,
>> >>>>>>
>> >>>>>> Thanks for pointing that out. I have added the full API of
>> >>>>>> the ModelDescriptor in the FLIP.
>> >>>>>>
>> >>>>>> Thanks,
>> >>>>>> Yash Anand
>> >>>>>>
>> >>>>>>
>> >>>>>> On Mon, Mar 10, 2025 at 11:27 AM Timo Walther <tw...@apache.org>
>> >>>>> wrote:
>> >>>>>>
>> >>>>>>> Hi Yash,
>> >>>>>>>
>> >>>>>>> could you provide the full API of the ModelDescriptor in the FLIP?
>> >>>>>>>
>> >>>>>>> Thanks,
>> >>>>>>> Timo
>> >>>>>>>
>> >>>>>>>
>> >>>>>>> On 10.03.25 16:55, Mingge Deng wrote:
>> >>>>>>>> Thanks Yash!
>> >>>>>>>>
>> >>>>>>>> +1 (binding)
>> >>>>>>>>
>> >>>>>>>> Best,
>> >>>>>>>> Mingge
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>>> On Mon, Mar 10, 2025 at 8:51 AM Dawid Wysakowicz <
>> >>>>> dwysakowicz@apache.org
>> >>>>>>>>
>> >>>>>>>> wrote:
>> >>>>>>>>
>> >>>>>>>>> +1 (binding)
>> >>>>>>>>> Best,
>> >>>>>>>>> Dawid
>> >>>>>>>>>
>> >>>>>>>>> On Wed, 19 Feb 2025 at 18:37, Hao Li <hl...@confluent.io.invalid>
>> >>>>> wrote:
>> >>>>>>>>>
>> >>>>>>>>>> +1 (non-binding)
>> >>>>>>>>>>
>> >>>>>>>>>> Thanks Yash,
>> >>>>>>>>>> Hao
>> >>>>>>>>>>
>> >>>>>>>>>> On Tue, Feb 18, 2025 at 10:46 AM Yash Anand
>> >>>>>>> <yanand@confluent.io.invalid
>> >>>>>>>>>>
>> >>>>>>>>>> wrote:
>> >>>>>>>>>>
>> >>>>>>>>>>> Hi Everyone,
>> >>>>>>>>>>>
>> >>>>>>>>>>> I'd like to start a vote on FLIP-507: Add Model DDL methods in
>> >> TABLE
>> >>>>>>>>> API
>> >>>>>>>>>>> [1] which has been discussed in this thread [2].
>> >>>>>>>>>>>
>> >>>>>>>>>>> The vote will be open for at least 72 hours unless there is an
>> >>>>>>>>> objection
>> >>>>>>>>>> or
>> >>>>>>>>>>> not enough votes.
>> >>>>>>>>>>>
>> >>>>>>>>>>> [1]
>> >>>>>>>>>>>
>> >>>>>>>>>>>
>> >>>>>>>>>>
>> >>>>>>>>>
>> >>>>>>>
>> >>>>>
>> >>
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-507%3A+Add+Model+DDL+methods+in+TABLE+API
>> >>>>>>>>>>> [2]
>> >>>>> https://lists.apache.org/thread/w9dt6y1w0yns5j3g4685tstjdg5flvy9
>> >>>>>>>>>>>
>> >>>>>>>>>>
>> >>>>>>>>>
>> >>>>>>>>
>> >>>>>>>
>> >>>>>>>
>> >>>>>
>> >>>>>
>> >>>
>> >>
>> >>
>> >
>>
>>
Re: [VOTE] FLIP-507: Add Model DDL methods in TABLE API
Posted by Yash Anand <ya...@confluent.io.INVALID>.
Thanks all.
We have reached 3 binding votes. Sorry for the last minute changes to the
FLIP. If there are no objections, I will close the vote by tomorrow.
Thanks,
Yash Anand
On Wed, Mar 19, 2025 at 10:55 AM Timo Walther <tw...@apache.org> wrote:
> +1 (binding)
>
> Thank you for the update Yash. The FLIP is in a good shape now.
>
> Regards,
> Timo
>
> On 17.03.25 17:50, Yash Anand wrote:
> > Hi Timo,
> >
> > Thank you for your feedback. I have updated the FLIP to address your
> > questions and concerns. Please let me know if you have any other
> feedback.
> >
> > Thanks,
> > Yash Anand
> >
> > On Tue, Mar 11, 2025 at 5:55 AM Timo Walther <tw...@apache.org> wrote:
> >
> >> Hi Yash,
> >>
> >> thanks for updating the FLIP.
> >>
> >> Here is more feedback from my side:
> >>
> >> Add `option(ConfigOption<T> configOption, T value)` similar to
> >> `TableDescriptor`.
> >>
> >> Use `comment()` instead of `setComment` to be in sync with
> >> `TableDescriptor`.
> >>
> >> In `TableDescriptor`, the schema is not part of the `newBuilder` but
> >> offered as optional method `schema()`, this allows for omitting the
> >> schema and automatically derive it from the input. Do we want to offer
> >> the same functionality? We might want to offer a CREATE MODEL AS syntax
> >> in Table API?
> >>
> >> In `TableDescriptor.forConnector()` we make the connector option
> >> mandatory, is there no similar mandatory option for models?
> >>
> >> Similar to Leonard, I will not directly -1 to cancel existing voting
> >> process, but I hope to continue voting after the addressed above. For
> >> the next time please make sure that the DISCUSS thread has settled
> >> before voting.
> >>
> >> Thanks,
> >> Timo
> >>
> >>
> >> On 11.03.25 09:25, Leonard Xu wrote:
> >>> Thanks @Anand for the quick response and update, the updated FLIP looks
> >> clear enough to me.
> >>>
> >>> +1(binding)
> >>>
> >>> Best,
> >>> Leonard
> >>>
> >>>
> >>>> 2025年3月11日 12:46，Yash Anand <ya...@confluent.io.INVALID> 写道：
> >>>>
> >>>> Hi Leonard,
> >>>>
> >>>> Thank you for your input. I will update the FLIP accordingly to make
> it
> >>>> more clear and standardized enough.
> >>>>
> >>>> Thanks,
> >>>> Yash Anand
> >>>>
> >>>>
> >>>>
> >>>> On Mon, Mar 10, 2025 at 11:08 PM Leonard Xu <xb...@gmail.com>
> wrote:
> >>>>
> >>>>> Sorry for jumping the thread late, but I think current status of this
> >> FLIP
> >>>>> is not ready, at least for me
> >>>>>
> >>>>> (1) Could you finish your proposed API according Flink API bylaws?
> For
> >>>>> example the code piece should be:
> >>>>> Builder<SELF> {
> >>>>> SELF option(String key, String value
> >>>>> SELF setComment(@Nullable String comment);
> >>>>> =>
> >>>>> /** Builder for {@link ModelDescriptor}. **/
> >>>>> @PublicEvolving
> >>>>> Builder<SELF> {
> >>>>> /** Defines the option of {@link ModelDescriptor}. **/
> >>>>> SELF option(String key, String value);
> >>>>> /** Defines the comment of {@link ModelDescriptor}. **/
> >>>>> SELF setComment(@Nullable String comment);
> >>>>> (2) TableEnvironment is a public API, so any changes (such as adding
> >>>>> public methods in this case) must be clearly documented. You may
> refer
> >> to
> >>>>> [1] as an example. In the [Public Interfaces] section of this FLIP,
> >> only
> >>>>> TableEnvironment is listed. However, the subsequent [Proposed
> Changes]
> >>>>> section appears to conflate TableEnvironment with ModelDescriptor.
> >>>>> Clarifications are needed:
> >>>>> Which package should ModelDescriptor belong to?
> >>>>> Is ModelDescriptor intended to be an inner class of TableEnvironment?
> >>>>>
> >>>>> At last, this is a useful FLIP and I generally agree with the
> >> motivation
> >>>>> and design, but it is not clear and standardized enough.
> >>>>> I will not directly -1 to cancel existing voting process, but I hope
> to
> >>>>> continue voting after the addressed above(1)(2) comments. WDYT?
> >>>>>
> >>>>> Best,
> >>>>> Leonard
> >>>>> [1]
> >>>>>
> >>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=334760466
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>>> 2025年3月11日 01:19，Yash Anand <ya...@confluent.io.INVALID> 写道：
> >>>>>>
> >>>>>> Hi Timo,
> >>>>>>
> >>>>>> Thanks for pointing that out. I have added the full API of
> >>>>>> the ModelDescriptor in the FLIP.
> >>>>>>
> >>>>>> Thanks,
> >>>>>> Yash Anand
> >>>>>>
> >>>>>>
> >>>>>> On Mon, Mar 10, 2025 at 11:27 AM Timo Walther <tw...@apache.org>
> >>>>> wrote:
> >>>>>>
> >>>>>>> Hi Yash,
> >>>>>>>
> >>>>>>> could you provide the full API of the ModelDescriptor in the FLIP?
> >>>>>>>
> >>>>>>> Thanks,
> >>>>>>> Timo
> >>>>>>>
> >>>>>>>
> >>>>>>> On 10.03.25 16:55, Mingge Deng wrote:
> >>>>>>>> Thanks Yash!
> >>>>>>>>
> >>>>>>>> +1 (binding)
> >>>>>>>>
> >>>>>>>> Best,
> >>>>>>>> Mingge
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> On Mon, Mar 10, 2025 at 8:51 AM Dawid Wysakowicz <
> >>>>> dwysakowicz@apache.org
> >>>>>>>>
> >>>>>>>> wrote:
> >>>>>>>>
> >>>>>>>>> +1 (binding)
> >>>>>>>>> Best,
> >>>>>>>>> Dawid
> >>>>>>>>>
> >>>>>>>>> On Wed, 19 Feb 2025 at 18:37, Hao Li <hl...@confluent.io.invalid>
> >>>>> wrote:
> >>>>>>>>>
> >>>>>>>>>> +1 (non-binding)
> >>>>>>>>>>
> >>>>>>>>>> Thanks Yash,
> >>>>>>>>>> Hao
> >>>>>>>>>>
> >>>>>>>>>> On Tue, Feb 18, 2025 at 10:46 AM Yash Anand
> >>>>>>> <yanand@confluent.io.invalid
> >>>>>>>>>>
> >>>>>>>>>> wrote:
> >>>>>>>>>>
> >>>>>>>>>>> Hi Everyone,
> >>>>>>>>>>>
> >>>>>>>>>>> I'd like to start a vote on FLIP-507: Add Model DDL methods in
> >> TABLE
> >>>>>>>>> API
> >>>>>>>>>>> [1] which has been discussed in this thread [2].
> >>>>>>>>>>>
> >>>>>>>>>>> The vote will be open for at least 72 hours unless there is an
> >>>>>>>>> objection
> >>>>>>>>>> or
> >>>>>>>>>>> not enough votes.
> >>>>>>>>>>>
> >>>>>>>>>>> [1]
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>
> >>>>>>>
> >>>>>
> >>
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-507%3A+Add+Model+DDL+methods+in+TABLE+API
> >>>>>>>>>>> [2]
> >>>>> https://lists.apache.org/thread/w9dt6y1w0yns5j3g4685tstjdg5flvy9
> >>>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>
> >>>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>
> >>>>>
> >>>
> >>
> >>
> >
>
>
Re: [VOTE] FLIP-507: Add Model DDL methods in TABLE API
Posted by Timo Walther <tw...@apache.org>.
+1 (binding)
Thank you for the update Yash. The FLIP is in a good shape now.
Regards,
Timo
On 17.03.25 17:50, Yash Anand wrote:
> Hi Timo,
>
> Thank you for your feedback. I have updated the FLIP to address your
> questions and concerns. Please let me know if you have any other feedback.
>
> Thanks,
> Yash Anand
>
> On Tue, Mar 11, 2025 at 5:55 AM Timo Walther <tw...@apache.org> wrote:
>
>> Hi Yash,
>>
>> thanks for updating the FLIP.
>>
>> Here is more feedback from my side:
>>
>> Add `option(ConfigOption<T> configOption, T value)` similar to
>> `TableDescriptor`.
>>
>> Use `comment()` instead of `setComment` to be in sync with
>> `TableDescriptor`.
>>
>> In `TableDescriptor`, the schema is not part of the `newBuilder` but
>> offered as optional method `schema()`, this allows for omitting the
>> schema and automatically derive it from the input. Do we want to offer
>> the same functionality? We might want to offer a CREATE MODEL AS syntax
>> in Table API?
>>
>> In `TableDescriptor.forConnector()` we make the connector option
>> mandatory, is there no similar mandatory option for models?
>>
>> Similar to Leonard, I will not directly -1 to cancel existing voting
>> process, but I hope to continue voting after the addressed above. For
>> the next time please make sure that the DISCUSS thread has settled
>> before voting.
>>
>> Thanks,
>> Timo
>>
>>
>> On 11.03.25 09:25, Leonard Xu wrote:
>>> Thanks @Anand for the quick response and update, the updated FLIP looks
>> clear enough to me.
>>>
>>> +1(binding)
>>>
>>> Best,
>>> Leonard
>>>
>>>
>>>> 2025年3月11日 12:46，Yash Anand <ya...@confluent.io.INVALID> 写道：
>>>>
>>>> Hi Leonard,
>>>>
>>>> Thank you for your input. I will update the FLIP accordingly to make it
>>>> more clear and standardized enough.
>>>>
>>>> Thanks,
>>>> Yash Anand
>>>>
>>>>
>>>>
>>>> On Mon, Mar 10, 2025 at 11:08 PM Leonard Xu <xb...@gmail.com> wrote:
>>>>
>>>>> Sorry for jumping the thread late, but I think current status of this
>> FLIP
>>>>> is not ready, at least for me
>>>>>
>>>>> (1) Could you finish your proposed API according Flink API bylaws? For
>>>>> example the code piece should be:
>>>>> Builder<SELF> {
>>>>> SELF option(String key, String value
>>>>> SELF setComment(@Nullable String comment);
>>>>> =>
>>>>> /** Builder for {@link ModelDescriptor}. **/
>>>>> @PublicEvolving
>>>>> Builder<SELF> {
>>>>> /** Defines the option of {@link ModelDescriptor}. **/
>>>>> SELF option(String key, String value);
>>>>> /** Defines the comment of {@link ModelDescriptor}. **/
>>>>> SELF setComment(@Nullable String comment);
>>>>> (2) TableEnvironment is a public API, so any changes (such as adding
>>>>> public methods in this case) must be clearly documented. You may refer
>> to
>>>>> [1] as an example. In the [Public Interfaces] section of this FLIP,
>> only
>>>>> TableEnvironment is listed. However, the subsequent [Proposed Changes]
>>>>> section appears to conflate TableEnvironment with ModelDescriptor.
>>>>> Clarifications are needed:
>>>>> Which package should ModelDescriptor belong to?
>>>>> Is ModelDescriptor intended to be an inner class of TableEnvironment?
>>>>>
>>>>> At last, this is a useful FLIP and I generally agree with the
>> motivation
>>>>> and design, but it is not clear and standardized enough.
>>>>> I will not directly -1 to cancel existing voting process, but I hope to
>>>>> continue voting after the addressed above(1)(2) comments. WDYT?
>>>>>
>>>>> Best,
>>>>> Leonard
>>>>> [1]
>>>>>
>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=334760466
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>> 2025年3月11日 01:19，Yash Anand <ya...@confluent.io.INVALID> 写道：
>>>>>>
>>>>>> Hi Timo,
>>>>>>
>>>>>> Thanks for pointing that out. I have added the full API of
>>>>>> the ModelDescriptor in the FLIP.
>>>>>>
>>>>>> Thanks,
>>>>>> Yash Anand
>>>>>>
>>>>>>
>>>>>> On Mon, Mar 10, 2025 at 11:27 AM Timo Walther <tw...@apache.org>
>>>>> wrote:
>>>>>>
>>>>>>> Hi Yash,
>>>>>>>
>>>>>>> could you provide the full API of the ModelDescriptor in the FLIP?
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Timo
>>>>>>>
>>>>>>>
>>>>>>> On 10.03.25 16:55, Mingge Deng wrote:
>>>>>>>> Thanks Yash!
>>>>>>>>
>>>>>>>> +1 (binding)
>>>>>>>>
>>>>>>>> Best,
>>>>>>>> Mingge
>>>>>>>>
>>>>>>>>
>>>>>>>> On Mon, Mar 10, 2025 at 8:51 AM Dawid Wysakowicz <
>>>>> dwysakowicz@apache.org
>>>>>>>>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> +1 (binding)
>>>>>>>>> Best,
>>>>>>>>> Dawid
>>>>>>>>>
>>>>>>>>> On Wed, 19 Feb 2025 at 18:37, Hao Li <hl...@confluent.io.invalid>
>>>>> wrote:
>>>>>>>>>
>>>>>>>>>> +1 (non-binding)
>>>>>>>>>>
>>>>>>>>>> Thanks Yash,
>>>>>>>>>> Hao
>>>>>>>>>>
>>>>>>>>>> On Tue, Feb 18, 2025 at 10:46 AM Yash Anand
>>>>>>> <yanand@confluent.io.invalid
>>>>>>>>>>
>>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi Everyone,
>>>>>>>>>>>
>>>>>>>>>>> I'd like to start a vote on FLIP-507: Add Model DDL methods in
>> TABLE
>>>>>>>>> API
>>>>>>>>>>> [1] which has been discussed in this thread [2].
>>>>>>>>>>>
>>>>>>>>>>> The vote will be open for at least 72 hours unless there is an
>>>>>>>>> objection
>>>>>>>>>> or
>>>>>>>>>>> not enough votes.
>>>>>>>>>>>
>>>>>>>>>>> [1]
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>
>>>>>
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-507%3A+Add+Model+DDL+methods+in+TABLE+API
>>>>>>>>>>> [2]
>>>>> https://lists.apache.org/thread/w9dt6y1w0yns5j3g4685tstjdg5flvy9
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>
>>>>>
>>>
>>
>>
>
Re: [VOTE] FLIP-507: Add Model DDL methods in TABLE API
Posted by Yash Anand <ya...@confluent.io.INVALID>.
Hi Timo,
Thank you for your feedback. I have updated the FLIP to address your
questions and concerns. Please let me know if you have any other feedback.
Thanks,
Yash Anand
On Tue, Mar 11, 2025 at 5:55 AM Timo Walther <tw...@apache.org> wrote:
> Hi Yash,
>
> thanks for updating the FLIP.
>
> Here is more feedback from my side:
>
> Add `option(ConfigOption<T> configOption, T value)` similar to
> `TableDescriptor`.
>
> Use `comment()` instead of `setComment` to be in sync with
> `TableDescriptor`.
>
> In `TableDescriptor`, the schema is not part of the `newBuilder` but
> offered as optional method `schema()`, this allows for omitting the
> schema and automatically derive it from the input. Do we want to offer
> the same functionality? We might want to offer a CREATE MODEL AS syntax
> in Table API?
>
> In `TableDescriptor.forConnector()` we make the connector option
> mandatory, is there no similar mandatory option for models?
>
> Similar to Leonard, I will not directly -1 to cancel existing voting
> process, but I hope to continue voting after the addressed above. For
> the next time please make sure that the DISCUSS thread has settled
> before voting.
>
> Thanks,
> Timo
>
>
> On 11.03.25 09:25, Leonard Xu wrote:
> > Thanks @Anand for the quick response and update, the updated FLIP looks
> clear enough to me.
> >
> > +1(binding)
> >
> > Best,
> > Leonard
> >
> >
> >> 2025年3月11日 12:46，Yash Anand <ya...@confluent.io.INVALID> 写道：
> >>
> >> Hi Leonard,
> >>
> >> Thank you for your input. I will update the FLIP accordingly to make it
> >> more clear and standardized enough.
> >>
> >> Thanks,
> >> Yash Anand
> >>
> >>
> >>
> >> On Mon, Mar 10, 2025 at 11:08 PM Leonard Xu <xb...@gmail.com> wrote:
> >>
> >>> Sorry for jumping the thread late, but I think current status of this
> FLIP
> >>> is not ready, at least for me
> >>>
> >>> (1) Could you finish your proposed API according Flink API bylaws? For
> >>> example the code piece should be:
> >>> Builder<SELF> {
> >>> SELF option(String key, String value
> >>> SELF setComment(@Nullable String comment);
> >>> =>
> >>> /** Builder for {@link ModelDescriptor}. **/
> >>> @PublicEvolving
> >>> Builder<SELF> {
> >>> /** Defines the option of {@link ModelDescriptor}. **/
> >>> SELF option(String key, String value);
> >>> /** Defines the comment of {@link ModelDescriptor}. **/
> >>> SELF setComment(@Nullable String comment);
> >>> (2) TableEnvironment is a public API, so any changes (such as adding
> >>> public methods in this case) must be clearly documented. You may refer
> to
> >>> [1] as an example. In the [Public Interfaces] section of this FLIP,
> only
> >>> TableEnvironment is listed. However, the subsequent [Proposed Changes]
> >>> section appears to conflate TableEnvironment with ModelDescriptor.
> >>> Clarifications are needed:
> >>> Which package should ModelDescriptor belong to?
> >>> Is ModelDescriptor intended to be an inner class of TableEnvironment?
> >>>
> >>> At last, this is a useful FLIP and I generally agree with the
> motivation
> >>> and design, but it is not clear and standardized enough.
> >>> I will not directly -1 to cancel existing voting process, but I hope to
> >>> continue voting after the addressed above(1)(2) comments. WDYT?
> >>>
> >>> Best,
> >>> Leonard
> >>> [1]
> >>>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=334760466
> >>>
> >>>
> >>>
> >>>
> >>>> 2025年3月11日 01:19，Yash Anand <ya...@confluent.io.INVALID> 写道：
> >>>>
> >>>> Hi Timo,
> >>>>
> >>>> Thanks for pointing that out. I have added the full API of
> >>>> the ModelDescriptor in the FLIP.
> >>>>
> >>>> Thanks,
> >>>> Yash Anand
> >>>>
> >>>>
> >>>> On Mon, Mar 10, 2025 at 11:27 AM Timo Walther <tw...@apache.org>
> >>> wrote:
> >>>>
> >>>>> Hi Yash,
> >>>>>
> >>>>> could you provide the full API of the ModelDescriptor in the FLIP?
> >>>>>
> >>>>> Thanks,
> >>>>> Timo
> >>>>>
> >>>>>
> >>>>> On 10.03.25 16:55, Mingge Deng wrote:
> >>>>>> Thanks Yash!
> >>>>>>
> >>>>>> +1 (binding)
> >>>>>>
> >>>>>> Best,
> >>>>>> Mingge
> >>>>>>
> >>>>>>
> >>>>>> On Mon, Mar 10, 2025 at 8:51 AM Dawid Wysakowicz <
> >>> dwysakowicz@apache.org
> >>>>>>
> >>>>>> wrote:
> >>>>>>
> >>>>>>> +1 (binding)
> >>>>>>> Best,
> >>>>>>> Dawid
> >>>>>>>
> >>>>>>> On Wed, 19 Feb 2025 at 18:37, Hao Li <hl...@confluent.io.invalid>
> >>> wrote:
> >>>>>>>
> >>>>>>>> +1 (non-binding)
> >>>>>>>>
> >>>>>>>> Thanks Yash,
> >>>>>>>> Hao
> >>>>>>>>
> >>>>>>>> On Tue, Feb 18, 2025 at 10:46 AM Yash Anand
> >>>>> <yanand@confluent.io.invalid
> >>>>>>>>
> >>>>>>>> wrote:
> >>>>>>>>
> >>>>>>>>> Hi Everyone,
> >>>>>>>>>
> >>>>>>>>> I'd like to start a vote on FLIP-507: Add Model DDL methods in
> TABLE
> >>>>>>> API
> >>>>>>>>> [1] which has been discussed in this thread [2].
> >>>>>>>>>
> >>>>>>>>> The vote will be open for at least 72 hours unless there is an
> >>>>>>> objection
> >>>>>>>> or
> >>>>>>>>> not enough votes.
> >>>>>>>>>
> >>>>>>>>> [1]
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>
> >>>>>>>
> >>>>>
> >>>
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-507%3A+Add+Model+DDL+methods+in+TABLE+API
> >>>>>>>>> [2]
> >>> https://lists.apache.org/thread/w9dt6y1w0yns5j3g4685tstjdg5flvy9
> >>>>>>>>>
> >>>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>
> >>>>>
> >>>
> >>>
> >
>
>
Re: [VOTE] FLIP-507: Add Model DDL methods in TABLE API
Posted by Timo Walther <tw...@apache.org>.
Hi Yash,
thanks for updating the FLIP.
Here is more feedback from my side:
Add `option(ConfigOption<T> configOption, T value)` similar to
`TableDescriptor`.
Use `comment()` instead of `setComment` to be in sync with
`TableDescriptor`.
In `TableDescriptor`, the schema is not part of the `newBuilder` but
offered as optional method `schema()`, this allows for omitting the
schema and automatically derive it from the input. Do we want to offer
the same functionality? We might want to offer a CREATE MODEL AS syntax
in Table API?
In `TableDescriptor.forConnector()` we make the connector option
mandatory, is there no similar mandatory option for models?
Similar to Leonard, I will not directly -1 to cancel existing voting
process, but I hope to continue voting after the addressed above. For
the next time please make sure that the DISCUSS thread has settled
before voting.
Thanks,
Timo
On 11.03.25 09:25, Leonard Xu wrote:
> Thanks @Anand for the quick response and update, the updated FLIP looks clear enough to me.
>
> +1(binding)
>
> Best,
> Leonard
>
>
>> 2025年3月11日 12:46，Yash Anand <ya...@confluent.io.INVALID> 写道：
>>
>> Hi Leonard,
>>
>> Thank you for your input. I will update the FLIP accordingly to make it
>> more clear and standardized enough.
>>
>> Thanks,
>> Yash Anand
>>
>>
>>
>> On Mon, Mar 10, 2025 at 11:08 PM Leonard Xu <xb...@gmail.com> wrote:
>>
>>> Sorry for jumping the thread late, but I think current status of this FLIP
>>> is not ready, at least for me
>>>
>>> (1) Could you finish your proposed API according Flink API bylaws? For
>>> example the code piece should be:
>>> Builder<SELF> {
>>> SELF option(String key, String value
>>> SELF setComment(@Nullable String comment);
>>> =>
>>> /** Builder for {@link ModelDescriptor}. **/
>>> @PublicEvolving
>>> Builder<SELF> {
>>> /** Defines the option of {@link ModelDescriptor}. **/
>>> SELF option(String key, String value);
>>> /** Defines the comment of {@link ModelDescriptor}. **/
>>> SELF setComment(@Nullable String comment);
>>> (2) TableEnvironment is a public API, so any changes (such as adding
>>> public methods in this case) must be clearly documented. You may refer to
>>> [1] as an example. In the [Public Interfaces] section of this FLIP, only
>>> TableEnvironment is listed. However, the subsequent [Proposed Changes]
>>> section appears to conflate TableEnvironment with ModelDescriptor.
>>> Clarifications are needed:
>>> Which package should ModelDescriptor belong to?
>>> Is ModelDescriptor intended to be an inner class of TableEnvironment?
>>>
>>> At last, this is a useful FLIP and I generally agree with the motivation
>>> and design, but it is not clear and standardized enough.
>>> I will not directly -1 to cancel existing voting process, but I hope to
>>> continue voting after the addressed above(1)(2) comments. WDYT?
>>>
>>> Best,
>>> Leonard
>>> [1]
>>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=334760466
>>>
>>>
>>>
>>>
>>>> 2025年3月11日 01:19，Yash Anand <ya...@confluent.io.INVALID> 写道：
>>>>
>>>> Hi Timo,
>>>>
>>>> Thanks for pointing that out. I have added the full API of
>>>> the ModelDescriptor in the FLIP.
>>>>
>>>> Thanks,
>>>> Yash Anand
>>>>
>>>>
>>>> On Mon, Mar 10, 2025 at 11:27 AM Timo Walther <tw...@apache.org>
>>> wrote:
>>>>
>>>>> Hi Yash,
>>>>>
>>>>> could you provide the full API of the ModelDescriptor in the FLIP?
>>>>>
>>>>> Thanks,
>>>>> Timo
>>>>>
>>>>>
>>>>> On 10.03.25 16:55, Mingge Deng wrote:
>>>>>> Thanks Yash!
>>>>>>
>>>>>> +1 (binding)
>>>>>>
>>>>>> Best,
>>>>>> Mingge
>>>>>>
>>>>>>
>>>>>> On Mon, Mar 10, 2025 at 8:51 AM Dawid Wysakowicz <
>>> dwysakowicz@apache.org
>>>>>>
>>>>>> wrote:
>>>>>>
>>>>>>> +1 (binding)
>>>>>>> Best,
>>>>>>> Dawid
>>>>>>>
>>>>>>> On Wed, 19 Feb 2025 at 18:37, Hao Li <hl...@confluent.io.invalid>
>>> wrote:
>>>>>>>
>>>>>>>> +1 (non-binding)
>>>>>>>>
>>>>>>>> Thanks Yash,
>>>>>>>> Hao
>>>>>>>>
>>>>>>>> On Tue, Feb 18, 2025 at 10:46 AM Yash Anand
>>>>> <yanand@confluent.io.invalid
>>>>>>>>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Hi Everyone,
>>>>>>>>>
>>>>>>>>> I'd like to start a vote on FLIP-507: Add Model DDL methods in TABLE
>>>>>>> API
>>>>>>>>> [1] which has been discussed in this thread [2].
>>>>>>>>>
>>>>>>>>> The vote will be open for at least 72 hours unless there is an
>>>>>>> objection
>>>>>>>> or
>>>>>>>>> not enough votes.
>>>>>>>>>
>>>>>>>>> [1]
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>
>>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-507%3A+Add+Model+DDL+methods+in+TABLE+API
>>>>>>>>> [2]
>>> https://lists.apache.org/thread/w9dt6y1w0yns5j3g4685tstjdg5flvy9
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>
>>>
>
Re: [VOTE] FLIP-507: Add Model DDL methods in TABLE API
Posted by Leonard Xu <xb...@gmail.com>.
Thanks @Anand for the quick response and update, the updated FLIP looks clear enough to me.
+1(binding)
Best,
Leonard
> 2025年3月11日 12:46，Yash Anand <ya...@confluent.io.INVALID> 写道：
>
> Hi Leonard,
>
> Thank you for your input. I will update the FLIP accordingly to make it
> more clear and standardized enough.
>
> Thanks,
> Yash Anand
>
>
>
> On Mon, Mar 10, 2025 at 11:08 PM Leonard Xu <xb...@gmail.com> wrote:
>
>> Sorry for jumping the thread late, but I think current status of this FLIP
>> is not ready, at least for me
>>
>> (1) Could you finish your proposed API according Flink API bylaws? For
>> example the code piece should be:
>> Builder<SELF> {
>> SELF option(String key, String value
>> SELF setComment(@Nullable String comment);
>> =>
>> /** Builder for {@link ModelDescriptor}. **/
>> @PublicEvolving
>> Builder<SELF> {
>> /** Defines the option of {@link ModelDescriptor}. **/
>> SELF option(String key, String value);
>> /** Defines the comment of {@link ModelDescriptor}. **/
>> SELF setComment(@Nullable String comment);
>> (2) TableEnvironment is a public API, so any changes (such as adding
>> public methods in this case) must be clearly documented. You may refer to
>> [1] as an example. In the [Public Interfaces] section of this FLIP, only
>> TableEnvironment is listed. However, the subsequent [Proposed Changes]
>> section appears to conflate TableEnvironment with ModelDescriptor.
>> Clarifications are needed:
>> Which package should ModelDescriptor belong to?
>> Is ModelDescriptor intended to be an inner class of TableEnvironment?
>>
>> At last, this is a useful FLIP and I generally agree with the motivation
>> and design, but it is not clear and standardized enough.
>> I will not directly -1 to cancel existing voting process, but I hope to
>> continue voting after the addressed above(1)(2) comments. WDYT?
>>
>> Best,
>> Leonard
>> [1]
>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=334760466
>>
>>
>>
>>
>>> 2025年3月11日 01:19，Yash Anand <ya...@confluent.io.INVALID> 写道：
>>>
>>> Hi Timo,
>>>
>>> Thanks for pointing that out. I have added the full API of
>>> the ModelDescriptor in the FLIP.
>>>
>>> Thanks,
>>> Yash Anand
>>>
>>>
>>> On Mon, Mar 10, 2025 at 11:27 AM Timo Walther <tw...@apache.org>
>> wrote:
>>>
>>>> Hi Yash,
>>>>
>>>> could you provide the full API of the ModelDescriptor in the FLIP?
>>>>
>>>> Thanks,
>>>> Timo
>>>>
>>>>
>>>> On 10.03.25 16:55, Mingge Deng wrote:
>>>>> Thanks Yash!
>>>>>
>>>>> +1 (binding)
>>>>>
>>>>> Best,
>>>>> Mingge
>>>>>
>>>>>
>>>>> On Mon, Mar 10, 2025 at 8:51 AM Dawid Wysakowicz <
>> dwysakowicz@apache.org
>>>>>
>>>>> wrote:
>>>>>
>>>>>> +1 (binding)
>>>>>> Best,
>>>>>> Dawid
>>>>>>
>>>>>> On Wed, 19 Feb 2025 at 18:37, Hao Li <hl...@confluent.io.invalid>
>> wrote:
>>>>>>
>>>>>>> +1 (non-binding)
>>>>>>>
>>>>>>> Thanks Yash,
>>>>>>> Hao
>>>>>>>
>>>>>>> On Tue, Feb 18, 2025 at 10:46 AM Yash Anand
>>>> <yanand@confluent.io.invalid
>>>>>>>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Hi Everyone,
>>>>>>>>
>>>>>>>> I'd like to start a vote on FLIP-507: Add Model DDL methods in TABLE
>>>>>> API
>>>>>>>> [1] which has been discussed in this thread [2].
>>>>>>>>
>>>>>>>> The vote will be open for at least 72 hours unless there is an
>>>>>> objection
>>>>>>> or
>>>>>>>> not enough votes.
>>>>>>>>
>>>>>>>> [1]
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-507%3A+Add+Model+DDL+methods+in+TABLE+API
>>>>>>>> [2]
>> https://lists.apache.org/thread/w9dt6y1w0yns5j3g4685tstjdg5flvy9
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>
>>
Re: [VOTE] FLIP-507: Add Model DDL methods in TABLE API
Posted by Yash Anand <ya...@confluent.io.INVALID>.
Hi Leonard,
Thank you for your input. I will update the FLIP accordingly to make it
more clear and standardized enough.
Thanks,
Yash Anand
On Mon, Mar 10, 2025 at 11:08 PM Leonard Xu <xb...@gmail.com> wrote:
> Sorry for jumping the thread late, but I think current status of this FLIP
> is not ready, at least for me
>
> (1) Could you finish your proposed API according Flink API bylaws? For
> example the code piece should be:
> Builder<SELF> {
> SELF option(String key, String value
> SELF setComment(@Nullable String comment);
> =>
> /** Builder for {@link ModelDescriptor}. **/
> @PublicEvolving
> Builder<SELF> {
> /** Defines the option of {@link ModelDescriptor}. **/
> SELF option(String key, String value);
> /** Defines the comment of {@link ModelDescriptor}. **/
> SELF setComment(@Nullable String comment);
> (2) TableEnvironment is a public API, so any changes (such as adding
> public methods in this case) must be clearly documented. You may refer to
> [1] as an example. In the [Public Interfaces] section of this FLIP, only
> TableEnvironment is listed. However, the subsequent [Proposed Changes]
> section appears to conflate TableEnvironment with ModelDescriptor.
> Clarifications are needed:
> Which package should ModelDescriptor belong to?
> Is ModelDescriptor intended to be an inner class of TableEnvironment?
>
> At last, this is a useful FLIP and I generally agree with the motivation
> and design, but it is not clear and standardized enough.
> I will not directly -1 to cancel existing voting process, but I hope to
> continue voting after the addressed above(1)(2) comments. WDYT?
>
> Best,
> Leonard
> [1]
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=334760466
>
>
>
>
> > 2025年3月11日 01:19，Yash Anand <ya...@confluent.io.INVALID> 写道：
> >
> > Hi Timo,
> >
> > Thanks for pointing that out. I have added the full API of
> > the ModelDescriptor in the FLIP.
> >
> > Thanks,
> > Yash Anand
> >
> >
> > On Mon, Mar 10, 2025 at 11:27 AM Timo Walther <tw...@apache.org>
> wrote:
> >
> >> Hi Yash,
> >>
> >> could you provide the full API of the ModelDescriptor in the FLIP?
> >>
> >> Thanks,
> >> Timo
> >>
> >>
> >> On 10.03.25 16:55, Mingge Deng wrote:
> >>> Thanks Yash!
> >>>
> >>> +1 (binding)
> >>>
> >>> Best,
> >>> Mingge
> >>>
> >>>
> >>> On Mon, Mar 10, 2025 at 8:51 AM Dawid Wysakowicz <
> dwysakowicz@apache.org
> >>>
> >>> wrote:
> >>>
> >>>> +1 (binding)
> >>>> Best,
> >>>> Dawid
> >>>>
> >>>> On Wed, 19 Feb 2025 at 18:37, Hao Li <hl...@confluent.io.invalid>
> wrote:
> >>>>
> >>>>> +1 (non-binding)
> >>>>>
> >>>>> Thanks Yash,
> >>>>> Hao
> >>>>>
> >>>>> On Tue, Feb 18, 2025 at 10:46 AM Yash Anand
> >> <yanand@confluent.io.invalid
> >>>>>
> >>>>> wrote:
> >>>>>
> >>>>>> Hi Everyone,
> >>>>>>
> >>>>>> I'd like to start a vote on FLIP-507: Add Model DDL methods in TABLE
> >>>> API
> >>>>>> [1] which has been discussed in this thread [2].
> >>>>>>
> >>>>>> The vote will be open for at least 72 hours unless there is an
> >>>> objection
> >>>>> or
> >>>>>> not enough votes.
> >>>>>>
> >>>>>> [1]
> >>>>>>
> >>>>>>
> >>>>>
> >>>>
> >>
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-507%3A+Add+Model+DDL+methods+in+TABLE+API
> >>>>>> [2]
> https://lists.apache.org/thread/w9dt6y1w0yns5j3g4685tstjdg5flvy9
> >>>>>>
> >>>>>
> >>>>
> >>>
> >>
> >>
>
>
Re: [VOTE] FLIP-507: Add Model DDL methods in TABLE API
Posted by Leonard Xu <xb...@gmail.com>.
Sorry for jumping the thread late, but I think current status of this FLIP is not ready, at least for me
(1) Could you finish your proposed API according Flink API bylaws? For example the code piece should be:
Builder<SELF> {
SELF option(String key, String value
SELF setComment(@Nullable String comment);
=>
/** Builder for {@link ModelDescriptor}. **/
@PublicEvolving
Builder<SELF> {
/** Defines the option of {@link ModelDescriptor}. **/
SELF option(String key, String value);
/** Defines the comment of {@link ModelDescriptor}. **/
SELF setComment(@Nullable String comment);
(2) TableEnvironment is a public API, so any changes (such as adding public methods in this case) must be clearly documented. You may refer to [1] as an example. In the [Public Interfaces] section of this FLIP, only TableEnvironment is listed. However, the subsequent [Proposed Changes] section appears to conflate TableEnvironment with ModelDescriptor. Clarifications are needed:
Which package should ModelDescriptor belong to?
Is ModelDescriptor intended to be an inner class of TableEnvironment?
At last, this is a useful FLIP and I generally agree with the motivation and design, but it is not clear and standardized enough.
I will not directly -1 to cancel existing voting process, but I hope to continue voting after the addressed above(1)(2) comments. WDYT?
Best,
Leonard
[1] https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=334760466
> 2025年3月11日 01:19，Yash Anand <ya...@confluent.io.INVALID> 写道：
>
> Hi Timo,
>
> Thanks for pointing that out. I have added the full API of
> the ModelDescriptor in the FLIP.
>
> Thanks,
> Yash Anand
>
>
> On Mon, Mar 10, 2025 at 11:27 AM Timo Walther <tw...@apache.org> wrote:
>
>> Hi Yash,
>>
>> could you provide the full API of the ModelDescriptor in the FLIP?
>>
>> Thanks,
>> Timo
>>
>>
>> On 10.03.25 16:55, Mingge Deng wrote:
>>> Thanks Yash!
>>>
>>> +1 (binding)
>>>
>>> Best,
>>> Mingge
>>>
>>>
>>> On Mon, Mar 10, 2025 at 8:51 AM Dawid Wysakowicz <dwysakowicz@apache.org
>>>
>>> wrote:
>>>
>>>> +1 (binding)
>>>> Best,
>>>> Dawid
>>>>
>>>> On Wed, 19 Feb 2025 at 18:37, Hao Li <hl...@confluent.io.invalid> wrote:
>>>>
>>>>> +1 (non-binding)
>>>>>
>>>>> Thanks Yash,
>>>>> Hao
>>>>>
>>>>> On Tue, Feb 18, 2025 at 10:46 AM Yash Anand
>> <yanand@confluent.io.invalid
>>>>>
>>>>> wrote:
>>>>>
>>>>>> Hi Everyone,
>>>>>>
>>>>>> I'd like to start a vote on FLIP-507: Add Model DDL methods in TABLE
>>>> API
>>>>>> [1] which has been discussed in this thread [2].
>>>>>>
>>>>>> The vote will be open for at least 72 hours unless there is an
>>>> objection
>>>>> or
>>>>>> not enough votes.
>>>>>>
>>>>>> [1]
>>>>>>
>>>>>>
>>>>>
>>>>
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-507%3A+Add+Model+DDL+methods+in+TABLE+API
>>>>>> [2] https://lists.apache.org/thread/w9dt6y1w0yns5j3g4685tstjdg5flvy9
>>>>>>
>>>>>
>>>>
>>>
>>
>>
Re: [VOTE] FLIP-507: Add Model DDL methods in TABLE API
Posted by Leonard Xu <xb...@gmail.com>.
Sorry for jumping the thread late, but I think current status of this FLIP is not ready, at least for me
(1) Could you finish your proposed API according Flink API bylaws? For example the code piece should be:
Builder<SELF> {
SELF option(String key, String value
SELF setComment(@Nullable String comment);
=>
/** Builder for {@link ModelDescriptor}. **/
@PublicEvolving
Builder<SELF> {
/** Defines the option of {@link ModelDescriptor}. **/
SELF option(String key, String value);
/** Defines the comment of {@link ModelDescriptor}. **/
SELF setComment(@Nullable String comment);
(2) TableEnvironment is a public API, so any changes (such as adding public methods in this case) must be clearly documented. You may refer to [1] as an example. In the [Public Interfaces] section of this FLIP, only TableEnvironment is listed. However, the subsequent [Proposed Changes] section appears to conflate TableEnvironment with ModelDescriptor. Clarifications are needed:
Which package should ModelDescriptor belong to?
Is ModelDescriptor intended to be an inner class of TableEnvironment?
At last, this is a useful FLIP and I generally agree with the motivation and design, but it is not clear and standardized enough.
I will not directly -1 to cancel existing voting process, but I hope to continue voting after the addressed above(1)(2) comments. WDYT?
Best,
Leonard
[1] https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=334760466
> 2025年3月11日 01:19，Yash Anand <ya...@confluent.io.INVALID> 写道：
>
> Hi Timo,
>
> Thanks for pointing that out. I have added the full API of
> the ModelDescriptor in the FLIP.
>
> Thanks,
> Yash Anand
>
>
> On Mon, Mar 10, 2025 at 11:27 AM Timo Walther <tw...@apache.org> wrote:
>
>> Hi Yash,
>>
>> could you provide the full API of the ModelDescriptor in the FLIP?
>>
>> Thanks,
>> Timo
>>
>>
>> On 10.03.25 16:55, Mingge Deng wrote:
>>> Thanks Yash!
>>>
>>> +1 (binding)
>>>
>>> Best,
>>> Mingge
>>>
>>>
>>> On Mon, Mar 10, 2025 at 8:51 AM Dawid Wysakowicz <dwysakowicz@apache.org
>>>
>>> wrote:
>>>
>>>> +1 (binding)
>>>> Best,
>>>> Dawid
>>>>
>>>> On Wed, 19 Feb 2025 at 18:37, Hao Li <hl...@confluent.io.invalid> wrote:
>>>>
>>>>> +1 (non-binding)
>>>>>
>>>>> Thanks Yash,
>>>>> Hao
>>>>>
>>>>> On Tue, Feb 18, 2025 at 10:46 AM Yash Anand
>> <yanand@confluent.io.invalid
>>>>>
>>>>> wrote:
>>>>>
>>>>>> Hi Everyone,
>>>>>>
>>>>>> I'd like to start a vote on FLIP-507: Add Model DDL methods in TABLE
>>>> API
>>>>>> [1] which has been discussed in this thread [2].
>>>>>>
>>>>>> The vote will be open for at least 72 hours unless there is an
>>>> objection
>>>>> or
>>>>>> not enough votes.
>>>>>>
>>>>>> [1]
>>>>>>
>>>>>>
>>>>>
>>>>
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-507%3A+Add+Model+DDL+methods+in+TABLE+API
>>>>>> [2] https://lists.apache.org/thread/w9dt6y1w0yns5j3g4685tstjdg5flvy9
>>>>>>
>>>>>
>>>>
>>>
>>
>>
Re: [VOTE] FLIP-507: Add Model DDL methods in TABLE API
Posted by Yash Anand <ya...@confluent.io.INVALID>.
Hi Timo,
Thanks for pointing that out. I have added the full API of
the ModelDescriptor in the FLIP.
Thanks,
Yash Anand
On Mon, Mar 10, 2025 at 11:27 AM Timo Walther <tw...@apache.org> wrote:
> Hi Yash,
>
> could you provide the full API of the ModelDescriptor in the FLIP?
>
> Thanks,
> Timo
>
>
> On 10.03.25 16:55, Mingge Deng wrote:
> > Thanks Yash!
> >
> > +1 (binding)
> >
> > Best,
> > Mingge
> >
> >
> > On Mon, Mar 10, 2025 at 8:51 AM Dawid Wysakowicz <dwysakowicz@apache.org
> >
> > wrote:
> >
> >> +1 (binding)
> >> Best,
> >> Dawid
> >>
> >> On Wed, 19 Feb 2025 at 18:37, Hao Li <hl...@confluent.io.invalid> wrote:
> >>
> >>> +1 (non-binding)
> >>>
> >>> Thanks Yash,
> >>> Hao
> >>>
> >>> On Tue, Feb 18, 2025 at 10:46 AM Yash Anand
> <yanand@confluent.io.invalid
> >>>
> >>> wrote:
> >>>
> >>>> Hi Everyone,
> >>>>
> >>>> I'd like to start a vote on FLIP-507: Add Model DDL methods in TABLE
> >> API
> >>>> [1] which has been discussed in this thread [2].
> >>>>
> >>>> The vote will be open for at least 72 hours unless there is an
> >> objection
> >>> or
> >>>> not enough votes.
> >>>>
> >>>> [1]
> >>>>
> >>>>
> >>>
> >>
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-507%3A+Add+Model+DDL+methods+in+TABLE+API
> >>>> [2] https://lists.apache.org/thread/w9dt6y1w0yns5j3g4685tstjdg5flvy9
> >>>>
> >>>
> >>
> >
>
>
Re: [VOTE] FLIP-507: Add Model DDL methods in TABLE API
Posted by Timo Walther <tw...@apache.org>.
Hi Yash,
could you provide the full API of the ModelDescriptor in the FLIP?
Thanks,
Timo
On 10.03.25 16:55, Mingge Deng wrote:
> Thanks Yash!
>
> +1 (binding)
>
> Best,
> Mingge
>
>
> On Mon, Mar 10, 2025 at 8:51 AM Dawid Wysakowicz <dw...@apache.org>
> wrote:
>
>> +1 (binding)
>> Best,
>> Dawid
>>
>> On Wed, 19 Feb 2025 at 18:37, Hao Li <hl...@confluent.io.invalid> wrote:
>>
>>> +1 (non-binding)
>>>
>>> Thanks Yash,
>>> Hao
>>>
>>> On Tue, Feb 18, 2025 at 10:46 AM Yash Anand <yanand@confluent.io.invalid
>>>
>>> wrote:
>>>
>>>> Hi Everyone,
>>>>
>>>> I'd like to start a vote on FLIP-507: Add Model DDL methods in TABLE
>> API
>>>> [1] which has been discussed in this thread [2].
>>>>
>>>> The vote will be open for at least 72 hours unless there is an
>> objection
>>> or
>>>> not enough votes.
>>>>
>>>> [1]
>>>>
>>>>
>>>
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-507%3A+Add+Model+DDL+methods+in+TABLE+API
>>>> [2] https://lists.apache.org/thread/w9dt6y1w0yns5j3g4685tstjdg5flvy9
>>>>
>>>
>>
>
Re: [VOTE] FLIP-507: Add Model DDL methods in TABLE API
Posted by Mingge Deng <md...@confluent.io.INVALID>.
Thanks Yash!
+1 (binding)
Best,
Mingge
On Mon, Mar 10, 2025 at 8:51 AM Dawid Wysakowicz <dw...@apache.org>
wrote:
> +1 (binding)
> Best,
> Dawid
>
> On Wed, 19 Feb 2025 at 18:37, Hao Li <hl...@confluent.io.invalid> wrote:
>
> > +1 (non-binding)
> >
> > Thanks Yash,
> > Hao
> >
> > On Tue, Feb 18, 2025 at 10:46 AM Yash Anand <yanand@confluent.io.invalid
> >
> > wrote:
> >
> > > Hi Everyone,
> > >
> > > I'd like to start a vote on FLIP-507: Add Model DDL methods in TABLE
> API
> > > [1] which has been discussed in this thread [2].
> > >
> > > The vote will be open for at least 72 hours unless there is an
> objection
> > or
> > > not enough votes.
> > >
> > > [1]
> > >
> > >
> >
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-507%3A+Add+Model+DDL+methods+in+TABLE+API
> > > [2] https://lists.apache.org/thread/w9dt6y1w0yns5j3g4685tstjdg5flvy9
> > >
> >
>