You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/28 04:45:55 UTC

[GitHub] [incubator-superset] villebro commented on pull request #9665: [fix] Ensuring cache warmup respects request form data

villebro commented on pull request #9665:
URL: https://github.com/apache/incubator-superset/pull/9665#issuecomment-620377827


   @john-bodley I agree that it's not optimal to be passing around `form_data` in many different contexts, but in the short term this is probably the best solution. To make this more robust, perhaps we should introduce a util that has this logic in one central place? There we could also add any necessary documentation to explain why this is necessary.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org