You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by "Benjamin Marwell (Jira)" <ji...@apache.org> on 2019/12/13 19:48:00 UTC

[jira] [Created] (MCHECKSTYLE-386) Method 'isViolation' has a unfortunate name

Benjamin Marwell created MCHECKSTYLE-386:
--------------------------------------------

             Summary: Method 'isViolation' has a unfortunate name
                 Key: MCHECKSTYLE-386
                 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-386
             Project: Maven Checkstyle Plugin
          Issue Type: Task
          Components: checkstyle:check
    Affects Versions: 3.1.0
            Reporter: Benjamin Marwell


The method {{isViolation}} checks if a violation should be reported or not according to the user configuration. Therefore, it does not change the violation to be a violation. Instead, it should reflect that behaviour.

https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357680549



--
This message was sent by Atlassian Jira
(v8.3.4#803005)