You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2023/01/01 10:35:49 UTC
[GitHub] [shardingsphere] codecov-commenter commented on pull request #23239: Close heartbeat job when drop discovery rule
codecov-commenter commented on PR #23239:
URL: https://github.com/apache/shardingsphere/pull/23239#issuecomment-1368410112
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23239?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23239](https://codecov.io/gh/apache/shardingsphere/pull/23239?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (10fcab8) into [master](https://codecov.io/gh/apache/shardingsphere/commit/b8e24e026aa91db64ee3e027d9a9d4880b5b4158?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b8e24e0) will **increase** coverage by `0.05%`.
> The diff coverage is `50.00%`.
```diff
@@ Coverage Diff @@
## master #23239 +/- ##
============================================
+ Coverage 49.89% 49.94% +0.05%
Complexity 2453 2453
============================================
Files 4021 4021
Lines 57537 57541 +4
Branches 9132 9132
============================================
+ Hits 28706 28738 +32
+ Misses 26289 26259 -30
- Partials 2542 2544 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...sphere/dbdiscovery/rule/DatabaseDiscoveryRule.java](https://codecov.io/gh/apache/shardingsphere/pull/23239/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZGItZGlzY292ZXJ5L2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiZGlzY292ZXJ5L3J1bGUvRGF0YWJhc2VEaXNjb3ZlcnlSdWxlLmphdmE=) | `64.10% <0.00%> (-3.47%)` | :arrow_down: |
| [...distsql/rdl/rule/RuleDefinitionBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/23239/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmRsL3J1bGUvUnVsZURlZmluaXRpb25CYWNrZW5kSGFuZGxlci5qYXZh) | `72.09% <ø> (-0.64%)` | :arrow_down: |
| [...ate/DropDatabaseDiscoveryRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/23239/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZGItZGlzY292ZXJ5L2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGJkaXNjb3ZlcnkvZGlzdHNxbC9oYW5kbGVyL3VwZGF0ZS9Ecm9wRGF0YWJhc2VEaXNjb3ZlcnlSdWxlU3RhdGVtZW50VXBkYXRlci5qYXZh) | `88.23% <100.00%> (+0.73%)` | :arrow_up: |
| [...gsphere/infra/metadata/ShardingSphereMetaData.java](https://codecov.io/gh/apache/shardingsphere/pull/23239/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9TaGFyZGluZ1NwaGVyZU1ldGFEYXRhLmphdmE=) | `81.48% <100.00%> (ø)` | |
| [...ndler/update/CreateShadowRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/23239/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhZG93L2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhZG93L2Rpc3RzcWwvaGFuZGxlci91cGRhdGUvQ3JlYXRlU2hhZG93UnVsZVN0YXRlbWVudFVwZGF0ZXIuamF2YQ==) | `62.16% <0.00%> (-4.51%)` | :arrow_down: |
| [.../CreateDefaultShadowAlgorithmStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/23239/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhZG93L2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhZG93L2Rpc3RzcWwvaGFuZGxlci91cGRhdGUvQ3JlYXRlRGVmYXVsdFNoYWRvd0FsZ29yaXRobVN0YXRlbWVudFVwZGF0ZXIuamF2YQ==) | `50.00% <0.00%> (ø)` | |
| [...e/agent/metrics/core/advice/TransactionAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/23239/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy9tZXRyaWNzL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L21ldHJpY3MvY29yZS9hZHZpY2UvVHJhbnNhY3Rpb25BZHZpY2UuamF2YQ==) | | |
| [...rics/prometheus/wrapper/type/HistogramWrapper.java](https://codecov.io/gh/apache/shardingsphere/pull/23239/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy9tZXRyaWNzL3R5cGUvcHJvbWV0aGV1cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvbWV0cmljcy9wcm9tZXRoZXVzL3dyYXBwZXIvdHlwZS9IaXN0b2dyYW1XcmFwcGVyLmphdmE=) | | |
| [...gent/metrics/core/advice/SQLRouteEngineAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/23239/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy9tZXRyaWNzL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L21ldHJpY3MvY29yZS9hZHZpY2UvU1FMUm91dGVFbmdpbmVBZHZpY2UuamF2YQ==) | | |
| [...s/prometheus/wrapper/PrometheusWrapperFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/23239/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy9tZXRyaWNzL3R5cGUvcHJvbWV0aGV1cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvbWV0cmljcy9wcm9tZXRoZXVzL3dyYXBwZXIvUHJvbWV0aGV1c1dyYXBwZXJGYWN0b3J5LmphdmE=) | | |
| ... and [34 more](https://codecov.io/gh/apache/shardingsphere/pull/23239/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org