[GitHub] [airflow] VladaZakharova commented on a diff in pull request #29260: Add deferrable mode to ExternalTaskSensor

["VladaZakharova (via GitHub)" <gi...@apache.org>]

VladaZakharova commented on code in PR #29260:
URL: https://github.com/apache/airflow/pull/29260#discussion_r1094455152


##########
airflow/sensors/external_task.py:
##########
@@ -360,6 +362,93 @@ def _handle_execution_date_fn(self, context) -> Any:
         return kwargs_callable(logical_date, **kwargs)
 
 
+class ExternalTaskAsyncSensor(ExternalTaskSensor):

Review Comment:
   Hi Team! :)
   This sensor was implemented as a separate AsyncSensor to follow our discussion from the PR for big query operators: https://github.com/apache/airflow/pull/26156
   
   So, as Sensors with deferrable option are not sensors, but mostly Operators with execute() method, this Sensor was also implemented as a separate class with deferrable mode.
   
   I will update this PR to fix static checks and reach you later for final review :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org