You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by DivineEnder <gi...@git.apache.org> on 2017/06/28 00:04:44 UTC

[GitHub] geode pull request #608: GEODE-3140: Removed DiskDirRule and replaced use wi...

GitHub user DivineEnder opened a pull request:

    https://github.com/apache/geode/pull/608

    GEODE-3140: Removed DiskDirRule and replaced use with TemporaryFolder…

    … rule
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    - [ ] Does `gradlew build` run cleanly?
    
    - [ ] Have you written or updated unit tests to verify your changes?
    
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DivineEnder/geode feature/GEODE-3140

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/608.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #608
    
----
commit 8e43d6139c13ad5de6355f34637d92af8e9d699e
Author: David Anuta <da...@gmail.com>
Date:   2017-06-28T00:00:00Z

    GEODE-3140: Removed DiskDirRule and replaced use with TemporaryFolder rule

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #608: GEODE-3140: Removed DiskDirRule and replaced use wi...

Posted by DivineEnder <gi...@git.apache.org>.
Github user DivineEnder commented on a diff in the pull request:

    https://github.com/apache/geode/pull/608#discussion_r124621529
  
    --- Diff: geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPersistenceIntegrationTest.java ---
    @@ -48,13 +49,13 @@
     public class LuceneQueriesPersistenceIntegrationTest extends LuceneIntegrationTest {
     
       @Rule
    -  public DiskDirRule diskDirRule = new DiskDirRule();
    +  public TemporaryFolder tempFolderRule = new TemporaryFolder(new File("."));
    --- End diff --
    
    Yeah. That's a good idea. Turns out there is an empty TemporaryFolder constructor, so I'll make that change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #608: GEODE-3140: Removed DiskDirRule and replaced use with Temp...

Posted by DivineEnder <gi...@git.apache.org>.
Github user DivineEnder commented on the issue:

    https://github.com/apache/geode/pull/608
  
    @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #608: GEODE-3140: Removed DiskDirRule and replaced use wi...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/geode/pull/608


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #608: GEODE-3140: Removed DiskDirRule and replaced use wi...

Posted by jinmeiliao <gi...@git.apache.org>.
Github user jinmeiliao commented on a diff in the pull request:

    https://github.com/apache/geode/pull/608#discussion_r124434616
  
    --- Diff: geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPersistenceIntegrationTest.java ---
    @@ -48,13 +49,13 @@
     public class LuceneQueriesPersistenceIntegrationTest extends LuceneIntegrationTest {
     
       @Rule
    -  public DiskDirRule diskDirRule = new DiskDirRule();
    +  public TemporaryFolder tempFolderRule = new TemporaryFolder(new File("."));
    --- End diff --
    
    Is there any reason we want to pass in a parentFolder of current dir? Can we just use the temp folder that we don't care about where it is?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #608: GEODE-3140: Removed DiskDirRule and replaced use with Temp...

Posted by upthewaterspout <gi...@git.apache.org>.
Github user upthewaterspout commented on the issue:

    https://github.com/apache/geode/pull/608
  
    +1 - I'll merge this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---