You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@age.apache.org by GitBox <gi...@apache.org> on 2022/10/10 19:45:06 UTC
[GitHub] [age] skkk98 opened a new issue, #321: SQL Command throws Error in cypher.sql
skkk98 opened a new issue, #321:
URL: https://github.com/apache/age/issues/321
I came across some commands that throw errors in cypher.sql and I am not sure whether this is expected behavior or not.
I am unsure whether this is okay because the expected and actual results throw log these errors when running this command.
`SELECT * FROM cypher('cypher', 'RETURN 0') AS r(c text);`
`ERROR: a dollar-quoted string constant is expected`
`LINE 1: SELECT * FROM cypher('cypher', 'RETURN 0') AS r(c text);`
`SELECT * FROM cypher('cypher', NULL) AS r(c text);`
`ERROR: a dollar-quoted string constant is expected`
`LINE 1: SELECT * FROM cypher('cypher', NULL) AS r(c text);`
Are these test cases valid? Or should it be changed? like `SELECT * FROM cypher('cypher', $$RETURN 0$$) AS r(c text);`
Also if these test cases are valid then is okay to add a test case like `SELECT * FROM cypher('cypher', ##RETURN 0##) AS r(c text);` since this will throw an error as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] SQL Command throws Error in cypher.sql [age]
Posted by "shinyaaa (via GitHub)" <gi...@apache.org>.
shinyaaa commented on issue #321:
URL: https://github.com/apache/age/issues/321#issuecomment-2277652360
The following comments are written before those tests, so I think no additional comments will be necessary.
```
-- cypher() function takes only a dollar-quoted string constant as an argument.
-- All other cases throw an error.
```
https://github.com/apache/age/blob/master/regress/sql/cypher.sql#L25-L26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] JoshInnis commented on issue #321: SQL Command throws Error in cypher.sql
Posted by GitBox <gi...@apache.org>.
JoshInnis commented on issue #321:
URL: https://github.com/apache/age/issues/321#issuecomment-1273980934
Yes those regression tests are confirming that the second argument of the Cypher function cannot be NULL and cannot be a single-quoted string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] SQL Command throws Error in cypher.sql [age]
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani commented on issue #321:
URL: https://github.com/apache/age/issues/321#issuecomment-2278625693
@shinyaaa This isn't necessarily true anymore. The function can be called, in special cases, cypher(null, null).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] jrgemignani commented on issue #321: SQL Command throws Error in cypher.sql
Posted by GitBox <gi...@apache.org>.
jrgemignani commented on issue #321:
URL: https://github.com/apache/age/issues/321#issuecomment-1281248697
If this has been resolved, please make sure to close the issue :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] jrgemignani commented on issue #321: SQL Command throws Error in cypher.sql
Posted by GitBox <gi...@apache.org>.
jrgemignani commented on issue #321:
URL: https://github.com/apache/age/issues/321#issuecomment-1282646770
Sorry, I should have noted the following before suggesting closing the issue -
If those regression tests are supposed to throw errors **and** there isn't a comment stating that, I think that a comment should be added for clarity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] skkk98 closed issue #321: SQL Command throws Error in cypher.sql
Posted by GitBox <gi...@apache.org>.
skkk98 closed issue #321: SQL Command throws Error in cypher.sql
URL: https://github.com/apache/age/issues/321
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org