[GitHub] [spark] cloud-fan commented on a change in pull request #35686: [SPARK-38354][SQL] Add hash probes metric for shuffled hash join

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #35686:
URL: https://github.com/apache/spark/pull/35686#discussion_r821664342



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
##########
@@ -780,10 +806,13 @@ private[execution] final class LongToUnsafeRowMap(val mm: TaskMemoryManager, cap
    * Update the address in array for given key.
    */
   private def updateIndex(key: Long, address: Long): Unit = {
+    numKeyLookups += 1
+    numProbes += 1

Review comment:
       hmm, do we need to track the probe time when building the hash relation?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org