You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "xiangfu0 (via GitHub)" <gi...@apache.org> on 2025/11/04 20:56:46 UTC
[PR] feat(array): add arrayPushFront/arrayPushBack scalar functions for all types [pinot]
xiangfu0 opened a new pull request, #17140:
URL: https://github.com/apache/pinot/pull/17140
Add unit and integration tests; update UDF snapshot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] feat(array): add arrayPushFront/arrayPushBack scalar functions for all types [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17140:
URL: https://github.com/apache/pinot/pull/17140#issuecomment-3488107551
### :x: 2 Tests Failed:
| Tests completed | Failed | Passed | Skipped |
|---|---|---|---|
| 5570 | 2 | 5568 | 0 |
<details><summary>View the top 2 failed test(s) by shortest run time</summary>
> <pre><code class="language-python">org.apache.pinot.controller.helix.core.minion.PinotTaskManagerDistributedLockingTest::testForceReleaseLockDuringTaskExecution</code></pre>
> <details><summary>Stack Traces | 18.3s run time</summary>
>
> > <pre><code class="language-python">Tasks should complete within 15 seconds expected [true] but found [false]</code></pre>
>
> </details>
> <pre><code class="language-python">org.apache.pinot.controller.helix.core.minion.PinotTaskManagerDistributedLockingTest::testForceReleaseLockDuringTaskExecution</code></pre>
> <details><summary>Stack Traces | 20.5s run time</summary>
>
> > <pre><code class="language-python">Tasks should complete within 15 seconds expected [true] but found [false]</code></pre>
>
> </details>
</details>
To view more test analytics, go to the [Test Analytics Dashboard](https://app.codecov.io/gh/apache/pinot/tests/xiangfu0%3Afeat%2Farray-push-front-back)
<sub>📋 Got 3 mins? [Take this short survey](https://forms.gle/22i53Qa1CySZjA6c7) to help us improve Test Analytics.</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] feat(array): add arrayPushFront/arrayPushBack scalar functions for all types [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on code in PR #17140:
URL: https://github.com/apache/pinot/pull/17140#discussion_r2492384178
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/ArrayTest.java:
##########
@@ -579,6 +579,68 @@ public void testStringArrayLiteral(boolean useMultiStageQueryEngine)
}
}
+ @Test(dataProvider = "useBothQueryEngines")
+ public void testArrayPushBackAndFrontString(boolean useMultiStageQueryEngine)
+ throws Exception {
+ setUseMultiStageQueryEngine(useMultiStageQueryEngine);
+ for (boolean withFrom : new boolean[]{true, false}) {
Review Comment:
just test the static scalar function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] feat(array): add arrayPushFront/arrayPushBack scalar functions for all types [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 merged PR #17140:
URL: https://github.com/apache/pinot/pull/17140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] feat(array): add arrayPushFront/arrayPushBack scalar functions for all types [pinot]
Posted by "yashmayya (via GitHub)" <gi...@apache.org>.
yashmayya commented on code in PR #17140:
URL: https://github.com/apache/pinot/pull/17140#discussion_r2492239306
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/ArrayTest.java:
##########
@@ -579,6 +579,68 @@ public void testStringArrayLiteral(boolean useMultiStageQueryEngine)
}
}
+ @Test(dataProvider = "useBothQueryEngines")
+ public void testArrayPushBackAndFrontString(boolean useMultiStageQueryEngine)
+ throws Exception {
+ setUseMultiStageQueryEngine(useMultiStageQueryEngine);
+ for (boolean withFrom : new boolean[]{true, false}) {
Review Comment:
Why is this with / without from needed here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org