[GitHub] [arrow] jvanstraten commented on a diff in pull request #13528: ARROW-16989: [C++] Substrait ProjectRel is interpreted incorrectly

[GitBox <gi...@apache.org>]

jvanstraten commented on code in PR #13528:
URL: https://github.com/apache/arrow/pull/13528#discussion_r918384419


##########
cpp/src/arrow/engine/substrait/relation_internal.h:
##########
@@ -30,8 +30,17 @@
 namespace arrow {
 namespace engine {
 
+/// Information resulting from converting a Substrait relation.
+struct DeclarationInfo {
+  /// The compute declaration produced thus far.
+  compute::Declaration declaration;
+
+  /// The number of columns returned by the declaration.
+  size_t num_columns;

Review Comment:
   Seems weird to me to use a signed integer for a size; IMO `Table` and `RecordBatch` are wrong to do that (if the 32/64-bitness is an issue, at least use `uint32_t` or `unsigned int`). Now you'd always get warnings when comparing with the `size_t`'s returned by STL containers.
   
   That said, I guess I won't argue with precedence...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org