You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/01/31 19:29:01 UTC
[GitHub] [iceberg] jun-he opened a new pull request #2188: Rename last-assigned-partition-id to last-partition-id in table metadata
jun-he opened a new pull request #2188:
URL: https://github.com/apache/iceberg/pull/2188
Follow up of https://github.com/apache/iceberg/pull/2089
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jun-he commented on pull request #2188: Rename last-assigned-partition-id to last-partition-id in table metadata
Posted by GitBox <gi...@apache.org>.
jun-he commented on pull request #2188:
URL: https://github.com/apache/iceberg/pull/2188#issuecomment-771092618
@rdblue Thanks for the review and updated the PR accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #2188: Rename last-assigned-partition-id to last-partition-id in table metadata
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #2188:
URL: https://github.com/apache/iceberg/pull/2188#issuecomment-771149668
Thanks, @jun-he! Looks good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #2188: Rename last-assigned-partition-id to last-partition-id in table metadata
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #2188:
URL: https://github.com/apache/iceberg/pull/2188#discussion_r568030825
##########
File path: core/src/main/java/org/apache/iceberg/BaseUpdatePartitionSpec.java
##########
@@ -69,7 +69,7 @@
this.schema = spec.schema();
this.nameToField = indexSpecByName(spec);
this.transformToField = indexSpecByTransform(spec);
- this.lastAssignedPartitionId = base.lastAssignedPartitionId();
+ this.lastAssignedPartitionId = base.lastPartitionId();
Review comment:
I don't think we need to rename the method, just the property in the metadata file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #2188: Rename last-assigned-partition-id to last-partition-id in table metadata
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #2188:
URL: https://github.com/apache/iceberg/pull/2188#issuecomment-771070700
@jun-he, can you roll back the field and and method name changes in other classes? I think we only need to change the table metadata property, not the others.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #2188: Rename last-assigned-partition-id to last-partition-id in table metadata
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #2188:
URL: https://github.com/apache/iceberg/pull/2188
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #2188: Rename last-assigned-partition-id to last-partition-id in table metadata
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #2188:
URL: https://github.com/apache/iceberg/pull/2188#discussion_r568030541
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadataParser.java
##########
@@ -291,10 +291,10 @@ static TableMetadata fromJson(FileIO io, InputFile file, JsonNode node) {
schema, TableMetadata.INITIAL_SPEC_ID, node.get(PARTITION_SPEC)));
}
- Integer lastAssignedPartitionId = JsonUtil.getIntOrNull(LAST_ASSIGNED_PARTITION_ID, node);
+ Integer lastAssignedPartitionId = JsonUtil.getIntOrNull(LAST_PARTITION_ID, node);
Review comment:
This property was just added, so the rename is safe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #2188: Rename last-assigned-partition-id to last-partition-id in table metadata
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on a change in pull request #2188:
URL: https://github.com/apache/iceberg/pull/2188#discussion_r567551488
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadataParser.java
##########
@@ -291,10 +291,10 @@ static TableMetadata fromJson(FileIO io, InputFile file, JsonNode node) {
schema, TableMetadata.INITIAL_SPEC_ID, node.get(PARTITION_SPEC)));
}
- Integer lastAssignedPartitionId = JsonUtil.getIntOrNull(LAST_ASSIGNED_PARTITION_ID, node);
+ Integer lastAssignedPartitionId = JsonUtil.getIntOrNull(LAST_PARTITION_ID, node);
Review comment:
Won't this break backwards compatibility?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org