You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2025/04/01 08:05:00 UTC
[jira] [Commented] (HDFS-17709) [ARR] Add async responder and async handler performance metrics.
[ https://issues.apache.org/jira/browse/HDFS-17709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939960#comment-17939960 ]
ASF GitHub Bot commented on HDFS-17709:
---------------------------------------
hfutatzhanghb commented on code in PR #7292:
URL: https://github.com/apache/hadoop/pull/7292#discussion_r2022357808
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/protocolPB/AsyncRpcProtocolPBUtil.java:
##########
@@ -87,6 +89,7 @@ public static <T, R> R asyncIpcClient(
// transfer thread local context to worker threads of executor.
ThreadLocalContext threadLocalContext = new ThreadLocalContext();
asyncCompleteWith(responseFuture.handleAsync((result, e) -> {
+ FederationRPCMetrics.ASYNC_RESPONDER_START_TIME.set(Time.monotonicNow());
Review Comment:
Hi, @KeeProMise . I think using ThreadLocalContext here will cause this metrics not accurate. What's your opinion? Hope to receive from you! Thanks.
> [ARR] Add async responder and async handler performance metrics.
> ----------------------------------------------------------------
>
> Key: HDFS-17709
> URL: https://issues.apache.org/jira/browse/HDFS-17709
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: rbf
> Reporter: farmmamba
> Assignee: farmmamba
> Priority: Major
> Labels: pull-request-available
> Attachments: image-2025-01-16-16-58-29-730.png
>
>
> Add metrics to measure the performance of async responder and async handler threads.
> This metric can guide us to tune the async responder and async handler thread pools.
>
> !image-2025-01-16-16-58-29-730.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org