You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by fujunwei <gi...@git.apache.org> on 2014/10/24 10:37:21 UTC
[GitHub] cordova-lib pull request: Add a type named "gradleReference" in fr...
GitHub user fujunwei opened a pull request:
https://github.com/apache/cordova-lib/pull/111
Add a type named "gradleReference" in framework
It's too complex to dependence AAR in plugin, we need build the plugin to a android project which include AndroidManifest.xml. This patch is apply the build-extras.gradle from plugin to root project. It will be compiled when execute build-extras.gradle in root project. It looks like.
repositories {
maven {
url 'https://download.01.org/crosswalk/releases/crosswalk/android/maven2'
}
}
dependencies {
compile 'org.xwalk:xwalk_core_library_beta:9.38.208.4'
}
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fujunwei/cordova-lib gradleReference
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/111.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #111
----
commit 7083092b3e877185e5f8432d20ba56d83bf12333
Author: fujunwei <ju...@intel.com>
Date: 2014-10-24T08:11:59Z
Add a type named "gradleReference" in framework
It's too complex to dependence AAR in plugin, it need build the plugin
to a android project which include AndroidManifest.xml. This patch
reference the build-extras.gradle in plugin to root project. Below is
a demo.
repositories {
maven {
url 'https://download.01.org/crosswalk/releases/crosswalk/android/maven2'
}
}
dependencies {
compile 'org.xwalk:xwalk_core_library_beta:9.38.208.4'
}
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: Add a type named "gradleReference" in fr...
Posted by fujunwei <gi...@git.apache.org>.
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-61198123
hi @clelland , Could you give some suggestion on the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: Add a type named "gradleReference" in fr...
Posted by fujunwei <gi...@git.apache.org>.
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-61446454
ping @clelland
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: Add a type named "gradleReference" in fr...
Posted by clelland <gi...@git.apache.org>.
Github user clelland commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-62004988
Sorry, Junwei -- I meant to take a look at this when you first posted it.
This looks good; I'm going to test it out with the Crosswalk AAR, and I'll merge it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: Add a type named "gradleReference" in fr...
Posted by clelland <gi...@git.apache.org>.
Github user clelland commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-62033701
What happens on upgrade, if a project already has a `platforms/android/build.gradle` file? Do we need to put some code in to either replace build.gradle or add the two guard lines in the right place? Or do we tell affected people to copy it or recreate their projects?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: Add a type named "gradleReference" in fr...
Posted by fujunwei <gi...@git.apache.org>.
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-62096240
> Tests should be updated with this as well (although they were failing on the branch before this PR)
There are no settings.gradle and libraries.gradle files in the project that was created by Cordova 4.0 master branch. The commit "add library projects to gradle build config on plugin install" can't work in Cordova 4.0 master now. Should we merge the PR to master branch not dependent on the before PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: Add a type named "gradleReference" in fr...
Posted by clelland <gi...@git.apache.org>.
Github user clelland commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-62037845
Tests should be updated with this as well (although they were failing on the branch before this PR)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: Add a type named "gradleReference" in fr...
Posted by fujunwei <gi...@git.apache.org>.
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-60540658
hi @clelland, Is it a good approach to use Maven library in plugin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: Add a type named "gradleReference" in fr...
Posted by clelland <gi...@git.apache.org>.
Github user clelland commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-62037534
I've rebased this against master now, and pushed it up on a feature branch (`CB-3445-2`, to not conflict with the previous branch)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: Add a type named "gradleReference" in fr...
Posted by clelland <gi...@git.apache.org>.
Github user clelland commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-62038387
Pushed to apache/cordova-android as well, on a new CB-3445 branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: Add a type named "gradleReference" in fr...
Posted by fujunwei <gi...@git.apache.org>.
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-60359665
@clelland PTAL. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: Add a type named "gradleReference" in fr...
Posted by fujunwei <gi...@git.apache.org>.
Github user fujunwei closed the pull request at:
https://github.com/apache/cordova-lib/pull/111
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: Add a type named "gradleReference" in fr...
Posted by fujunwei <gi...@git.apache.org>.
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-61920987
@agrieve @clelland PTAL. Thanks.
The blow section will commit to ./bin/remplates/project/build.gradle
// PLUGIN GRADLE EXTENSIONS START
// PLUGIN GRADLE EXTENSIONS END
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: Add a type named "gradleReference" in fr...
Posted by fujunwei <gi...@git.apache.org>.
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-62082241
I think we should add the two lines automatically when upgrade the project.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org