You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/05/31 11:37:30 UTC
[GitHub] [netbeans] dbalek opened a new pull request, #4176: External Code Formatters added into NBLS.
dbalek opened a new pull request, #4176:
URL: https://github.com/apache/netbeans/pull/4176
Adding [External Java Code Formatters for NetBeans](https://plugins.netbeans.apache.org/catalogue/?id=15) module into [NBLS](https://marketplace.visualstudio.com/items?itemName=ASF.apache-netbeans-java).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] dbalek commented on a diff in pull request #4176: External Code Formatters added into NBLS.
Posted by GitBox <gi...@apache.org>.
dbalek commented on code in PR #4176:
URL: https://github.com/apache/netbeans/pull/4176#discussion_r890187203
##########
java/java.lsp.server/build.xml:
##########
@@ -42,8 +42,8 @@
<chmod file="${lsp.build.dir}/platform/lib/nbexec" perm="u+x"/>
<chmod file="${lsp.build.dir}/java/maven/bin/mvn" perm="u+x" />
- <property name="3rdparty.modules" value=".*nbjavac.*"/>
- <autoupdate todir="${lsp.build.dir}/extra" updatecenter="file://${nb_all}/nb/updatecenters/build/classes/org/netbeans/modules/updatecenters/resources/3rdparty-catalog.xml">
Review Comment:
The build of this module has to happen online already - see the `proxy-setup` build target couple of lines above...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a diff in pull request #4176: External Code Formatters added into NBLS.
Posted by GitBox <gi...@apache.org>.
sdedic commented on code in PR #4176:
URL: https://github.com/apache/netbeans/pull/4176#discussion_r890105911
##########
java/java.lsp.server/vscode/package-lock.json:
##########
@@ -9,8 +9,8 @@
"version": "0.1.0",
"license": "Apache 2.0",
"dependencies": {
+ "@vscode/debugadapter": "1.55.1",
"jsonc-parser": "3.0.0",
- "vscode-debugadapter": "1.51.0",
Review Comment:
Intentional change ?
##########
java/java.lsp.server/build.xml:
##########
@@ -42,8 +42,8 @@
<chmod file="${lsp.build.dir}/platform/lib/nbexec" perm="u+x"/>
<chmod file="${lsp.build.dir}/java/maven/bin/mvn" perm="u+x" />
- <property name="3rdparty.modules" value=".*nbjavac.*"/>
- <autoupdate todir="${lsp.build.dir}/extra" updatecenter="file://${nb_all}/nb/updatecenters/build/classes/org/netbeans/modules/updatecenters/resources/3rdparty-catalog.xml">
Review Comment:
Hm, doesn't this require that the build only happens online ... if so, any idea how it could reuse once downloaded info or disable the external fetch for a routine development build ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] dbalek commented on a diff in pull request #4176: External Code Formatters added into NBLS.
Posted by GitBox <gi...@apache.org>.
dbalek commented on code in PR #4176:
URL: https://github.com/apache/netbeans/pull/4176#discussion_r890167761
##########
java/java.lsp.server/vscode/package-lock.json:
##########
@@ -9,8 +9,8 @@
"version": "0.1.0",
"license": "Apache 2.0",
"dependencies": {
+ "@vscode/debugadapter": "1.55.1",
"jsonc-parser": "3.0.0",
- "vscode-debugadapter": "1.51.0",
Review Comment:
Yes - `vscode-debugadapter` has been renamed to `@vscode/debugadapter`. This prevents warning messages in the build's log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] dbalek merged pull request #4176: External Code Formatters added into NBLS.
Posted by GitBox <gi...@apache.org>.
dbalek merged PR #4176:
URL: https://github.com/apache/netbeans/pull/4176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists