You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/30 08:31:21 UTC
[GitHub] [arrow] houqp opened a new pull request #9369: ARROW-11435: [Datafusion] allow creating ParquetPartition from external crate
houqp opened a new pull request #9369:
URL: https://github.com/apache/arrow/pull/9369
Without this, it's not possible to create TableProvider in external crate that tagets parquet format because `ParquetExec::new` takes `ParquetPartition` as argument.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9369: ARROW-11435: [Datafusion] allow creating ParquetPartition from external crate
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9369:
URL: https://github.com/apache/arrow/pull/9369#issuecomment-770177758
https://issues.apache.org/jira/browse/ARROW-11435
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] houqp commented on pull request #9369: ARROW-11435: [Datafusion] allow creating ParquetPartition from external crate, make combine_filters public
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #9369:
URL: https://github.com/apache/arrow/pull/9369#issuecomment-771880908
@andygrove @alamb gentle ping to help with the merge if everything looks good on your end ;P
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #9369: ARROW-11435: [Datafusion] allow creating ParquetPartition from external crate, make combine_filters public
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9369:
URL: https://github.com/apache/arrow/pull/9369
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9369: ARROW-11435: [Datafusion] allow creating ParquetPartition from external crate, make combine_filters public
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9369:
URL: https://github.com/apache/arrow/pull/9369#issuecomment-771919547
Looks good to me -- I'll merge it in!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] houqp commented on pull request #9369: ARROW-11435: [Datafusion] allow creating ParquetPartition from external crate, make combine_filters public
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #9369:
URL: https://github.com/apache/arrow/pull/9369#issuecomment-771880908
@andygrove @alamb gentle ping to help with the merge if everything looks good on your end ;P
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #9369: ARROW-11435: [Datafusion] allow creating ParquetPartition from external crate, make combine_filters public
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9369:
URL: https://github.com/apache/arrow/pull/9369
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9369: ARROW-11435: [Datafusion] allow creating ParquetPartition from external crate
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9369:
URL: https://github.com/apache/arrow/pull/9369#issuecomment-770179511
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9369?src=pr&el=h1) Report
> Merging [#9369](https://codecov.io/gh/apache/arrow/pull/9369?src=pr&el=desc) (96485ec) into [master](https://codecov.io/gh/apache/arrow/commit/f05b49bb08c0a4cc0cbfcfb07103dcf374c7fd38?el=desc) (f05b49b) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/arrow/pull/9369?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9369 +/- ##
==========================================
- Coverage 81.94% 81.94% -0.01%
==========================================
Files 231 231
Lines 53374 53375 +1
==========================================
- Hits 43739 43738 -1
- Misses 9635 9637 +2
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9369?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/datafusion/src/physical\_plan/parquet.rs](https://codecov.io/gh/apache/arrow/pull/9369/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL3BhcnF1ZXQucnM=) | `88.10% <0.00%> (-0.14%)` | :arrow_down: |
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9369/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `94.86% <0.00%> (-0.20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9369?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9369?src=pr&el=footer). Last update [f05b49b...c46ff83](https://codecov.io/gh/apache/arrow/pull/9369?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9369: ARROW-11435: [Datafusion] allow creating ParquetPartition from external crate, make combine_filters public
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9369:
URL: https://github.com/apache/arrow/pull/9369#issuecomment-771919547
Looks good to me -- I'll merge it in!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org