[GitHub] [mynewt-nimble] sjanc commented on a diff in pull request #1403: nimble/host : Added new method of marking an api as deprecated.

["sjanc (via GitHub)" <gi...@apache.org>]

sjanc commented on code in PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#discussion_r1095630289


##########
nimble/host/include/host/ble_hs.h:
##########
@@ -184,6 +184,22 @@ extern "C" {
 
 /** CSRK distibution and LinkKey are not supported */
 
+/**
+ * @}
+ */
+
+/**
+ * @brief LE deprecate warning
+ *
+ * @{
+ */
+
+#if MYNEWT_VAL(BLE_SUPPRESS_DEPRECATE_WARN)
+#define NIMBLE_DEPRECATED(_msg) __attribute__((deprecated("Deprecated. Should not be used. " _msg)))

Review Comment:
   BLE_SUPPRESS_DEPRECATE_WARN:
           description: >
               This suppresses deprecated warning
           value: 0
   
   
   Enabling warning should be opt-int, not disabling those  ie:
   
   BLE_WARN_ON_DEPRECATE:
           description: >
               This enabling warning on used deprecated API.
           value: 0
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org